From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/5] nvme-rdma: Make sure to shutdown the controller if we can
Date: Tue, 2 Aug 2016 14:52:57 +0200 [thread overview]
Message-ID: <20160802125257.GD13235@lst.de> (raw)
In-Reply-To: <cf6b0293-aba9-1a6f-28f2-3754b2eec4af@grimberg.me>
On Tue, Aug 02, 2016@09:19:56AM +0300, Sagi Grimberg wrote:
>> I don't want ->queue_rq to peek at controller state. What I had
>> in mind was copying the PCIe behavior of failing early in the
>> timeout handler if we are in the reset handler, which will
>> mean blk_execute_rq will return ASAP with an error.
>
> Do we want the unnecessary ADMIN_TIMEOUT for sending a shutdown
> on a queue we know is not connected? I'm worried it will have scale
> issues...
Allright, let's go with your version.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Jay Freyensee
<james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Subject: Re: [PATCH 3/5] nvme-rdma: Make sure to shutdown the controller if we can
Date: Tue, 2 Aug 2016 14:52:57 +0200 [thread overview]
Message-ID: <20160802125257.GD13235@lst.de> (raw)
In-Reply-To: <cf6b0293-aba9-1a6f-28f2-3754b2eec4af-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
On Tue, Aug 02, 2016 at 09:19:56AM +0300, Sagi Grimberg wrote:
>> I don't want ->queue_rq to peek at controller state. What I had
>> in mind was copying the PCIe behavior of failing early in the
>> timeout handler if we are in the reset handler, which will
>> mean blk_execute_rq will return ASAP with an error.
>
> Do we want the unnecessary ADMIN_TIMEOUT for sending a shutdown
> on a queue we know is not connected? I'm worried it will have scale
> issues...
Allright, let's go with your version.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-02 12:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 19:57 [PATCH 0/5] Some fabrics fixes Sagi Grimberg
2016-07-29 19:57 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 1/5] nvme-rdma: Fix device removal handling Sagi Grimberg
2016-07-29 19:57 ` Sagi Grimberg
2016-08-01 11:00 ` Christoph Hellwig
2016-08-01 11:00 ` Christoph Hellwig
2016-07-29 19:57 ` [PATCH 2/5] nvme-rdma: Free the I/O tags when we delete the controller Sagi Grimberg
2016-07-29 19:57 ` Sagi Grimberg
2016-08-01 11:03 ` Christoph Hellwig
2016-08-01 11:03 ` Christoph Hellwig
2016-08-01 11:15 ` Sagi Grimberg
2016-08-01 11:15 ` Sagi Grimberg
2016-08-01 15:47 ` Christoph Hellwig
2016-08-01 15:47 ` Christoph Hellwig
2016-08-02 6:14 ` Sagi Grimberg
2016-08-02 6:14 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 3/5] nvme-rdma: Make sure to shutdown the controller if we can Sagi Grimberg
2016-07-29 19:57 ` Sagi Grimberg
2016-08-01 11:04 ` Christoph Hellwig
2016-08-01 11:04 ` Christoph Hellwig
2016-08-01 11:17 ` Sagi Grimberg
2016-08-01 11:17 ` Sagi Grimberg
2016-08-01 15:48 ` Christoph Hellwig
2016-08-01 15:48 ` Christoph Hellwig
2016-08-02 6:19 ` Sagi Grimberg
2016-08-02 6:19 ` Sagi Grimberg
2016-08-02 12:52 ` Christoph Hellwig [this message]
2016-08-02 12:52 ` Christoph Hellwig
2016-08-02 13:26 ` Sagi Grimberg
2016-08-02 13:26 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 4/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces Sagi Grimberg
2016-07-29 19:57 ` Sagi Grimberg
2016-08-01 11:06 ` Christoph Hellwig
2016-08-01 11:06 ` Christoph Hellwig
2016-08-01 11:21 ` Sagi Grimberg
2016-08-01 11:21 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 5/5] nvme-loop: " Sagi Grimberg
2016-07-29 19:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802125257.GD13235@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.