[PATCH] ti-ipc-rtos: Cleanup scripts for srcipk generation after compile

[PATCH] ti-ipc-rtos: Cleanup scripts for srcipk generation after compile

[Sam Nelson]

This avoid issues with double srcipk generation.
Resolves issues with empty srcipk package, with some latest updates in
meta-arago.

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 recipes-ti/ipc/ti-ipc-rtos_git.bb | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/recipes-ti/ipc/ti-ipc-rtos_git.bb b/recipes-ti/ipc/ti-ipc-rtos_git.bb
index c9c4714..0213782 100644
--- a/recipes-ti/ipc/ti-ipc-rtos_git.bb
+++ b/recipes-ti/ipc/ti-ipc-rtos_git.bb
@@ -35,7 +35,7 @@ SRCREV_ipc-metadata = "b6dd82a450d75b9483a7cc9b619a30cf3cc25ae6"
 S_ipc-examples = "${WORKDIR}/git/ipc-examples"
 S_ipc-metadata = "${WORKDIR}/git/ipc-metadata"
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 DEPENDS = "ti-xdctools ti-sysbios doxygen-native zip-native"
 DEPENDS_append_keystone = " ti-cgt6x-native \
@@ -82,6 +82,9 @@ RELEASE_SUFFIX = ""
 
 IPC_PACKAGE_DIR = "${S}/ipc-package"
 
+deltask do_create_srcipk
+addtask create_srcipk after do_compile before do_install
+
 do_compile() {
   oe_runmake -f ipc-bios.mak clean
   oe_runmake -f ipc-bios.mak release
@@ -123,10 +126,6 @@ do_compile() {
   fi
 }
 
-do_compile_append() {
-  sourceipk_do_create_srcipk
-}
-
 do_install() {
   IPC_VERSION=`echo ${PV}${RELEASE_SUFFIX} | sed -e 's|\.|_|g'`
   # Copy docs and other meta files
-- 
1.9.1

Re: [PATCH] ti-ipc-rtos: Cleanup scripts for srcipk generation after compile

[Denys Dmytriyenko]

NO, it shouldn't have been here in the first place! How did I miss it? I'm 
going to remove that compile_append() below.


On Tue, Aug 02, 2016 at 11:27:47AM -0400, Sam Nelson wrote:
> This avoid issues with double srcipk generation.
> Resolves issues with empty srcipk package, with some latest updates in
> meta-arago.
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  recipes-ti/ipc/ti-ipc-rtos_git.bb | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/recipes-ti/ipc/ti-ipc-rtos_git.bb b/recipes-ti/ipc/ti-ipc-rtos_git.bb
> index c9c4714..0213782 100644
> --- a/recipes-ti/ipc/ti-ipc-rtos_git.bb
> +++ b/recipes-ti/ipc/ti-ipc-rtos_git.bb
> @@ -35,7 +35,7 @@ SRCREV_ipc-metadata = "b6dd82a450d75b9483a7cc9b619a30cf3cc25ae6"
>  S_ipc-examples = "${WORKDIR}/git/ipc-examples"
>  S_ipc-metadata = "${WORKDIR}/git/ipc-metadata"
>  
> -PR = "${INC_PR}.1"
> +PR = "${INC_PR}.2"
>  
>  DEPENDS = "ti-xdctools ti-sysbios doxygen-native zip-native"
>  DEPENDS_append_keystone = " ti-cgt6x-native \
> @@ -82,6 +82,9 @@ RELEASE_SUFFIX = ""
>  
>  IPC_PACKAGE_DIR = "${S}/ipc-package"
>  
> +deltask do_create_srcipk
> +addtask create_srcipk after do_compile before do_install
> +
>  do_compile() {
>    oe_runmake -f ipc-bios.mak clean
>    oe_runmake -f ipc-bios.mak release
> @@ -123,10 +126,6 @@ do_compile() {
>    fi
>  }
>  
> -do_compile_append() {
> -  sourceipk_do_create_srcipk
> -}
> -
>  do_install() {
>    IPC_VERSION=`echo ${PV}${RELEASE_SUFFIX} | sed -e 's|\.|_|g'`
>    # Copy docs and other meta files
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [PATCH] ti-ipc-rtos: Cleanup scripts for srcipk generation after compile

[Nelson, Sam]

Agreed.
You can remove the compile append.

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Tuesday, August 02, 2016 11:59 AM
> To: Nelson, Sam
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH] ti-ipc-rtos: Cleanup scripts for srcipk
> generation after compile
> 
> NO, it shouldn't have been here in the first place! How did I miss it? I'm going
> to remove that compile_append() below.
> 
> 
> On Tue, Aug 02, 2016 at 11:27:47AM -0400, Sam Nelson wrote:
> > This avoid issues with double srcipk generation.
> > Resolves issues with empty srcipk package, with some latest updates in
> > meta-arago.
> >
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > ---
> >  recipes-ti/ipc/ti-ipc-rtos_git.bb | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/recipes-ti/ipc/ti-ipc-rtos_git.bb b/recipes-ti/ipc/ti-ipc-
> rtos_git.bb
> > index c9c4714..0213782 100644
> > --- a/recipes-ti/ipc/ti-ipc-rtos_git.bb
> > +++ b/recipes-ti/ipc/ti-ipc-rtos_git.bb
> > @@ -35,7 +35,7 @@ SRCREV_ipc-metadata =
> "b6dd82a450d75b9483a7cc9b619a30cf3cc25ae6"
> >  S_ipc-examples = "${WORKDIR}/git/ipc-examples"
> >  S_ipc-metadata = "${WORKDIR}/git/ipc-metadata"
> >
> > -PR = "${INC_PR}.1"
> > +PR = "${INC_PR}.2"
> >
> >  DEPENDS = "ti-xdctools ti-sysbios doxygen-native zip-native"
> >  DEPENDS_append_keystone = " ti-cgt6x-native \
> > @@ -82,6 +82,9 @@ RELEASE_SUFFIX = ""
> >
> >  IPC_PACKAGE_DIR = "${S}/ipc-package"
> >
> > +deltask do_create_srcipk
> > +addtask create_srcipk after do_compile before do_install
> > +
> >  do_compile() {
> >    oe_runmake -f ipc-bios.mak clean
> >    oe_runmake -f ipc-bios.mak release
> > @@ -123,10 +126,6 @@ do_compile() {
> >    fi
> >  }
> >
> > -do_compile_append() {
> > -  sourceipk_do_create_srcipk
> > -}
> > -
> >  do_install() {
> >    IPC_VERSION=`echo ${PV}${RELEASE_SUFFIX} | sed -e 's|\.|_|g'`
> >    # Copy docs and other meta files
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti