From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvmet-rdma: Don't use the inline buffer in order to avoid allocation for small reads
Date: Wed, 3 Aug 2016 11:49:41 +0200 [thread overview]
Message-ID: <20160803094941.GA11821@lst.de> (raw)
In-Reply-To: <20160802161526.GA14964@obsidianresearch.com>
On Tue, Aug 02, 2016@10:15:26AM -0600, Jason Gunthorpe wrote:
> On Tue, Aug 02, 2016@04:38:58PM +0300, Sagi Grimberg wrote:
> > that is currently being sent (its a rare race condition, but
> > theoretically possible). The reason is that we repost the inline data
> > buffer for receive before we post the send request. We used to have
>
> ?? The same buffer is posted at the same time for send and recv? That
> is never OK, SRQ or not.
We will never POST it for a SEND, but it would be used as the target
of RDMA READ / WRITE operations.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Jay Freyensee
<james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] nvmet-rdma: Don't use the inline buffer in order to avoid allocation for small reads
Date: Wed, 3 Aug 2016 11:49:41 +0200 [thread overview]
Message-ID: <20160803094941.GA11821@lst.de> (raw)
In-Reply-To: <20160802161526.GA14964-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Tue, Aug 02, 2016 at 10:15:26AM -0600, Jason Gunthorpe wrote:
> On Tue, Aug 02, 2016 at 04:38:58PM +0300, Sagi Grimberg wrote:
> > that is currently being sent (its a rare race condition, but
> > theoretically possible). The reason is that we repost the inline data
> > buffer for receive before we post the send request. We used to have
>
> ?? The same buffer is posted at the same time for send and recv? That
> is never OK, SRQ or not.
We will never POST it for a SEND, but it would be used as the target
of RDMA READ / WRITE operations.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-03 9:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 8:36 [PATCH] nvmet-rdma: Don't use the inline buffer in order to avoid allocation for small reads Sagi Grimberg
2016-08-01 8:36 ` Sagi Grimberg
2016-08-02 12:50 ` Christoph Hellwig
2016-08-02 12:50 ` Christoph Hellwig
2016-08-02 13:38 ` Sagi Grimberg
2016-08-02 13:38 ` Sagi Grimberg
2016-08-02 16:15 ` Jason Gunthorpe
2016-08-02 16:15 ` Jason Gunthorpe
2016-08-03 9:48 ` Sagi Grimberg
2016-08-03 9:48 ` Sagi Grimberg
2016-08-03 9:49 ` Christoph Hellwig [this message]
2016-08-03 9:49 ` Christoph Hellwig
2016-08-03 10:37 ` Sagi Grimberg
2016-08-03 10:37 ` Sagi Grimberg
2016-08-04 11:49 ` Christoph Hellwig
2016-08-04 11:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803094941.GA11821@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.