From: Matt Roper <matthew.d.roper@intel.com>
To: Lyude <cpaul@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v5 3/6] drm/i915/skl: Update plane watermarks atomically during plane updates
Date: Wed, 3 Aug 2016 14:16:45 -0700 [thread overview]
Message-ID: <20160803211645.GB871@intel.com> (raw)
In-Reply-To: <20160803211453.GA871@intel.com>
On Wed, Aug 03, 2016 at 02:14:53PM -0700, Matt Roper wrote:
...
>
> I imagine we'll eventually probably want to create a new display vfunc
> to handle platform-specific pipe-level stuff that needs to happen under
> vblank evasion (like the scalers and linetime WM we have today) to keep
> the code clean; maybe add a TODO comment to that effect?
>
> Anyway, this looks good enough for now, so
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Woops, meant to add this reply to your v6 version of the patch
obviously...
Matt
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Matt Roper <matthew.d.roper@intel.com>
To: Lyude <cpaul@redhat.com>
Cc: intel-gfx@lists.freedesktop.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
stable@vger.kernel.org, "Daniel Vetter" <daniel.vetter@intel.com>,
"Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/6] drm/i915/skl: Update plane watermarks atomically during plane updates
Date: Wed, 3 Aug 2016 14:16:45 -0700 [thread overview]
Message-ID: <20160803211645.GB871@intel.com> (raw)
In-Reply-To: <20160803211453.GA871@intel.com>
On Wed, Aug 03, 2016 at 02:14:53PM -0700, Matt Roper wrote:
...
>
> I imagine we'll eventually probably want to create a new display vfunc
> to handle platform-specific pipe-level stuff that needs to happen under
> vblank evasion (like the scalers and linetime WM we have today) to keep
> the code clean; maybe add a TODO comment to that effect?
>
> Anyway, this looks good enough for now, so
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Woops, meant to add this reply to your v6 version of the patch
obviously...
Matt
next prev parent reply other threads:[~2016-08-03 21:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 18:52 [PATCH v5 0/6] Finally fix watermarks Lyude
2016-08-02 18:52 ` Lyude
2016-08-02 18:52 ` [PATCH v5 1/6] drm/i915/skl: Add support for the SAGV, fix underrun hangs Lyude
2016-08-02 18:52 ` Lyude
2016-08-02 19:50 ` [v5,1/6] " Hans de Goede
2016-08-02 19:50 ` Hans de Goede
2016-08-02 21:05 ` [PATCH v5 1/6] " Matt Roper
2016-08-02 21:05 ` Matt Roper
2016-08-02 21:05 ` Matt Roper
2016-08-02 18:52 ` [PATCH v5 2/6] drm/i915/gen9: Only copy WM results for changed pipes to skl_hw Lyude
2016-08-02 18:52 ` Lyude
2016-08-02 18:52 ` [PATCH v5 3/6] drm/i915/skl: Update plane watermarks atomically during plane updates Lyude
2016-08-02 18:52 ` Lyude
2016-08-02 21:20 ` Matt Roper
2016-08-02 21:20 ` Matt Roper
2016-08-02 21:20 ` Matt Roper
2016-08-03 21:14 ` Matt Roper
2016-08-03 21:14 ` Matt Roper
2016-08-03 21:14 ` Matt Roper
2016-08-03 21:16 ` Matt Roper [this message]
2016-08-03 21:16 ` Matt Roper
2016-08-02 18:52 ` [PATCH v5 4/6] drm/i915/skl: Ensure pipes with changed wms get added to the state Lyude
2016-08-02 18:52 ` Lyude
2016-08-02 21:26 ` Matt Roper
2016-08-02 21:26 ` Matt Roper
2016-08-02 21:26 ` Matt Roper
2016-08-02 18:52 ` [PATCH v5 5/6] drm/i915: Move CRTC updating in atomic_commit into it's own hook Lyude
2016-08-02 18:52 ` Lyude
2016-08-02 22:11 ` Matt Roper
2016-08-02 22:11 ` Matt Roper
2016-08-02 18:52 ` [PATCH v5 6/6] drm/i915/skl: Update DDB values atomically with wms/plane attrs Lyude
2016-08-02 18:52 ` Lyude
2016-08-03 0:11 ` Matt Roper
2016-08-03 0:11 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803211645.GB871@intel.com \
--to=matthew.d.roper@intel.com \
--cc=airlied@linux.ie \
--cc=cpaul@redhat.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.