* [patch] fcoe: use kfree_skb() to free an skb
@ 2016-08-04 5:27 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-08-04 5:27 UTC (permalink / raw)
To: Johannes Thumshirn, Hannes Reinecke
Cc: James E.J. Bottomley, Martin K. Petersen, fcoe-devel, linux-scsi,
kernel-janitors
This should be doing kfree_skb() instead of kfree().
Fixes: 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index a569c65..dcf3653 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -2923,7 +2923,7 @@ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
mutex_unlock(&fip->ctlr_mutex);
drop:
- kfree(skb);
+ kfree_skb(skb);
return rc;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] fcoe: use kfree_skb() to free an skb
@ 2016-08-04 5:27 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-08-04 5:27 UTC (permalink / raw)
To: Johannes Thumshirn, Hannes Reinecke
Cc: James E.J. Bottomley, Martin K. Petersen, fcoe-devel, linux-scsi,
kernel-janitors
This should be doing kfree_skb() instead of kfree().
Fixes: 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index a569c65..dcf3653 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -2923,7 +2923,7 @@ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
mutex_unlock(&fip->ctlr_mutex);
drop:
- kfree(skb);
+ kfree_skb(skb);
return rc;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] fcoe: use kfree_skb() to free an skb
2016-08-04 5:27 ` Dan Carpenter
@ 2016-08-04 8:12 ` Johannes Thumshirn
-1 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2016-08-04 8:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, linux-scsi-u79uwXL29TY76Z2rM5mHXA,
Martin K. Petersen, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
fcoe-devel-s9riP+hp16TNLxjTenLetw, Johannes Thumshirn
On Thu, Aug 04, 2016 at 08:27:56AM +0300, Dan Carpenter wrote:
> This should be doing kfree_skb() instead of kfree().
>
> Fixes: 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
> index a569c65..dcf3653 100644
> --- a/drivers/scsi/fcoe/fcoe_ctlr.c
> +++ b/drivers/scsi/fcoe/fcoe_ctlr.c
> @@ -2923,7 +2923,7 @@ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
> mutex_unlock(&fip->ctlr_mutex);
>
> drop:
> - kfree(skb);
> + kfree_skb(skb);
> return rc;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan,
This was already sent by Wei Yongjun and is
https://patchwork.kernel.org/patch/9245273/. Should be queued in Martin's tree
already.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] fcoe: use kfree_skb() to free an skb
@ 2016-08-04 8:12 ` Johannes Thumshirn
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2016-08-04 8:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, linux-scsi-u79uwXL29TY76Z2rM5mHXA,
Martin K. Petersen, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
fcoe-devel-s9riP+hp16TNLxjTenLetw, Johannes Thumshirn
On Thu, Aug 04, 2016 at 08:27:56AM +0300, Dan Carpenter wrote:
> This should be doing kfree_skb() instead of kfree().
>
> Fixes: 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
> index a569c65..dcf3653 100644
> --- a/drivers/scsi/fcoe/fcoe_ctlr.c
> +++ b/drivers/scsi/fcoe/fcoe_ctlr.c
> @@ -2923,7 +2923,7 @@ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
> mutex_unlock(&fip->ctlr_mutex);
>
> drop:
> - kfree(skb);
> + kfree_skb(skb);
> return rc;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan,
This was already sent by Wei Yongjun and is
https://patchwork.kernel.org/patch/9245273/. Should be queued in Martin's tree
already.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn-l3A5Bk7waGM@public.gmane.org +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-04 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 5:27 [patch] fcoe: use kfree_skb() to free an skb Dan Carpenter
2016-08-04 5:27 ` Dan Carpenter
2016-08-04 8:12 ` Johannes Thumshirn
2016-08-04 8:12 ` Johannes Thumshirn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.