* [patch] tty: amiserial.c: remove a double irq restore
@ 2016-08-04 5:34 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-08-04 5:34 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, kernel-janitors
We already called "local_irq_restore(flags);" so this isn't needed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 208f573..2f33cf1 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
/* set a pending Tx Interrupt, transmitter should restart now */
custom.intreq = IF_SETCLR | IF_TBE;
mb();
- local_irq_restore(flags);
}
return ret;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] tty: amiserial.c: remove a double irq restore
@ 2016-08-04 5:34 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-08-04 5:34 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, kernel-janitors
We already called "local_irq_restore(flags);" so this isn't needed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 208f573..2f33cf1 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
/* set a pending Tx Interrupt, transmitter should restart now */
custom.intreq = IF_SETCLR | IF_TBE;
mb();
- local_irq_restore(flags);
}
return ret;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] tty: amiserial.c: remove a double irq restore
2016-08-04 5:34 ` Dan Carpenter
@ 2016-08-04 6:24 ` Jiri Slaby
-1 siblings, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2016-08-04 6:24 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel
On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
If I add a bit more context:
local_irq_disable();
custom.intena = IF_SETCLR | IF_TBE;
mb();
> /* set a pending Tx Interrupt, transmitter should restart now */
> custom.intreq = IF_SETCLR | IF_TBE;
> mb();
> - local_irq_restore(flags);
Really?
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] tty: amiserial.c: remove a double irq restore
@ 2016-08-04 6:24 ` Jiri Slaby
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2016-08-04 6:24 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel
On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
If I add a bit more context:
local_irq_disable();
custom.intena = IF_SETCLR | IF_TBE;
mb();
> /* set a pending Tx Interrupt, transmitter should restart now */
> custom.intreq = IF_SETCLR | IF_TBE;
> mb();
> - local_irq_restore(flags);
Really?
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] tty: amiserial.c: remove a double irq restore
2016-08-04 6:24 ` Jiri Slaby
@ 2016-08-04 10:11 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-08-04 10:11 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Greg Kroah-Hartman, kernel-janitors, linux-kernel
Oh... Wow. I'm really sorry about that. Thanks for catching the
mistake.
It should as well have been caught by static analysis but it wasn't.
I will work on this so it doesn't happen again. And I will try to be
more careful as well.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-04 10:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 5:34 [patch] tty: amiserial.c: remove a double irq restore Dan Carpenter
2016-08-04 5:34 ` Dan Carpenter
2016-08-04 6:24 ` Jiri Slaby
2016-08-04 6:24 ` Jiri Slaby
2016-08-04 10:11 ` Dan Carpenter
2016-08-04 10:11 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.