All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: "Failed to create /dev/root: -14" after commit e6978e4bf1 ("ARM: save and reset the address limit when entering an exception")
Date: Thu, 4 Aug 2016 11:07:48 +0100	[thread overview]
Message-ID: <20160804100748.GP1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <57A20896.30300@roeck-us.net>

On Wed, Aug 03, 2016 at 08:07:02AM -0700, Guenter Roeck wrote:
> On 08/03/2016 01:38 AM, Russell King - ARM Linux wrote:
> >On Tue, Aug 02, 2016 at 07:51:45PM -0700, Guenter Roeck wrote:
> >>Hi,
> >>
> >>I see the following crash when running a qemu arm 'kzm' runtime test with
> >>the current mainline.
> >>...
> >>Failed to create /dev/root: -14
> >>
> >>[ followed by panic ]
> >>
> >>A complete log file is at [1].
> >
> >I think it's because of those undefined instructions you're hitting
> >with the hw-breakpoint code... can you try the patch below please?
> >
> >  arch/arm/kernel/entry-armv.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
> >index bc5f50799d75..9f157e7c51e7 100644
> >--- a/arch/arm/kernel/entry-armv.S
> >+++ b/arch/arm/kernel/entry-armv.S
> >@@ -295,6 +295,7 @@ __und_svc_fault:
> >  	bl	__und_fault
> >
> >  __und_svc_finish:
> >+	get_thread_info tsk
> >  	ldr	r5, [sp, #S_PSR]		@ Get SVC cpsr
> >  	svc_exit r5				@ return from exception
> >   UNWIND(.fnend		)
> >
> 
> Yes, that fixes the problem.
> 
> Assuming you'll create a patch:
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
> Does that need to be addressed in qemu, or is it a Linux bug ?

It's a Linux bug provoked by qemu not implementing the hardware
breakpoints.  Well worth fixing in Linux.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Will Deacon <will.deacon@arm.com>
Subject: Re: "Failed to create /dev/root: -14" after commit e6978e4bf1 ("ARM: save and reset the address limit when entering an exception")
Date: Thu, 4 Aug 2016 11:07:48 +0100	[thread overview]
Message-ID: <20160804100748.GP1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <57A20896.30300@roeck-us.net>

On Wed, Aug 03, 2016 at 08:07:02AM -0700, Guenter Roeck wrote:
> On 08/03/2016 01:38 AM, Russell King - ARM Linux wrote:
> >On Tue, Aug 02, 2016 at 07:51:45PM -0700, Guenter Roeck wrote:
> >>Hi,
> >>
> >>I see the following crash when running a qemu arm 'kzm' runtime test with
> >>the current mainline.
> >>...
> >>Failed to create /dev/root: -14
> >>
> >>[ followed by panic ]
> >>
> >>A complete log file is at [1].
> >
> >I think it's because of those undefined instructions you're hitting
> >with the hw-breakpoint code... can you try the patch below please?
> >
> >  arch/arm/kernel/entry-armv.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
> >index bc5f50799d75..9f157e7c51e7 100644
> >--- a/arch/arm/kernel/entry-armv.S
> >+++ b/arch/arm/kernel/entry-armv.S
> >@@ -295,6 +295,7 @@ __und_svc_fault:
> >  	bl	__und_fault
> >
> >  __und_svc_finish:
> >+	get_thread_info tsk
> >  	ldr	r5, [sp, #S_PSR]		@ Get SVC cpsr
> >  	svc_exit r5				@ return from exception
> >   UNWIND(.fnend		)
> >
> 
> Yes, that fixes the problem.
> 
> Assuming you'll create a patch:
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
> Does that need to be addressed in qemu, or is it a Linux bug ?

It's a Linux bug provoked by qemu not implementing the hardware
breakpoints.  Well worth fixing in Linux.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2016-08-04 10:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  2:51 "Failed to create /dev/root: -14" after commit e6978e4bf1 ("ARM: save and reset the address limit when entering an exception") Guenter Roeck
2016-08-03  2:51 ` Guenter Roeck
2016-08-03  8:38 ` Russell King - ARM Linux
2016-08-03  8:38   ` Russell King - ARM Linux
2016-08-03 15:07   ` Guenter Roeck
2016-08-03 15:07     ` Guenter Roeck
2016-08-04 10:07     ` Russell King - ARM Linux [this message]
2016-08-04 10:07       ` Russell King - ARM Linux
2016-08-09 15:06       ` Gregory CLEMENT
2016-08-09 15:06         ` Gregory CLEMENT
2016-08-09 16:12         ` Guenter Roeck
2016-08-09 16:12           ` Guenter Roeck
2016-08-10 23:34         ` Kevin Hilman
2016-08-10 23:34           ` Kevin Hilman
2016-08-10 23:43           ` Russell King - ARM Linux
2016-08-10 23:43             ` Russell King - ARM Linux
2016-08-11  0:46             ` Kevin Hilman
2016-08-11  0:46               ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804100748.GP1041@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.