[PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates

[PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates

[Matt Roper]

A copy/paste error resulted in us using src_x for both the x and y
panning coordinates; make sure we use src_y instead for the appropriate
parameter.

Fixes: 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 7d7a53c..ed91688 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
 		    igt_output_name(output),
 		    kmstest_pipe_name(pipe->pipe),
 		    fb_id,
-		    primary->src_x, primary->src_x,
+		    primary->src_x, primary->src_y,
 		    mode->hdisplay, mode->vdisplay);
 
 		ret = drmModeSetCrtc(display->drm_fd,
 				     crtc_id,
 				     fb_id,
-				     primary->src_x, primary->src_x,
+				     primary->src_x, primary->src_y,
 				     &output->id,
 				     1,
 				     mode);
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates

[Bob Paauwe]

On Wed, 3 Aug 2016 09:15:41 -0700
Matt Roper <matthew.d.roper@intel.com> wrote:

> A copy/paste error resulted in us using src_x for both the x and y
> panning coordinates; make sure we use src_y instead for the appropriate
> parameter.
> 
> Fixes: 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Bob Paauwe <bob.j.paauwe@intel.com>

> ---
>  lib/igt_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 7d7a53c..ed91688 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
>  		    igt_output_name(output),
>  		    kmstest_pipe_name(pipe->pipe),
>  		    fb_id,
> -		    primary->src_x, primary->src_x,
> +		    primary->src_x, primary->src_y,
>  		    mode->hdisplay, mode->vdisplay);
>  
>  		ret = drmModeSetCrtc(display->drm_fd,
>  				     crtc_id,
>  				     fb_id,
> -				     primary->src_x, primary->src_x,
> +				     primary->src_x, primary->src_y,
>  				     &output->id,
>  				     1,
>  				     mode);



-- 
--
Bob Paauwe                  
Bob.J.Paauwe@intel.com
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates

[Matt Roper]

On Wed, Aug 03, 2016 at 10:35:15AM -0700, Bob Paauwe wrote:
> On Wed, 3 Aug 2016 09:15:41 -0700
> Matt Roper <matthew.d.roper@intel.com> wrote:
> 
> > A copy/paste error resulted in us using src_x for both the x and y
> > panning coordinates; make sure we use src_y instead for the appropriate
> > parameter.
> > 
> > Fixes: 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> 
> Reviewed-by: Bob Paauwe <bob.j.paauwe@intel.com>

Merged; thanks for the review.


Matt

> 
> > ---
> >  lib/igt_kms.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > index 7d7a53c..ed91688 100644
> > --- a/lib/igt_kms.c
> > +++ b/lib/igt_kms.c
> > @@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
> >  		    igt_output_name(output),
> >  		    kmstest_pipe_name(pipe->pipe),
> >  		    fb_id,
> > -		    primary->src_x, primary->src_x,
> > +		    primary->src_x, primary->src_y,
> >  		    mode->hdisplay, mode->vdisplay);
> >  
> >  		ret = drmModeSetCrtc(display->drm_fd,
> >  				     crtc_id,
> >  				     fb_id,
> > -				     primary->src_x, primary->src_x,
> > +				     primary->src_x, primary->src_y,
> >  				     &output->id,
> >  				     1,
> >  				     mode);
> 
> 
> 
> -- 
> --
> Bob Paauwe                  
> Bob.J.Paauwe@intel.com
> IOTG / PED Software Organization
> Intel Corp.  Folsom, CA
> (916) 356-6193    
> 

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx