* [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined
@ 2016-07-31 8:41 Bernd Kuhls
2016-08-04 6:53 ` Khem Raj
2016-08-04 20:51 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-07-31 8:41 UTC (permalink / raw)
To: buildroot
The buildroot toolchains do not contain lddk.h
Fixes
http://autobuild.buildroot.net/results/ae7/ae7ba1d5979ebe39aace628fa8ff2c8f08a70a98/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
...mem-vpx_mem.h-Fix-compilation-with-uClibc.patch | 27 ++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
diff --git a/package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch b/package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
new file mode 100644
index 0000000..76b6fcf
--- /dev/null
+++ b/package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
@@ -0,0 +1,27 @@
+From 90845a3a263e0f37b9c756c0b01377b9d1a225c9 Mon Sep 17 00:00:00 2001
+From: Bernd Kuhls <bernd.kuhls@t-online.de>
+Date: Sun, 31 Jul 2016 10:37:05 +0200
+Subject: [PATCH 1/1] vpx_mem/vpx_mem.h: Fix compilation with uClibc
+
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+---
+ vpx_mem/vpx_mem.h | 3 ---
+ 1 file changed, 3 deletions(-)
+
+diff --git a/vpx_mem/vpx_mem.h b/vpx_mem/vpx_mem.h
+index c14f288..82df745 100644
+--- a/vpx_mem/vpx_mem.h
++++ b/vpx_mem/vpx_mem.h
+@@ -12,9 +12,6 @@
+ #define VPX_MEM_VPX_MEM_H_
+
+ #include "vpx_config.h"
+-#if defined(__uClinux__)
+-# include <lddk.h>
+-#endif
+
+ #include <stdlib.h>
+ #include <stddef.h>
+--
+2.8.1
+
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined
2016-07-31 8:41 [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined Bernd Kuhls
@ 2016-08-04 6:53 ` Khem Raj
2016-08-04 20:53 ` Thomas Petazzoni
2016-08-04 20:51 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-08-04 6:53 UTC (permalink / raw)
To: buildroot
> On Jul 31, 2016, at 1:41 AM, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> The buildroot toolchains do not contain lddk.h
>
> Fixes
> http://autobuild.buildroot.net/results/ae7/ae7ba1d5979ebe39aace628fa8ff2c8f08a70a98/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> ...mem-vpx_mem.h-Fix-compilation-with-uClibc.patch | 27 ++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
>
> diff --git a/package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch b/package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
> new file mode 100644
> index 0000000..76b6fcf
> --- /dev/null
> +++ b/package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
> @@ -0,0 +1,27 @@
> +From 90845a3a263e0f37b9c756c0b01377b9d1a225c9 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd.kuhls@t-online.de>
> +Date: Sun, 31 Jul 2016 10:37:05 +0200
> +Subject: [PATCH 1/1] vpx_mem/vpx_mem.h: Fix compilation with uClibc
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +---
> + vpx_mem/vpx_mem.h | 3 ---
> + 1 file changed, 3 deletions(-)
> +
> +diff --git a/vpx_mem/vpx_mem.h b/vpx_mem/vpx_mem.h
> +index c14f288..82df745 100644
> +--- a/vpx_mem/vpx_mem.h
> ++++ b/vpx_mem/vpx_mem.h
> +@@ -12,9 +12,6 @@
> + #define VPX_MEM_VPX_MEM_H_
> +
> + #include "vpx_config.h"
> +-#if defined(__uClinux__)
> +-# include <lddk.h>
> +-#endif
better to use
if defined(__uClinux__) && defined(CHIP_DM642)
may be if someone is using BR for ti_c6x
> +
> + #include <stdlib.h>
> + #include <stddef.h>
> +--
> +2.8.1
> +
> --
> 2.8.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160803/56168dc2/attachment.asc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined
2016-07-31 8:41 [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined Bernd Kuhls
2016-08-04 6:53 ` Khem Raj
@ 2016-08-04 20:51 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-08-04 20:51 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 31 Jul 2016 10:41:44 +0200, Bernd Kuhls wrote:
> The buildroot toolchains do not contain lddk.h
>
> Fixes
> http://autobuild.buildroot.net/results/ae7/ae7ba1d5979ebe39aace628fa8ff2c8f08a70a98/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> ...mem-vpx_mem.h-Fix-compilation-with-uClibc.patch | 27 ++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 package/libvpx/0001-vpx_mem-vpx_mem.h-Fix-compilation-with-uClibc.patch
Applied to master after tweaking the commit log and the patch
description. Please send the patch upstream after taking Khem's comment
into account.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined
2016-08-04 6:53 ` Khem Raj
@ 2016-08-04 20:53 ` Thomas Petazzoni
2016-08-05 4:05 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-08-04 20:53 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 3 Aug 2016 23:53:57 -0700, Khem Raj wrote:
> better to use
>
> if defined(__uClinux__) && defined(CHIP_DM642)
Possibly, but where would lddk.h come from? I don't see it in the
uClibc-ng sources, and I don't see it in the kernel either. So I don't
quite see this header could end up in a toolchain.
> may be if someone is using BR for ti_c6x
A platform for which we don't have support today.
I'm all for making proper upstreamable patches, but in this specific
case, I'm not even sure where lddk.h is supposed to come from.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined
2016-08-04 20:53 ` Thomas Petazzoni
@ 2016-08-05 4:05 ` Khem Raj
2016-08-05 7:32 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-08-05 4:05 UTC (permalink / raw)
To: buildroot
On 8/4/16 1:53 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 3 Aug 2016 23:53:57 -0700, Khem Raj wrote:
>
>> better to use
>>
>> if defined(__uClinux__) && defined(CHIP_DM642)
>
> Possibly, but where would lddk.h come from? I don't see it in the
> uClibc-ng sources, and I don't see it in the kernel either. So I don't
> quite see this header could end up in a toolchain.
>
>> may be if someone is using BR for ti_c6x
>
> A platform for which we don't have support today.
>
> I'm all for making proper upstreamable patches, but in this specific
> case, I'm not even sure where lddk.h is supposed to come from.
>
For life of me I can not find out, so most probably, its some SOC devkit
so its fine to ignore this.
> Best regards,
>
> Thomas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined
2016-08-05 4:05 ` Khem Raj
@ 2016-08-05 7:32 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-08-05 7:32 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 4 Aug 2016 21:05:10 -0700, Khem Raj wrote:
> For life of me I can not find out, so most probably, its some SOC devkit
> so its fine to ignore this.
I also Google'd for this header, and can't seem to find it anywhere, so
it really seems like some very BSP-specific thingy that was added, and
there's no reason to keep carrying I believe.
I just checked, this include has been here in the Git repository since
the initial code base import, so there's no way to know more precisely
why it was added.
Bernd, could you submit the patch removing this header file to the
upstream project?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-05 7:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-31 8:41 [Buildroot] [PATCH 1/1] package/libvpx: Fix compilation when __uClinux__ is defined Bernd Kuhls
2016-08-04 6:53 ` Khem Raj
2016-08-04 20:53 ` Thomas Petazzoni
2016-08-05 4:05 ` Khem Raj
2016-08-05 7:32 ` Thomas Petazzoni
2016-08-04 20:51 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.