From: keith.busch@intel.com (Keith Busch)
Subject: NVME regression in all kernels after 4.4.x for NVME in M2 slot for laptop?
Date: Fri, 5 Aug 2016 16:50:53 -0400 [thread overview]
Message-ID: <20160805205052.GA12688@localhost.localdomain> (raw)
In-Reply-To: <20160805190323.GA12853@merlins.org>
On Fri, Aug 05, 2016@12:03:23PM -0700, Marc MERLIN wrote:
> Would this patch make sense as being the reason why I can't S3 sleep
> anymore and would you have a test patch against 4.5, 4.6, or 4.7 I can
> try to see if it fixes the problem?
Hi Marc,
It might be blk-mq's hot cpu notifier is invoked during suspend and
waiting for nvme's queues to freeze, which may not happen if a request
is waiting on a stopped queue. The patch you biseceted doesn't
necessarilly fix that, but the window for when a request could get queued
like that was much shorter.
Assuming that is the problem, S3 suspends PCI hardware before IO
tasks. I'll see if I can reproduce on one of my machines and look into
a fix.
Thanks,
Keith
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Marc MERLIN <marc@merlins.org>
Cc: axboe@fb.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: NVME regression in all kernels after 4.4.x for NVME in M2 slot for laptop?
Date: Fri, 5 Aug 2016 16:50:53 -0400 [thread overview]
Message-ID: <20160805205052.GA12688@localhost.localdomain> (raw)
In-Reply-To: <20160805190323.GA12853@merlins.org>
On Fri, Aug 05, 2016 at 12:03:23PM -0700, Marc MERLIN wrote:
> Would this patch make sense as being the reason why I can't S3 sleep
> anymore and would you have a test patch against 4.5, 4.6, or 4.7 I can
> try to see if it fixes the problem?
Hi Marc,
It might be blk-mq's hot cpu notifier is invoked during suspend and
waiting for nvme's queues to freeze, which may not happen if a request
is waiting on a stopped queue. The patch you biseceted doesn't
necessarilly fix that, but the window for when a request could get queued
like that was much shorter.
Assuming that is the problem, S3 suspends PCI hardware before IO
tasks. I'll see if I can reproduce on one of my machines and look into
a fix.
Thanks,
Keith
next prev parent reply other threads:[~2016-08-05 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 19:03 NVME regression in all kernels after 4.4.x for NVME in M2 slot for laptop? Marc MERLIN
2016-08-05 19:03 ` Marc MERLIN
2016-08-05 20:50 ` Keith Busch [this message]
2016-08-05 20:50 ` Keith Busch
[not found] ` <20160805205449.GC12853@merlins.org>
[not found] ` <20160815193733.GC18083@localhost.localdomain>
[not found] ` <20160914024027.GV24451@merlins.org>
[not found] ` <20160914144615.GA16556@localhost.localdomain>
[not found] ` <20160929060204.GA17637@merlins.org>
2016-10-14 21:15 ` Marc MERLIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805205052.GA12688@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.