* [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures
@ 2016-08-06 10:07 Akira Yokosawa
2016-08-07 18:18 ` Paul E. McKenney
0 siblings, 1 reply; 6+ messages in thread
From: Akira Yokosawa @ 2016-08-06 10:07 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: perfbook, Akira Yokosawa
Hi Paul,
This is somewhat related to the "using hyphens for minus signs" issue.
In Figures 6.8 and 6.9, entry names such as "L-2" are used.
The "-" here means minus, but it is *not* obvious at first glance if
it means "L minus 2" or not.
If we make "-2" a subscript, it would be much easier to see that
it means "L whose sequence number is 'minus 2'".
So, I tweaked the xfig sources of the figures to make those numbers
in entries look like subscripts. I also altered the numbers in entry names
mentioned in the corresponding text as subscripts (using math mode).
I'm sending this as a pull request as the resulting patch became fairly
large due to eps files.
I hope you like there tweaks.
Additional patch is a fix of entry numbers of Figure 6.9, which is
actually 16 if my understanding of the figure is correct.
Thanks, Akira
---------
The following changes since commit ec15e80376f04f5b2be8779aedfda3ba184a4e37:
Fix URL for MathieuDesnoyers2009LFCollabSummit (2016-08-05 13:12:07 -0700)
are available in the git repository at:
https://github.com/akiyks/perfbook.git lockdeqhash-use-subscript
for you to fetch changes up to 7893124def444db34fbb6bc2b4e9b2f20675c2eb:
SMPdesign: Fix number of elements regarding Figure 6.9 (2016-08-06 18:14:07 +0900)
----------------------------------------------------------------
Akira Yokosawa (2):
SMPdesign: Use subscript in lockdeqhash figures
SMPdesign: Fix number of elements regarding Figure 6.9
SMPdesign/lockdeqhash1R.eps | 330 +++++++++++++++++++++++++++++++++++-------
SMPdesign/lockdeqhash1R.fig | 39 +++--
SMPdesign/lockdeqhashlots.eps | 323 +++++++++++++++++++++++++++++++++++------
SMPdesign/lockdeqhashlots.fig | 48 ++++--
SMPdesign/partexercises.tex | 14 +-
5 files changed, 622 insertions(+), 132 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures 2016-08-06 10:07 [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures Akira Yokosawa @ 2016-08-07 18:18 ` Paul E. McKenney 2016-08-07 22:08 ` Akira Yokosawa 0 siblings, 1 reply; 6+ messages in thread From: Paul E. McKenney @ 2016-08-07 18:18 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Sat, Aug 06, 2016 at 07:07:29PM +0900, Akira Yokosawa wrote: > Hi Paul, > > This is somewhat related to the "using hyphens for minus signs" issue. > In Figures 6.8 and 6.9, entry names such as "L-2" are used. > The "-" here means minus, but it is *not* obvious at first glance if > it means "L minus 2" or not. > > If we make "-2" a subscript, it would be much easier to see that > it means "L whose sequence number is 'minus 2'". > So, I tweaked the xfig sources of the figures to make those numbers > in entries look like subscripts. I also altered the numbers in entry names > mentioned in the corresponding text as subscripts (using math mode). > > I'm sending this as a pull request as the resulting patch became fairly > large due to eps files. > > I hope you like there tweaks. > > Additional patch is a fix of entry numbers of Figure 6.9, which is > actually 16 if my understanding of the figure is correct. I pulled both, thank you. Any thoughts on converting .fig files to .svg? My approach has been to import .fig files into inkscape as I need to modify them. The results are OK, but not perfect (for example, arrows in .fig become two objects in .svg, the line and the arrowhead). Thanx, Paul > Thanks, Akira > > --------- > The following changes since commit ec15e80376f04f5b2be8779aedfda3ba184a4e37: > > Fix URL for MathieuDesnoyers2009LFCollabSummit (2016-08-05 13:12:07 -0700) > > are available in the git repository at: > > https://github.com/akiyks/perfbook.git lockdeqhash-use-subscript > > for you to fetch changes up to 7893124def444db34fbb6bc2b4e9b2f20675c2eb: > > SMPdesign: Fix number of elements regarding Figure 6.9 (2016-08-06 18:14:07 +0900) > > ---------------------------------------------------------------- > Akira Yokosawa (2): > SMPdesign: Use subscript in lockdeqhash figures > SMPdesign: Fix number of elements regarding Figure 6.9 > > SMPdesign/lockdeqhash1R.eps | 330 +++++++++++++++++++++++++++++++++++------- > SMPdesign/lockdeqhash1R.fig | 39 +++-- > SMPdesign/lockdeqhashlots.eps | 323 +++++++++++++++++++++++++++++++++++------ > SMPdesign/lockdeqhashlots.fig | 48 ++++-- > SMPdesign/partexercises.tex | 14 +- > 5 files changed, 622 insertions(+), 132 deletions(-) > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures 2016-08-07 18:18 ` Paul E. McKenney @ 2016-08-07 22:08 ` Akira Yokosawa 2016-08-08 0:15 ` Paul E. McKenney 0 siblings, 1 reply; 6+ messages in thread From: Akira Yokosawa @ 2016-08-07 22:08 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa On 2016/08/07 11:18:39 -0700, Paul E. McKenney wrote: > On Sat, Aug 06, 2016 at 07:07:29PM +0900, Akira Yokosawa wrote: >> Hi Paul, >> >> This is somewhat related to the "using hyphens for minus signs" issue. >> In Figures 6.8 and 6.9, entry names such as "L-2" are used. >> The "-" here means minus, but it is *not* obvious at first glance if >> it means "L minus 2" or not. >> >> If we make "-2" a subscript, it would be much easier to see that >> it means "L whose sequence number is 'minus 2'". >> So, I tweaked the xfig sources of the figures to make those numbers >> in entries look like subscripts. I also altered the numbers in entry names >> mentioned in the corresponding text as subscripts (using math mode). >> >> I'm sending this as a pull request as the resulting patch became fairly >> large due to eps files. >> >> I hope you like there tweaks. >> >> Additional patch is a fix of entry numbers of Figure 6.9, which is >> actually 16 if my understanding of the figure is correct. > > I pulled both, thank you. > > Any thoughts on converting .fig files to .svg? My approach has been to > import .fig files into inkscape as I need to modify them. The results > are OK, but not perfect (for example, arrows in .fig become two objects > in .svg, the line and the arrowhead). So, I tried this. But by importing into inkscape, all the texts get the same font size... Unfortunately, font size specifier in .fig seems to be ignored. Or I might be missing something. BTW, now that we can use -jN option for building .pdf files, wouldn't it be a good idea to get rid of .eps files in the repository whose sources are .fig files by adding a ".fig -> .eps" rule in Makefile? Then the patch would have been much smaller. Let me know what you think. Thanks, Akira > > Thanx, Paul > >> Thanks, Akira >> >> --------- >> The following changes since commit ec15e80376f04f5b2be8779aedfda3ba184a4e37: >> >> Fix URL for MathieuDesnoyers2009LFCollabSummit (2016-08-05 13:12:07 -0700) >> >> are available in the git repository at: >> >> https://github.com/akiyks/perfbook.git lockdeqhash-use-subscript >> >> for you to fetch changes up to 7893124def444db34fbb6bc2b4e9b2f20675c2eb: >> >> SMPdesign: Fix number of elements regarding Figure 6.9 (2016-08-06 18:14:07 +0900) >> >> ---------------------------------------------------------------- >> Akira Yokosawa (2): >> SMPdesign: Use subscript in lockdeqhash figures >> SMPdesign: Fix number of elements regarding Figure 6.9 >> >> SMPdesign/lockdeqhash1R.eps | 330 +++++++++++++++++++++++++++++++++++------- >> SMPdesign/lockdeqhash1R.fig | 39 +++-- >> SMPdesign/lockdeqhashlots.eps | 323 +++++++++++++++++++++++++++++++++++------ >> SMPdesign/lockdeqhashlots.fig | 48 ++++-- >> SMPdesign/partexercises.tex | 14 +- >> 5 files changed, 622 insertions(+), 132 deletions(-) >> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures 2016-08-07 22:08 ` Akira Yokosawa @ 2016-08-08 0:15 ` Paul E. McKenney 2016-08-08 15:21 ` Akira Yokosawa 0 siblings, 1 reply; 6+ messages in thread From: Paul E. McKenney @ 2016-08-08 0:15 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Mon, Aug 08, 2016 at 07:08:17AM +0900, Akira Yokosawa wrote: > On 2016/08/07 11:18:39 -0700, Paul E. McKenney wrote: > > On Sat, Aug 06, 2016 at 07:07:29PM +0900, Akira Yokosawa wrote: > >> Hi Paul, > >> > >> This is somewhat related to the "using hyphens for minus signs" issue. > >> In Figures 6.8 and 6.9, entry names such as "L-2" are used. > >> The "-" here means minus, but it is *not* obvious at first glance if > >> it means "L minus 2" or not. > >> > >> If we make "-2" a subscript, it would be much easier to see that > >> it means "L whose sequence number is 'minus 2'". > >> So, I tweaked the xfig sources of the figures to make those numbers > >> in entries look like subscripts. I also altered the numbers in entry names > >> mentioned in the corresponding text as subscripts (using math mode). > >> > >> I'm sending this as a pull request as the resulting patch became fairly > >> large due to eps files. > >> > >> I hope you like there tweaks. > >> > >> Additional patch is a fix of entry numbers of Figure 6.9, which is > >> actually 16 if my understanding of the figure is correct. > > > > I pulled both, thank you. > > > > Any thoughts on converting .fig files to .svg? My approach has been to > > import .fig files into inkscape as I need to modify them. The results > > are OK, but not perfect (for example, arrows in .fig become two objects > > in .svg, the line and the arrowhead). > > So, I tried this. > But by importing into inkscape, all the texts get the same font size... > Unfortunately, font size specifier in .fig seems to be ignored. > Or I might be missing something. Hmmm... I guess I have been getting lucky, working only with .fig files with a single font size. > BTW, now that we can use -jN option for building .pdf files, wouldn't it > be a good idea to get rid of .eps files in the repository whose sources > are .fig files by adding a ".fig -> .eps" rule in Makefile? > Then the patch would have been much smaller. > > Let me know what you think. Making that initial clone and build go faster makes a lot of sense to me! Thanx, Paul > Thanks, Akira > > > > Thanx, Paul > > > >> Thanks, Akira > >> > >> --------- > >> The following changes since commit ec15e80376f04f5b2be8779aedfda3ba184a4e37: > >> > >> Fix URL for MathieuDesnoyers2009LFCollabSummit (2016-08-05 13:12:07 -0700) > >> > >> are available in the git repository at: > >> > >> https://github.com/akiyks/perfbook.git lockdeqhash-use-subscript > >> > >> for you to fetch changes up to 7893124def444db34fbb6bc2b4e9b2f20675c2eb: > >> > >> SMPdesign: Fix number of elements regarding Figure 6.9 (2016-08-06 18:14:07 +0900) > >> > >> ---------------------------------------------------------------- > >> Akira Yokosawa (2): > >> SMPdesign: Use subscript in lockdeqhash figures > >> SMPdesign: Fix number of elements regarding Figure 6.9 > >> > >> SMPdesign/lockdeqhash1R.eps | 330 +++++++++++++++++++++++++++++++++++------- > >> SMPdesign/lockdeqhash1R.fig | 39 +++-- > >> SMPdesign/lockdeqhashlots.eps | 323 +++++++++++++++++++++++++++++++++++------ > >> SMPdesign/lockdeqhashlots.fig | 48 ++++-- > >> SMPdesign/partexercises.tex | 14 +- > >> 5 files changed, 622 insertions(+), 132 deletions(-) > >> > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures 2016-08-08 0:15 ` Paul E. McKenney @ 2016-08-08 15:21 ` Akira Yokosawa 2016-08-08 16:42 ` Paul E. McKenney 0 siblings, 1 reply; 6+ messages in thread From: Akira Yokosawa @ 2016-08-08 15:21 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa On 2016/08/07 17:15:28 -0700, Paul E. McKenney wrote: > On Mon, Aug 08, 2016 at 07:08:17AM +0900, Akira Yokosawa wrote: >> On 2016/08/07 11:18:39 -0700, Paul E. McKenney wrote: >>> On Sat, Aug 06, 2016 at 07:07:29PM +0900, Akira Yokosawa wrote: >>>> Hi Paul, >>>> >>>> This is somewhat related to the "using hyphens for minus signs" issue. >>>> In Figures 6.8 and 6.9, entry names such as "L-2" are used. >>>> The "-" here means minus, but it is *not* obvious at first glance if >>>> it means "L minus 2" or not. >>>> >>>> If we make "-2" a subscript, it would be much easier to see that >>>> it means "L whose sequence number is 'minus 2'". >>>> So, I tweaked the xfig sources of the figures to make those numbers >>>> in entries look like subscripts. I also altered the numbers in entry names >>>> mentioned in the corresponding text as subscripts (using math mode). >>>> >>>> I'm sending this as a pull request as the resulting patch became fairly >>>> large due to eps files. >>>> >>>> I hope you like there tweaks. >>>> >>>> Additional patch is a fix of entry numbers of Figure 6.9, which is >>>> actually 16 if my understanding of the figure is correct. >>> >>> I pulled both, thank you. >>> >>> Any thoughts on converting .fig files to .svg? My approach has been to >>> import .fig files into inkscape as I need to modify them. The results >>> are OK, but not perfect (for example, arrows in .fig become two objects >>> in .svg, the line and the arrowhead). >> >> So, I tried this. >> But by importing into inkscape, all the texts get the same font size... >> Unfortunately, font size specifier in .fig seems to be ignored. >> Or I might be missing something. > > Hmmm... I guess I have been getting lucky, working only with .fig files > with a single font size. > >> BTW, now that we can use -jN option for building .pdf files, wouldn't it >> be a good idea to get rid of .eps files in the repository whose sources >> are .fig files by adding a ".fig -> .eps" rule in Makefile? >> Then the patch would have been much smaller. >> >> Let me know what you think. > > Making that initial clone and build go faster makes a lot of sense to me! Well, current build starts from .eps and if we remove .eps, then the build will start from .fig. So the build time should increase somewhat. Reduction of the patch size will be the point of doing this. I'll try and evaluate how much longer the first build would take. Give me a week or so. Ah, my environment has only a few cores so the evaluation result would be only a hint. Thanks, Akira > > Thanx, Paul > >> Thanks, Akira >>> >>> Thanx, Paul >>> >>>> Thanks, Akira >>>> >>>> --------- >>>> The following changes since commit ec15e80376f04f5b2be8779aedfda3ba184a4e37: >>>> >>>> Fix URL for MathieuDesnoyers2009LFCollabSummit (2016-08-05 13:12:07 -0700) >>>> >>>> are available in the git repository at: >>>> >>>> https://github.com/akiyks/perfbook.git lockdeqhash-use-subscript >>>> >>>> for you to fetch changes up to 7893124def444db34fbb6bc2b4e9b2f20675c2eb: >>>> >>>> SMPdesign: Fix number of elements regarding Figure 6.9 (2016-08-06 18:14:07 +0900) >>>> >>>> ---------------------------------------------------------------- >>>> Akira Yokosawa (2): >>>> SMPdesign: Use subscript in lockdeqhash figures >>>> SMPdesign: Fix number of elements regarding Figure 6.9 >>>> >>>> SMPdesign/lockdeqhash1R.eps | 330 +++++++++++++++++++++++++++++++++++------- >>>> SMPdesign/lockdeqhash1R.fig | 39 +++-- >>>> SMPdesign/lockdeqhashlots.eps | 323 +++++++++++++++++++++++++++++++++++------ >>>> SMPdesign/lockdeqhashlots.fig | 48 ++++-- >>>> SMPdesign/partexercises.tex | 14 +- >>>> 5 files changed, 622 insertions(+), 132 deletions(-) >>>> >>> >>> >> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures 2016-08-08 15:21 ` Akira Yokosawa @ 2016-08-08 16:42 ` Paul E. McKenney 0 siblings, 0 replies; 6+ messages in thread From: Paul E. McKenney @ 2016-08-08 16:42 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Tue, Aug 09, 2016 at 12:21:04AM +0900, Akira Yokosawa wrote: > On 2016/08/07 17:15:28 -0700, Paul E. McKenney wrote: > > On Mon, Aug 08, 2016 at 07:08:17AM +0900, Akira Yokosawa wrote: > >> On 2016/08/07 11:18:39 -0700, Paul E. McKenney wrote: > >>> On Sat, Aug 06, 2016 at 07:07:29PM +0900, Akira Yokosawa wrote: > >>>> Hi Paul, > >>>> > >>>> This is somewhat related to the "using hyphens for minus signs" issue. > >>>> In Figures 6.8 and 6.9, entry names such as "L-2" are used. > >>>> The "-" here means minus, but it is *not* obvious at first glance if > >>>> it means "L minus 2" or not. > >>>> > >>>> If we make "-2" a subscript, it would be much easier to see that > >>>> it means "L whose sequence number is 'minus 2'". > >>>> So, I tweaked the xfig sources of the figures to make those numbers > >>>> in entries look like subscripts. I also altered the numbers in entry names > >>>> mentioned in the corresponding text as subscripts (using math mode). > >>>> > >>>> I'm sending this as a pull request as the resulting patch became fairly > >>>> large due to eps files. > >>>> > >>>> I hope you like there tweaks. > >>>> > >>>> Additional patch is a fix of entry numbers of Figure 6.9, which is > >>>> actually 16 if my understanding of the figure is correct. > >>> > >>> I pulled both, thank you. > >>> > >>> Any thoughts on converting .fig files to .svg? My approach has been to > >>> import .fig files into inkscape as I need to modify them. The results > >>> are OK, but not perfect (for example, arrows in .fig become two objects > >>> in .svg, the line and the arrowhead). > >> > >> So, I tried this. > >> But by importing into inkscape, all the texts get the same font size... > >> Unfortunately, font size specifier in .fig seems to be ignored. > >> Or I might be missing something. > > > > Hmmm... I guess I have been getting lucky, working only with .fig files > > with a single font size. > > > >> BTW, now that we can use -jN option for building .pdf files, wouldn't it > >> be a good idea to get rid of .eps files in the repository whose sources > >> are .fig files by adding a ".fig -> .eps" rule in Makefile? > >> Then the patch would have been much smaller. > >> > >> Let me know what you think. > > > > Making that initial clone and build go faster makes a lot of sense to me! > > Well, current build starts from .eps and if we remove .eps, then the build > will start from .fig. So the build time should increase somewhat. > Reduction of the patch size will be the point of doing this. Fair point! > I'll try and evaluate how much longer the first build would take. > Give me a week or so. Ah, my environment has only a few cores so the > evaluation result would be only a hint. I do have a 128-core system, although it is shared, so use of more than (say) 64 cores is unlikely to give reproducible results. Just let me know exactly what you want tested, preferably by sending me a simple script that does what you want. Thanx, Paul ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-08 16:42 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-08-06 10:07 [GIT PULL] SMPdesign: Use subscript in lockdeqhash figures Akira Yokosawa 2016-08-07 18:18 ` Paul E. McKenney 2016-08-07 22:08 ` Akira Yokosawa 2016-08-08 0:15 ` Paul E. McKenney 2016-08-08 15:21 ` Akira Yokosawa 2016-08-08 16:42 ` Paul E. McKenney
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.