From: Lee Jones <lee.jones@linaro.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle
Date: Mon, 8 Aug 2016 14:39:53 +0100 [thread overview]
Message-ID: <20160808133953.GR5243@dell> (raw)
In-Reply-To: <1468575526-25074-1-git-send-email-peter.chen@nxp.com>
On Fri, 15 Jul 2016, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/mfd/qcom_rpm.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 2e44323..ecca115 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> }
>
> rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
> + of_node_put(syscon_np);
> if (IS_ERR(rpm->ipc_regmap))
> return PTR_ERR(rpm->ipc_regmap);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-08-08 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 9:38 [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-15 18:50 ` Bjorn Andersson
2016-08-08 13:39 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808133953.GR5243@dell \
--to=lee.jones@linaro.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.