From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Dmitry Torokhov <dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3 2/2] tpm_tis_spi: add max xfer size
Date: Tue, 9 Aug 2016 11:14:40 +0300 [thread overview]
Message-ID: <20160809081439.GB10537@intel.com> (raw)
In-Reply-To: <20160728225316.GB28623@dtor-ws>
On Thu, Jul 28, 2016 at 03:53:16PM -0700, Dmitry Torokhov wrote:
> On Wed, Jul 27, 2016 at 08:49:57PM -0700, Andrey Pronin wrote:
> > Reject burstcounts larger than 64 bytes reported by tpm.
> > SPI Hardware Protocol defined in section 6.4 of TCG PTP
> > Spec supports up to 64 bytes of data in a transaction.
> >
> > Signed-off-by: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> Reviewed-by: Dmitry Torokhov <dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
/Jarkko
> > ---
> > drivers/char/tpm/tpm_tis_spi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
> > index dbaad9c..b103373 100644
> > --- a/drivers/char/tpm/tpm_tis_spi.c
> > +++ b/drivers/char/tpm/tpm_tis_spi.c
> > @@ -206,6 +206,7 @@ static const struct tpm_tis_phy_ops tpm_spi_phy_ops = {
> > .read16 = tpm_tis_spi_read16,
> > .read32 = tpm_tis_spi_read32,
> > .write32 = tpm_tis_spi_write32,
> > + .max_xfer_size = MAX_SPI_FRAMESIZE,
> > };
> >
> > static int tpm_tis_spi_probe(struct spi_device *dev)
> > --
> > 2.6.6
> >
>
> --
> Dmitry
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Andrey Pronin <apronin@chromium.org>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Christophe Ricard <christophe.ricard@gmail.com>,
smbarber@chromium.org, dianders@chromium.org
Subject: Re: [PATCH v3 2/2] tpm_tis_spi: add max xfer size
Date: Tue, 9 Aug 2016 11:14:40 +0300 [thread overview]
Message-ID: <20160809081439.GB10537@intel.com> (raw)
In-Reply-To: <20160728225316.GB28623@dtor-ws>
On Thu, Jul 28, 2016 at 03:53:16PM -0700, Dmitry Torokhov wrote:
> On Wed, Jul 27, 2016 at 08:49:57PM -0700, Andrey Pronin wrote:
> > Reject burstcounts larger than 64 bytes reported by tpm.
> > SPI Hardware Protocol defined in section 6.4 of TCG PTP
> > Spec supports up to 64 bytes of data in a transaction.
> >
> > Signed-off-by: Andrey Pronin <apronin@chromium.org>
>
> Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> > ---
> > drivers/char/tpm/tpm_tis_spi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
> > index dbaad9c..b103373 100644
> > --- a/drivers/char/tpm/tpm_tis_spi.c
> > +++ b/drivers/char/tpm/tpm_tis_spi.c
> > @@ -206,6 +206,7 @@ static const struct tpm_tis_phy_ops tpm_spi_phy_ops = {
> > .read16 = tpm_tis_spi_read16,
> > .read32 = tpm_tis_spi_read32,
> > .write32 = tpm_tis_spi_write32,
> > + .max_xfer_size = MAX_SPI_FRAMESIZE,
> > };
> >
> > static int tpm_tis_spi_probe(struct spi_device *dev)
> > --
> > 2.6.6
> >
>
> --
> Dmitry
next prev parent reply other threads:[~2016-08-09 8:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 1:39 [PATCH 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-15 1:39 ` [PATCH 1/2] tpm_tis_core: " Andrey Pronin
[not found] ` <1468546745-14646-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-15 3:13 ` Jason Gunthorpe
2016-07-15 3:13 ` Jason Gunthorpe
2016-07-15 3:25 ` Andrey Pronin
2016-07-15 3:48 ` Guenter Roeck
[not found] ` <20160715031351.GD9347-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-18 18:53 ` Jarkko Sakkinen
2016-07-18 18:53 ` Jarkko Sakkinen
[not found] ` <1468546745-14646-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-15 1:39 ` [PATCH 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-15 1:39 ` Andrey Pronin
2016-07-20 2:34 ` [PATCH v2 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-20 2:34 ` Andrey Pronin
2016-07-20 2:34 ` [PATCH v2 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
[not found] ` <cover.1468981325.git.apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-20 2:34 ` [PATCH v2 1/2] tpm_tis_core: add optional max xfer size check Andrey Pronin
2016-07-20 2:34 ` Andrey Pronin
2016-07-20 15:10 ` [PATCH v2 0/2] tpm: " Jarkko Sakkinen
2016-07-20 15:10 ` Jarkko Sakkinen
2016-07-28 3:49 ` [PATCH v3 " Andrey Pronin
2016-07-28 3:49 ` Andrey Pronin
2016-07-28 3:49 ` [PATCH v3 1/2] tpm_tis_core: " Andrey Pronin
2016-07-28 3:49 ` Andrey Pronin
2016-07-28 22:52 ` Dmitry Torokhov
[not found] ` <1469677797-74304-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-08-09 8:14 ` Jarkko Sakkinen
2016-08-09 8:14 ` Jarkko Sakkinen
2020-11-19 10:00 ` Dafna Hirschfeld
2020-11-20 15:15 ` Jarkko Sakkinen
2016-07-28 3:49 ` [PATCH v3 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-28 3:49 ` Andrey Pronin
2016-07-28 22:53 ` Dmitry Torokhov
2016-08-09 8:14 ` Jarkko Sakkinen [this message]
2016-08-09 8:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809081439.GB10537@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.