From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test
Date: Tue, 09 Aug 2016 12:17:53 +0000 [thread overview]
Message-ID: <20160809121753.GZ8132@piout.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608091403050.2911@hadrien>
On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote :
>
>
> On Tue, 9 Aug 2016, Christophe JAILLET wrote:
>
> > It is likely that checking the result of 'pcf2123_write_reg' is expected
> > here.
> > Also fix a small style issue. The '{' at the beginning of the function
> > is misplaced.
>
> They shouldn't be in the same patch. If you are wrong about the ret
> issue, the { should still be moved.
>
That is true but as it is a really trivial patch, I didn't care that
much.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test
Date: Tue, 9 Aug 2016 14:17:53 +0200 [thread overview]
Message-ID: <20160809121753.GZ8132@piout.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608091403050.2911@hadrien>
On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote :
>
>
> On Tue, 9 Aug 2016, Christophe JAILLET wrote:
>
> > It is likely that checking the result of 'pcf2123_write_reg' is expected
> > here.
> > Also fix a small style issue. The '{' at the beginning of the function
> > is misplaced.
>
> They shouldn't be in the same patch. If you are wrong about the ret
> issue, the { should still be moved.
>
That is true but as it is a really trivial patch, I didn't care that
much.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test
Date: Tue, 9 Aug 2016 14:17:53 +0200 [thread overview]
Message-ID: <20160809121753.GZ8132@piout.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608091403050.2911@hadrien>
On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote :
>
>
> On Tue, 9 Aug 2016, Christophe JAILLET wrote:
>
> > It is likely that checking the result of 'pcf2123_write_reg' is expected
> > here.
> > Also fix a small style issue. The '{' at the beginning of the function
> > is misplaced.
>
> They shouldn't be in the same patch. If you are wrong about the ret
> issue, the { should still be moved.
>
That is true but as it is a really trivial patch, I didn't care that
much.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-08-09 12:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:58 [PATCH] rtc: pcf2123: Add missing error code assignment before test Christophe JAILLET
2016-08-09 11:58 ` Christophe JAILLET
2016-08-09 11:58 ` [rtc-linux] " Christophe JAILLET
2016-08-09 12:03 ` Julia Lawall
2016-08-09 12:03 ` Julia Lawall
2016-08-09 12:03 ` [rtc-linux] " Julia Lawall
2016-08-09 12:17 ` Alexandre Belloni [this message]
2016-08-09 12:17 ` Alexandre Belloni
2016-08-09 12:17 ` Alexandre Belloni
2016-08-09 12:05 ` Alexandre Belloni
2016-08-09 12:05 ` Alexandre Belloni
2016-08-09 12:05 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809121753.GZ8132@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=christophe.jaillet@wanadoo.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.