From: thierry.reding@gmail.com (Thierry Reding)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] i2c: don't print error when adding adapter fails
Date: Tue, 9 Aug 2016 14:58:46 +0200 [thread overview]
Message-ID: <20160809125846.GA17535@ulmo.ba.sec> (raw)
In-Reply-To: <1470742581-12971-2-git-send-email-wsa-dev@sang-engineering.com>
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote:
[...]
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index b126dbaa47e370..d9979da11485ae 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -932,10 +932,8 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> i2c_dev->adapter.dev.of_node = pdev->dev.of_node;
>
> ret = i2c_add_numbered_adapter(&i2c_dev->adapter);
> - if (ret) {
> - dev_err(&pdev->dev, "Failed to add I2C adapter\n");
> + if (ret)
> goto disable_div_clk;
> - }
>
> return 0;
>
Acked-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20160809/e1459211/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Jean Delvare" <jdelvare-IBi9RG/b67k@public.gmane.org>,
"Wolfram Sang" <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"Ludovic Desroches"
<ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
"Ray Jui" <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Scott Branden"
<sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Jon Mason" <jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
"Florian Fainelli"
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Sonic Zhang"
<sonic.zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>,
"Brian Norris"
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Gregory Fong"
<gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Michal Simek"
<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Sören Brinkmann"
<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Jochen Friedrich" <jochen-NIgtFMG+Po8@public.gmane.org>,
"Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
"Kevin Hilman" <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"Uwe Kleine-König"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Kukjin Kim" <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Krzysztof Kozlowski"
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] i2c: don't print error when adding adapter fails
Date: Tue, 9 Aug 2016 14:58:46 +0200 [thread overview]
Message-ID: <20160809125846.GA17535@ulmo.ba.sec> (raw)
In-Reply-To: <1470742581-12971-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote:
[...]
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index b126dbaa47e370..d9979da11485ae 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -932,10 +932,8 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> i2c_dev->adapter.dev.of_node = pdev->dev.of_node;
>
> ret = i2c_add_numbered_adapter(&i2c_dev->adapter);
> - if (ret) {
> - dev_err(&pdev->dev, "Failed to add I2C adapter\n");
> + if (ret)
> goto disable_div_clk;
> - }
>
> return 0;
>
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Jean Delvare" <jdelvare@suse.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Jon Mason" <jonmason@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Sonic Zhang" <sonic.zhang@analog.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Jochen Friedrich" <jochen@scram.de>,
"Sekhar Nori" <nsekhar@ti.com>,
"Kevin Hilman" <khilman@kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Uwe Kleine-König" <kernel@pengutronix.de>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Seth Heasley" <seth.heasley@intel.com>,
"Neil Horman" <nhorman@tuxdriver.com>,
"Joachim Eastwood" <manabian@gmail.com>,
"Carlo Caione" <carlo@caione.org>,
"Alessandro Rubini" <rubini@unipv.it>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Peter Korsgaard" <jacmet@sunsite.dk>,
"Tony Lindgren" <tony@atomide.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Sylvain Lemieux" <slemieux.tyco@gmail.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Heiko Stuebner" <heiko@sntech.de>,
"Barry Song" <baohua@kernel.org>,
"Patrice Chotard" <patrice.chotard@st.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Tony Prisk" <linux@prisktech.co.nz>,
linux-arm-kernel@lists.infradead.org,
adi-buildroot-devel@lists.sourceforge.net,
linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
linux-rockchip@lists.infradead.org, kernel@stlinux.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] i2c: don't print error when adding adapter fails
Date: Tue, 9 Aug 2016 14:58:46 +0200 [thread overview]
Message-ID: <20160809125846.GA17535@ulmo.ba.sec> (raw)
In-Reply-To: <1470742581-12971-2-git-send-email-wsa-dev@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote:
[...]
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index b126dbaa47e370..d9979da11485ae 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -932,10 +932,8 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> i2c_dev->adapter.dev.of_node = pdev->dev.of_node;
>
> ret = i2c_add_numbered_adapter(&i2c_dev->adapter);
> - if (ret) {
> - dev_err(&pdev->dev, "Failed to add I2C adapter\n");
> + if (ret)
> goto disable_div_clk;
> - }
>
> return 0;
>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-09 12:58 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:36 [PATCH] i2c: don't print error when adding adapter fails Wolfram Sang
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:47 ` Grygorii Strashko
2016-08-09 11:47 ` Grygorii Strashko
2016-08-09 11:47 ` Grygorii Strashko
2016-08-09 11:48 ` Peter Korsgaard
2016-08-09 11:48 ` Peter Korsgaard
2016-08-09 11:48 ` Peter Korsgaard
2016-08-09 11:57 ` Uwe Kleine-König
2016-08-09 11:57 ` Uwe Kleine-König
2016-08-09 11:57 ` Uwe Kleine-König
2016-08-09 13:59 ` Wolfram Sang
2016-08-09 13:59 ` Wolfram Sang
2016-08-09 13:59 ` Wolfram Sang
2016-08-09 12:13 ` Heiko Stübner
2016-08-09 12:13 ` Heiko Stübner
2016-08-09 12:13 ` Heiko Stübner
2016-08-09 12:55 ` Neil Horman
2016-08-09 12:55 ` Neil Horman
2016-08-09 12:55 ` Neil Horman
2016-08-10 2:56 ` Zhang, Sonic
2016-08-10 2:56 ` Zhang, Sonic
2016-08-10 2:56 ` Zhang, Sonic
2016-08-09 12:58 ` Thierry Reding [this message]
2016-08-09 12:58 ` Thierry Reding
2016-08-09 12:58 ` Thierry Reding
2016-08-09 13:31 ` Guenter Roeck
2016-08-09 13:31 ` Guenter Roeck
2016-08-09 13:31 ` Guenter Roeck
2016-08-09 14:39 ` Wolfram Sang
2016-08-09 14:39 ` Wolfram Sang
2016-08-09 14:39 ` Wolfram Sang
2016-08-09 16:15 ` Ray Jui
2016-08-09 16:15 ` Ray Jui
2016-08-09 16:15 ` Ray Jui
2016-08-09 16:36 ` Vladimir Zapolskiy
2016-08-09 16:36 ` Vladimir Zapolskiy
2016-08-09 16:36 ` Vladimir Zapolskiy
2016-08-10 6:17 ` Ludovic Desroches
2016-08-10 6:17 ` Ludovic Desroches
2016-08-10 6:17 ` Ludovic Desroches
2016-08-10 8:32 ` Krzysztof Kozlowski
2016-08-10 8:32 ` Krzysztof Kozlowski
2016-08-10 8:32 ` Krzysztof Kozlowski
2016-08-10 8:34 ` Laxman Dewangan
2016-08-10 8:34 ` Laxman Dewangan
2016-08-10 8:34 ` Laxman Dewangan
2016-10-05 15:17 ` Jean Delvare
2016-10-05 15:17 ` Jean Delvare
2016-10-05 15:17 ` Jean Delvare
2016-08-09 16:45 ` Joachim Eastwood
2016-08-09 16:45 ` Joachim Eastwood
2016-08-09 16:45 ` Joachim Eastwood
2016-08-09 16:45 ` Joachim Eastwood
2016-08-10 6:50 ` [STLinux Kernel] " Patrice Chotard
2016-08-10 6:50 ` Patrice Chotard
2016-08-10 6:50 ` Patrice Chotard
2016-08-10 6:50 ` Patrice Chotard
2016-08-14 22:17 ` Wolfram Sang
2016-08-14 22:17 ` Wolfram Sang
2016-08-14 22:17 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809125846.GA17535@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.