From: Joerg Roedel <joro@8bytes.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: kgene@kernel.org, k.kozlowski@samsung.com,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH] iommu/exynos: Modify error handling
Date: Tue, 9 Aug 2016 17:29:02 +0200 [thread overview]
Message-ID: <20160809152902.GC29650@8bytes.org> (raw)
In-Reply-To: <20160801061838.GA17805@amitoj-Inspiron-3542>
On Mon, Aug 01, 2016 at 11:48:38AM +0530, Amitoj Kaur Chawla wrote:
> of_platform_device_create returns NULL on error so an IS_ERR test is
> incorrect here and a NULL check is required.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> e = of_platform_device_create(...);
> if(
> - IS_ERR(e)
> + !e
> )
> {
> <+...
> return
> - PTR_ERR(e)
> + -ENODEV
> ;
> ...+>
> }
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/iommu/exynos-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch didn't apply cleanly against v4.8-rc1, but I fixed it up and it is
now in my tree, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/exynos: Modify error handling
Date: Tue, 9 Aug 2016 17:29:02 +0200 [thread overview]
Message-ID: <20160809152902.GC29650@8bytes.org> (raw)
In-Reply-To: <20160801061838.GA17805@amitoj-Inspiron-3542>
On Mon, Aug 01, 2016 at 11:48:38AM +0530, Amitoj Kaur Chawla wrote:
> of_platform_device_create returns NULL on error so an IS_ERR test is
> incorrect here and a NULL check is required.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> e = of_platform_device_create(...);
> if(
> - IS_ERR(e)
> + !e
> )
> {
> <+...
> return
> - PTR_ERR(e)
> + -ENODEV
> ;
> ...+>
> }
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/iommu/exynos-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch didn't apply cleanly against v4.8-rc1, but I fixed it up and it is
now in my tree, thanks.
next prev parent reply other threads:[~2016-08-09 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 6:18 [PATCH] iommu/exynos: Modify error handling Amitoj Kaur Chawla
2016-08-01 6:18 ` Amitoj Kaur Chawla
2016-08-09 15:29 ` Joerg Roedel [this message]
2016-08-09 15:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809152902.GC29650@8bytes.org \
--to=joro@8bytes.org \
--cc=amitoj1606@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=julia.lawall@lip6.fr \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.