From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: fix a race condition tpm2_unseal_trusted()
Date: Tue, 9 Aug 2016 09:49:03 -0600 [thread overview]
Message-ID: <20160809154903.GA7346@obsidianresearch.com> (raw)
In-Reply-To: <20160809103629.GA17800-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, Aug 09, 2016 at 01:36:29PM +0300, Jarkko Sakkinen wrote:
> Functionally my patch should not break anything. I understand the need
> for clean up of locking but why doing this now to make the driver
> non-racy would make clean up later on any harder?
Then rename the functions so they don't confusingly look like the
standard kernel pattern that doesn't lock.
Jason
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-security-module@vger.kernel.org,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: fix a race condition tpm2_unseal_trusted()
Date: Tue, 9 Aug 2016 09:49:03 -0600 [thread overview]
Message-ID: <20160809154903.GA7346@obsidianresearch.com> (raw)
In-Reply-To: <20160809103629.GA17800@intel.com>
On Tue, Aug 09, 2016 at 01:36:29PM +0300, Jarkko Sakkinen wrote:
> Functionally my patch should not break anything. I understand the need
> for clean up of locking but why doing this now to make the driver
> non-racy would make clean up later on any harder?
Then rename the functions so they don't confusingly look like the
standard kernel pattern that doesn't lock.
Jason
next prev parent reply other threads:[~2016-08-09 15:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 0:16 [PATCH] tpm: fix a race condition tpm2_unseal_trusted() Jarkko Sakkinen
2016-07-20 0:16 ` Jarkko Sakkinen
[not found] ` <1468973792-17598-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-07-20 16:48 ` Jason Gunthorpe
2016-07-20 16:48 ` Jason Gunthorpe
[not found] ` <20160720164818.GA21460-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-20 20:53 ` Jarkko Sakkinen
2016-07-20 20:53 ` Jarkko Sakkinen
[not found] ` <20160720205314.GA6525-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-20 21:13 ` Jason Gunthorpe
2016-07-20 21:13 ` Jason Gunthorpe
[not found] ` <20160720211332.GA32417-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-21 9:02 ` Jarkko Sakkinen
2016-07-21 9:02 ` Jarkko Sakkinen
[not found] ` <20160721090245.GA7999-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-21 16:25 ` Jason Gunthorpe
2016-07-21 16:25 ` Jason Gunthorpe
2016-08-09 10:36 ` Jarkko Sakkinen
[not found] ` <20160809103629.GA17800-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-09 15:49 ` Jason Gunthorpe [this message]
2016-08-09 15:49 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2016-08-16 19:38 Jarkko Sakkinen
2016-08-16 19:38 ` Jarkko Sakkinen
2016-08-17 4:31 ` Jarkko Sakkinen
2016-08-24 0:57 Jarkko Sakkinen
2016-08-24 0:57 ` Jarkko Sakkinen
[not found] ` <1472000243-7088-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-08-24 1:32 ` Jarkko Sakkinen
2016-08-24 1:32 ` Jarkko Sakkinen
2016-08-25 18:30 ` Jason Gunthorpe
2016-08-25 18:30 ` Jason Gunthorpe
[not found] ` <20160825183059.GB1142-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-08-25 21:06 ` Jarkko Sakkinen
2016-08-25 21:06 ` Jarkko Sakkinen
[not found] ` <20160825210437.GA8658-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-25 21:09 ` Jason Gunthorpe
2016-08-25 21:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809154903.GA7346@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.