From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 2/4] kernfs: make kernfs_path*() behave in the style of strlcpy()
Date: Tue, 9 Aug 2016 15:14:41 -0500 [thread overview]
Message-ID: <20160809201441.GA2513@mail.hallyn.com> (raw)
In-Reply-To: <20160809195813.GF4906-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
Quoting Tejun Heo (tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org):
> Hello, Serge.
>
> On Tue, Aug 09, 2016 at 10:33:05AM -0500, Serge E. Hallyn wrote:
> > > + for (i = depth_to - 1; i >= 0; i--) {
> > > + for (kn = kn_to, j = 0; j < i; j++)
> > > + kn = kn->parent;
> >
> > This is O(n^2) where n is the path depth. It's not a hot path, though, do
> > we care?
>
> I don't think it matters. It's a slow path and cgroup hierarchies
> aren't supposed to be super deep to begin with. If it ever does, we
> can replace the cgroup->ancestor_ids[] array with ancestor pointer
> array and walk that instead.
>
> Thanks.
Ok, thanks
Acked-by: Serge Hallyn <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
gregkh@linuxfoundation.org, serge.hallyn@ubuntu.com,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
kernel-team@fb.com, hannes@cmpxchg.org, lizefan@huawei.com
Subject: Re: [PATCH 2/4] kernfs: make kernfs_path*() behave in the style of strlcpy()
Date: Tue, 9 Aug 2016 15:14:41 -0500 [thread overview]
Message-ID: <20160809201441.GA2513@mail.hallyn.com> (raw)
In-Reply-To: <20160809195813.GF4906@mtj.duckdns.org>
Quoting Tejun Heo (tj@kernel.org):
> Hello, Serge.
>
> On Tue, Aug 09, 2016 at 10:33:05AM -0500, Serge E. Hallyn wrote:
> > > + for (i = depth_to - 1; i >= 0; i--) {
> > > + for (kn = kn_to, j = 0; j < i; j++)
> > > + kn = kn->parent;
> >
> > This is O(n^2) where n is the path depth. It's not a hot path, though, do
> > we care?
>
> I don't think it matters. It's a slow path and cgroup hierarchies
> aren't supposed to be super deep to begin with. If it ever does, we
> can replace the cgroup->ancestor_ids[] array with ancestor pointer
> array and walk that instead.
>
> Thanks.
Ok, thanks
Acked-by: Serge Hallyn <serge@hallyn.com>
next prev parent reply other threads:[~2016-08-09 20:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 5:23 [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in strlcpy() style Tejun Heo
2016-08-09 5:23 ` Tejun Heo
2016-08-09 5:23 ` [PATCH 1/4] kernfs: add dummy implementation of kernfs_path_from_node() Tejun Heo
[not found] ` <1470720204-4605-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-09 6:14 ` [PATCH v2 " Tejun Heo
2016-08-09 6:14 ` Tejun Heo
2016-08-09 5:23 ` [PATCH 2/4] kernfs: make kernfs_path*() behave in the style of strlcpy() Tejun Heo
[not found] ` <1470720204-4605-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-09 15:33 ` Serge E. Hallyn
2016-08-09 15:33 ` Serge E. Hallyn
[not found] ` <20160809153305.GB30775-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-08-09 19:58 ` Tejun Heo
2016-08-09 19:58 ` Tejun Heo
[not found] ` <20160809195813.GF4906-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-08-09 20:14 ` Serge E. Hallyn [this message]
2016-08-09 20:14 ` Serge E. Hallyn
2016-08-09 5:23 ` [PATCH 3/4] kernfs: remove kernfs_path_len() Tejun Heo
2016-08-09 5:23 ` [PATCH 4/4] cgroup: make cgroup_path() and friends behave in the style of strlcpy() Tejun Heo
[not found] ` <1470720204-4605-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-09 6:14 ` [PATCH v2 " Tejun Heo
2016-08-09 6:14 ` Tejun Heo
2016-08-09 8:18 ` [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in strlcpy() style Greg KH
[not found] ` <20160809081819.GB10279-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-08-10 15:25 ` Tejun Heo
2016-08-10 15:25 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809201441.GA2513@mail.hallyn.com \
--to=serge-a9i7lubdfnhqt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.