All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: kan.liang@intel.com
Cc: peterz@infradead.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, ak@linux.intel.com,
	eranian@google.com
Subject: Re: [PATCH V3 2/2] perf/x86/intel/uncore: add enable_box for client msr uncore
Date: Wed, 10 Aug 2016 12:58:58 +0200	[thread overview]
Message-ID: <20160810105858.GA29633@gmail.com> (raw)
In-Reply-To: <1467208912-8179-2-git-send-email-kan.liang@intel.com>


* kan.liang@intel.com <kan.liang@intel.com> wrote:

> From: Kan Liang <kan.liang@intel.com>
> 
> PERF_GLOBAL_CTL could be cleared after Package C7. This patch tries to
> workaround this issue by re-enable PERF_GLOBAL_CTL in enable_box.
> The workaround does not cover all cases. It helps for new events after
> returning from C7.
> There is no drawback in letting the thing enabled, so it does not need
> disable_box here.

This changelog is very poor for similar reasons as:

 Re: [PATCH] perf/x86/intel/uncore: correct uncore num_counters

Please fix the changelog to conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

The first item is the most important one - while developers 
(naturally) tend to concentrate on the least important point, the last 
one.

Thanks,

	Ingo

  reply	other threads:[~2016-08-10 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 14:01 [PATCH V3 1/2] perf/x86/intel/uncore: Add support for Intel SKL client uncore kan.liang
2016-06-29 14:01 ` [PATCH V3 2/2] perf/x86/intel/uncore: add enable_box for client msr uncore kan.liang
2016-08-10 10:58   ` Ingo Molnar [this message]
2016-07-07  8:31 ` [tip:perf/core] perf/x86/intel/uncore: Add support for the Intel Skylake client uncore PMU tip-bot for Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810105858.GA29633@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.