Re: [PATCH] x86/efi-bgrt: remove the check of the version field

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
Cc: Matt Fleming
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"H . Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] x86/efi-bgrt: remove the check of the version field
Date: Wed, 10 Aug 2016 14:52:01 +0200	[thread overview]
Message-ID: <20160810125201.GA9028@gmail.com> (raw)
In-Reply-To: <20160809052546.31462-1-icenowy-ymACFijhrKM@public.gmane.org>


* Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:

> Some broken firmwares have a wrongly filled version field in BGRT table.
> (See http://wiki.osdev.org/Broken_UEFI_implementations )
> 
> As we know, these firmwares can also provide correct BGRT image, although
> the table is wrong.
> 
> After removing the check of the version field, the kernel can now extract
> the image correctly, and the information is also correct.
> 
> Tested on a Thinkpad E531 (68854UC).

What's the practical effects of the bug - what problems does a missing 
/sys/firmware/acpi/bgrt/ cause?

I.e. how does the user notice?

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)

From: Ingo Molnar <mingo@kernel.org>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/efi-bgrt: remove the check of the version field
Date: Wed, 10 Aug 2016 14:52:01 +0200	[thread overview]
Message-ID: <20160810125201.GA9028@gmail.com> (raw)
In-Reply-To: <20160809052546.31462-1-icenowy@aosc.xyz>


* Icenowy Zheng <icenowy@aosc.xyz> wrote:

> Some broken firmwares have a wrongly filled version field in BGRT table.
> (See http://wiki.osdev.org/Broken_UEFI_implementations )
> 
> As we know, these firmwares can also provide correct BGRT image, although
> the table is wrong.
> 
> After removing the check of the version field, the kernel can now extract
> the image correctly, and the information is also correct.
> 
> Tested on a Thinkpad E531 (68854UC).

What's the practical effects of the bug - what problems does a missing 
/sys/firmware/acpi/bgrt/ cause?

I.e. how does the user notice?

Thanks,

	Ingo

next      parent reply	other threads:[~2016-08-10 12:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160809052546.31462-1-icenowy@aosc.xyz>
     [not found] ` <20160809052546.31462-1-icenowy-ymACFijhrKM@public.gmane.org>
2016-08-10 12:52   ` Ingo Molnar [this message]
2016-08-10 12:52     ` [PATCH] x86/efi-bgrt: remove the check of the version field Ingo Molnar
     [not found]     ` <120791470839405@web16h.yandex.ru>
     [not found]       ` <120791470839405-TUpq1W2QCG9xpj1cXAZ9Bg@public.gmane.org>
2016-08-11  8:48         ` Ingo Molnar
2016-08-11  8:48           ` Ingo Molnar
2016-08-15 12:56 ` Matt Fleming
2016-08-15 16:09   ` Josh Triplett
     [not found]   ` <20160815125643.GG30909-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-08-17  5:44     ` Dave Young
2016-08-17  5:44       ` Dave Young
2016-08-18 20:41       ` Matt Fleming
     [not found]         ` <20160818204130.GQ30909-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-08-22  7:28           ` Dave Young
2016-08-22  7:28             ` Dave Young
     [not found]             ` <388401471855799@web30j.yandex.ru>
     [not found]               ` <388401471855799-X2xH9E7M2qxxpj1cXAZ9Bg@public.gmane.org>
2016-08-24  7:30                 ` Dave Young
2016-08-24  7:30                   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810125201.GA9028@gmail.com \
    --to=mingo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=icenowy-ymACFijhrKM@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.