All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: linux-nvdimm@lists.01.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()
Date: Wed, 10 Aug 2016 08:52:06 -0600	[thread overview]
Message-ID: <20160810145206.GA17734@linux.intel.com> (raw)
In-Reply-To: <CALYGNiNwTXY2qQtx2nU9LjTiEYWwoHR63SnrkwUJpwgOLJPKSQ@mail.gmail.com>

On Wed, Aug 10, 2016 at 09:29:23AM +0300, Konstantin Khlebnikov wrote:
> On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler
> <ross.zwisler@linux.intel.com> wrote:
> > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote:
> > <>
> >> NAK. This is fast path and it's already bloated.
> >> I want to revert most changes here and rework "multiorder" entries.
> >>
> >> Here you can find almost ready patchset for that
> >> https://github.com/koct9i/linux/commits/radix-tree
> >
> > Okay...are you okay with the second 2 patches in the series?  They stand
> > alone, and I believe are both good to have.
> 
> They looks good.

Cool, can I interpret that as an Acked-by for my v2? :)

> If you're worried about complicated paths - I'll add comment for
> *_next_slot() about that.

Yea, if we can document the exact ways in which we're protected from not
dereferencing a NULL 'slot', that would be great.  I think it essentially
boils down to:

1) For tagged iteration, if 'slot' is NULL then iter->tags must be cleared
2) For non-tagged iteration, it 'slot' is NULL then
   radix_tree_chunk_size(iter) must return 1 or less.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-nvdimm@ml01.01.org,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()
Date: Wed, 10 Aug 2016 08:52:06 -0600	[thread overview]
Message-ID: <20160810145206.GA17734@linux.intel.com> (raw)
In-Reply-To: <CALYGNiNwTXY2qQtx2nU9LjTiEYWwoHR63SnrkwUJpwgOLJPKSQ@mail.gmail.com>

On Wed, Aug 10, 2016 at 09:29:23AM +0300, Konstantin Khlebnikov wrote:
> On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler
> <ross.zwisler@linux.intel.com> wrote:
> > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote:
> > <>
> >> NAK. This is fast path and it's already bloated.
> >> I want to revert most changes here and rework "multiorder" entries.
> >>
> >> Here you can find almost ready patchset for that
> >> https://github.com/koct9i/linux/commits/radix-tree
> >
> > Okay...are you okay with the second 2 patches in the series?  They stand
> > alone, and I believe are both good to have.
> 
> They looks good.

Cool, can I interpret that as an Acked-by for my v2? :)

> If you're worried about complicated paths - I'll add comment for
> *_next_slot() about that.

Yea, if we can document the exact ways in which we're protected from not
dereferencing a NULL 'slot', that would be great.  I think it essentially
boils down to:

1) For tagged iteration, if 'slot' is NULL then iter->tags must be cleared
2) For non-tagged iteration, it 'slot' is NULL then
   radix_tree_chunk_size(iter) must return 1 or less.

  reply	other threads:[~2016-08-10 14:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 18:57 [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot() Ross Zwisler
2016-08-08 18:57 ` Ross Zwisler
2016-08-08 18:57 ` [PATCH 2/3] radix-tree tests: add iteration test Ross Zwisler
2016-08-08 18:57   ` Ross Zwisler
2016-08-08 18:57 ` [PATCH 3/3] radix-tree tests: properly initialize mutex Ross Zwisler
2016-08-08 18:57   ` Ross Zwisler
2016-08-08 19:21 ` [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot() Konstantin Khlebnikov
2016-08-08 19:21   ` Konstantin Khlebnikov
2016-08-09 15:27   ` Ross Zwisler
2016-08-09 15:27     ` Ross Zwisler
2016-08-10  6:29     ` Konstantin Khlebnikov
2016-08-10  6:29       ` Konstantin Khlebnikov
2016-08-10 14:52       ` Ross Zwisler [this message]
2016-08-10 14:52         ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810145206.GA17734@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=koct9i@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.