From: Petko Manolov <petkan@mip-labs.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ima-devel@lists.sourceforge.net"
<linux-ima-devel@lists.sourceforge.net>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [Linux-ima-devel] [PATCH 1/7] ima: on soft reboot, restore the measurement list
Date: Wed, 10 Aug 2016 18:48:49 +0300 [thread overview]
Message-ID: <20160810154849.GE4087@localhost> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D5F50F2BB@AcuExch.aculab.com>
On 16-08-10 14:40:13, David Laight wrote:
> From: Linuxppc-dev [mailto:linuxppc-dev-bounces+david.laight=aculab.com@lists.ozlabs.org] On Behalf Of
> > > > So given what you have above, you'd use something like:
> > > >
> > > > struct ima_kexec_hdr {
> > > > u16 version;
> > > > u16 _reserved0;
> > > > u32 _reserved1;
> > > > u64 buffer_size;
> > > > u64 count;
> > > > };
> > > >
> > > > cheers
> > >
> > > Thanks, I'll make this change.
> >
> > I would suggest:
> >
> > struct ima_kexec_hdr {
> > u64 buffer_size;
> > u64 count;
> > u16 version;
> > };
> >
> > and let the compiler add the proper padding, depending on the architecture. On
> > 32bit machine we'll have 4 bytes smaller allocations (compared to 64bit) while
> > retaining the same functionality.
>
> AAAArrrrgggg.....
>
> That doesn't work for 32bit applications on 64bit hosts.
Which part won't work?
> The extra bytes will make 0 difference to the allocation cost and lots to the
> processing.
An example?
Petko
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Petko Manolov <petkan@mip-labs.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-ima-devel@lists.sourceforge.net"
<linux-ima-devel@lists.sourceforge.net>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [Linux-ima-devel] [PATCH 1/7] ima: on soft reboot, restore the measurement list
Date: Wed, 10 Aug 2016 18:48:49 +0300 [thread overview]
Message-ID: <20160810154849.GE4087@localhost> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D5F50F2BB@AcuExch.aculab.com>
On 16-08-10 14:40:13, David Laight wrote:
> From: Linuxppc-dev [mailto:linuxppc-dev-bounces+david.laight=aculab.com@lists.ozlabs.org] On Behalf Of
> > > > So given what you have above, you'd use something like:
> > > >
> > > > struct ima_kexec_hdr {
> > > > u16 version;
> > > > u16 _reserved0;
> > > > u32 _reserved1;
> > > > u64 buffer_size;
> > > > u64 count;
> > > > };
> > > >
> > > > cheers
> > >
> > > Thanks, I'll make this change.
> >
> > I would suggest:
> >
> > struct ima_kexec_hdr {
> > u64 buffer_size;
> > u64 count;
> > u16 version;
> > };
> >
> > and let the compiler add the proper padding, depending on the architecture. On
> > 32bit machine we'll have 4 bytes smaller allocations (compared to 64bit) while
> > retaining the same functionality.
>
> AAAArrrrgggg.....
>
> That doesn't work for 32bit applications on 64bit hosts.
Which part won't work?
> The extra bytes will make 0 difference to the allocation cost and lots to the
> processing.
An example?
Petko
next prev parent reply other threads:[~2016-08-10 15:49 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 12:24 [PATCH 0/7] ima: carry the measurement list across kexec Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 1/7] ima: on soft reboot, restore the measurement list Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-05 8:44 ` Petko Manolov
2016-08-05 8:44 ` Petko Manolov
2016-08-05 13:34 ` Mimi Zohar
2016-08-05 13:34 ` Mimi Zohar
2016-08-05 15:56 ` Petko Manolov
2016-08-05 15:56 ` Petko Manolov
2016-08-09 10:59 ` Michael Ellerman
2016-08-09 10:59 ` Michael Ellerman
2016-08-09 13:01 ` Mimi Zohar
2016-08-09 13:01 ` Mimi Zohar
2016-08-09 13:19 ` Thiago Jung Bauermann
2016-08-09 13:19 ` Thiago Jung Bauermann
2016-08-09 13:35 ` David Laight
2016-08-09 13:35 ` David Laight
2016-08-09 13:35 ` David Laight
2016-08-09 14:02 ` Mimi Zohar
2016-08-09 14:02 ` Mimi Zohar
2016-08-09 13:55 ` Mimi Zohar
2016-08-09 13:55 ` Mimi Zohar
2016-08-09 14:06 ` Mimi Zohar
2016-08-09 14:06 ` Mimi Zohar
2016-08-09 23:13 ` Samuel Mendoza-Jonas
2016-08-09 23:13 ` Samuel Mendoza-Jonas
2016-08-10 3:41 ` Michael Ellerman
2016-08-10 3:41 ` Michael Ellerman
2016-08-10 5:05 ` Thiago Jung Bauermann
2016-08-10 5:05 ` Thiago Jung Bauermann
2016-08-10 9:52 ` Michael Ellerman
2016-08-10 9:52 ` Michael Ellerman
2016-08-10 12:54 ` Mimi Zohar
2016-08-10 12:54 ` Mimi Zohar
2016-08-10 14:32 ` [Linux-ima-devel] " Petko Manolov
2016-08-10 14:32 ` Petko Manolov
2016-08-10 14:40 ` David Laight
2016-08-10 14:40 ` David Laight
2016-08-10 14:40 ` David Laight
2016-08-10 15:48 ` Petko Manolov [this message]
2016-08-10 15:48 ` Petko Manolov
2016-08-04 12:24 ` [PATCH 2/7] ima: permit duplicate measurement list entries Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 3/7] ima: maintain memory size needed for serializing the measurement list Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 4/7] ima: serialize the binary_runtime_measurements Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 5/7] ima: on soft reboot, save the measurement list Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 6/7] ima: store the builtin/custom template definitions in a list Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-04 12:24 ` [PATCH 7/7] ima: support restoring multiple template formats Mimi Zohar
2016-08-04 12:24 ` Mimi Zohar
2016-08-09 5:19 ` [PATCH 0/7] ima: carry the measurement list across kexec Balbir Singh
2016-08-09 5:19 ` Balbir Singh
2016-08-09 12:36 ` Mimi Zohar
2016-08-09 12:36 ` Mimi Zohar
2016-08-11 7:38 ` Balbir Singh
2016-08-11 7:38 ` Balbir Singh
2016-08-11 11:25 ` Mimi Zohar
2016-08-11 11:25 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810154849.GE4087@localhost \
--to=petkan@mip-labs.com \
--cc=David.Laight@ACULAB.COM \
--cc=bauerman@linux.vnet.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.