All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"moderated list:TPM DEVICE DRIVER"
	<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: fix build error
Date: Wed, 10 Aug 2016 19:44:01 +0300	[thread overview]
Message-ID: <20160810164401.GA8952@intel.com> (raw)
In-Reply-To: <20160808202758.GA32391-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

I'm going to fold this tomorrow with 4d970e733b09.

/Jarkko

On Mon, Aug 08, 2016 at 11:27:58PM +0300, Jarkko Sakkinen wrote:
> As the fix is quite trivial I already pushed this fixup on tip of my
> master branch in order to make testing easy.
> 
> /Jarkko
> 
> On Mon, Aug 08, 2016 at 11:25:26PM +0300, Jarkko Sakkinen wrote:
> > tpm_getcap and tpm2_get_tpm_pt were not properly exported. This commit
> > adds the exports. The build error exist only in the master (bleeding
> > edge) branch so this problem does not concern 4.8 release.
> > 
> > The commit will be folded to 4d970e733b09 as soon as it is tested and
> > reviewed.
> > 
> > Fixes: 4d970e733b09
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > ---
> >  drivers/char/tpm/tpm-interface.c | 1 +
> >  drivers/char/tpm/tpm2-cmd.c      | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> > index ef5ad80..43ef0ef 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -458,6 +458,7 @@ ssize_t tpm_getcap(struct tpm_chip *chip, __be32 subcap_id, cap_t *cap,
> >  		*cap = tpm_cmd.params.getcap_out.cap;
> >  	return rc;
> >  }
> > +EXPORT_SYMBOL_GPL(tpm_getcap);
> >  
> >  #define TPM_ORD_STARTUP cpu_to_be32(153)
> >  #define TPM_ST_CLEAR cpu_to_be16(1)
> > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
> > index e1db404..499f405 100644
> > --- a/drivers/char/tpm/tpm2-cmd.c
> > +++ b/drivers/char/tpm/tpm2-cmd.c
> > @@ -707,6 +707,7 @@ ssize_t tpm2_get_tpm_pt(struct tpm_chip *chip, u32 property_id,  u32 *value,
> >  
> >  	return rc;
> >  }
> > +EXPORT_SYMBOL_GPL(tpm2_get_tpm_pt);
> >  
> >  #define TPM2_STARTUP_IN_SIZE \
> >  	(sizeof(struct tpm_input_header) + \
> > -- 
> > 2.7.4
> > 
> 
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are 
> consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
> J-Flow, sFlow and other flows. Make informed decisions using capacity 
> planning reports. http://sdm.link/zohodev2dev
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: linux-security-module@vger.kernel.org,
	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [tpmdd-devel] [PATCH] tpm: fix build error
Date: Wed, 10 Aug 2016 19:44:01 +0300	[thread overview]
Message-ID: <20160810164401.GA8952@intel.com> (raw)
In-Reply-To: <20160808202758.GA32391@intel.com>

I'm going to fold this tomorrow with 4d970e733b09.

/Jarkko

On Mon, Aug 08, 2016 at 11:27:58PM +0300, Jarkko Sakkinen wrote:
> As the fix is quite trivial I already pushed this fixup on tip of my
> master branch in order to make testing easy.
> 
> /Jarkko
> 
> On Mon, Aug 08, 2016 at 11:25:26PM +0300, Jarkko Sakkinen wrote:
> > tpm_getcap and tpm2_get_tpm_pt were not properly exported. This commit
> > adds the exports. The build error exist only in the master (bleeding
> > edge) branch so this problem does not concern 4.8 release.
> > 
> > The commit will be folded to 4d970e733b09 as soon as it is tested and
> > reviewed.
> > 
> > Fixes: 4d970e733b09
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > ---
> >  drivers/char/tpm/tpm-interface.c | 1 +
> >  drivers/char/tpm/tpm2-cmd.c      | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> > index ef5ad80..43ef0ef 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -458,6 +458,7 @@ ssize_t tpm_getcap(struct tpm_chip *chip, __be32 subcap_id, cap_t *cap,
> >  		*cap = tpm_cmd.params.getcap_out.cap;
> >  	return rc;
> >  }
> > +EXPORT_SYMBOL_GPL(tpm_getcap);
> >  
> >  #define TPM_ORD_STARTUP cpu_to_be32(153)
> >  #define TPM_ST_CLEAR cpu_to_be16(1)
> > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
> > index e1db404..499f405 100644
> > --- a/drivers/char/tpm/tpm2-cmd.c
> > +++ b/drivers/char/tpm/tpm2-cmd.c
> > @@ -707,6 +707,7 @@ ssize_t tpm2_get_tpm_pt(struct tpm_chip *chip, u32 property_id,  u32 *value,
> >  
> >  	return rc;
> >  }
> > +EXPORT_SYMBOL_GPL(tpm2_get_tpm_pt);
> >  
> >  #define TPM2_STARTUP_IN_SIZE \
> >  	(sizeof(struct tpm_input_header) + \
> > -- 
> > 2.7.4
> > 
> 
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are 
> consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
> J-Flow, sFlow and other flows. Make informed decisions using capacity 
> planning reports. http://sdm.link/zohodev2dev
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

  parent reply	other threads:[~2016-08-10 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 20:25 [PATCH] tpm: fix build error Jarkko Sakkinen
2016-08-08 20:25 ` Jarkko Sakkinen
2016-08-08 20:27 ` Jarkko Sakkinen
     [not found]   ` <20160808202758.GA32391-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-10 16:44     ` Jarkko Sakkinen [this message]
2016-08-10 16:44       ` [tpmdd-devel] " Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810164401.GA8952@intel.com \
    --to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peterhuewe-Mmb7MZpHnFY@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.