* [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive
@ 2016-08-09 0:30 Liang Li
2016-08-10 15:38 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Liang Li @ 2016-08-09 0:30 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, thuth, dgilbert, Liang Li
Since there in wrapper around madvise(), the virtio-balloon
code is able to work without the precompiled directive, the
directive can be removed.
Signed-off-by: Liang Li <liang.z.li@intel.com>
Suggested-by: Thomas Huth <thuth@redhat.com>
Reviewd-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/virtio/virtio-balloon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 5af429a..61325f2 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -34,13 +34,11 @@
static void balloon_page(void *addr, int deflate)
{
-#if defined(__linux__)
if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
kvm_has_sync_mmu())) {
qemu_madvise(addr, BALLOON_PAGE_SIZE,
deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
}
-#endif
}
static const char *balloon_stat_names[] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive
2016-08-09 0:30 [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive Liang Li
@ 2016-08-10 15:38 ` Michael S. Tsirkin
2016-08-11 0:34 ` Li, Liang Z
2016-09-29 10:57 ` Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2016-08-10 15:38 UTC (permalink / raw)
To: Liang Li; +Cc: qemu-devel, thuth, dgilbert
On Tue, Aug 09, 2016 at 08:30:42AM +0800, Liang Li wrote:
> Since there in wrapper around madvise(), the virtio-balloon
> code is able to work without the precompiled directive, the
> directive can be removed.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Reviewd-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Sorry about missing this earlier.
I'm inclined to merge this past 2.7 now.
Sorry about the delay.
Can you pls repost after 2.7 is out?
Thanks!
> ---
> hw/virtio/virtio-balloon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 5af429a..61325f2 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -34,13 +34,11 @@
>
> static void balloon_page(void *addr, int deflate)
> {
> -#if defined(__linux__)
> if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
> kvm_has_sync_mmu())) {
> qemu_madvise(addr, BALLOON_PAGE_SIZE,
> deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
> }
> -#endif
> }
>
> static const char *balloon_stat_names[] = {
> --
> 1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive
2016-08-10 15:38 ` Michael S. Tsirkin
@ 2016-08-11 0:34 ` Li, Liang Z
2016-09-29 10:57 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Li, Liang Z @ 2016-08-11 0:34 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel@nongnu.org, thuth@redhat.com, dgilbert@redhat.com
> On Tue, Aug 09, 2016 at 08:30:42AM +0800, Liang Li wrote:
> > Since there in wrapper around madvise(), the virtio-balloon code is
> > able to work without the precompiled directive, the directive can be
> > removed.
> >
> > Signed-off-by: Liang Li <liang.z.li@intel.com>
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Reviewd-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Sorry about missing this earlier.
> I'm inclined to merge this past 2.7 now.
> Sorry about the delay.
> Can you pls repost after 2.7 is out?
>
> Thanks!
Of course, I will repost then.
Liang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive
2016-08-10 15:38 ` Michael S. Tsirkin
2016-08-11 0:34 ` Li, Liang Z
@ 2016-09-29 10:57 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2016-09-29 10:57 UTC (permalink / raw)
To: Michael S. Tsirkin, Liang Li; +Cc: qemu-devel, dgilbert
On 10.08.2016 17:38, Michael S. Tsirkin wrote:
> On Tue, Aug 09, 2016 at 08:30:42AM +0800, Liang Li wrote:
>> Since there in wrapper around madvise(), the virtio-balloon
>> code is able to work without the precompiled directive, the
>> directive can be removed.
>>
>> Signed-off-by: Liang Li <liang.z.li@intel.com>
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> Reviewd-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Sorry about missing this earlier.
> I'm inclined to merge this past 2.7 now.
> Sorry about the delay.
> Can you pls repost after 2.7 is out?
>
> Thanks!
Ping?
>> ---
>> hw/virtio/virtio-balloon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>> index 5af429a..61325f2 100644
>> --- a/hw/virtio/virtio-balloon.c
>> +++ b/hw/virtio/virtio-balloon.c
>> @@ -34,13 +34,11 @@
>>
>> static void balloon_page(void *addr, int deflate)
>> {
>> -#if defined(__linux__)
>> if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
>> kvm_has_sync_mmu())) {
>> qemu_madvise(addr, BALLOON_PAGE_SIZE,
>> deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
>> }
>> -#endif
>> }
>>
>> static const char *balloon_stat_names[] = {
>> --
>> 1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-29 10:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-09 0:30 [Qemu-devel] [PATCH repost] virtio-balloon: Remove needless precompiled directive Liang Li
2016-08-10 15:38 ` Michael S. Tsirkin
2016-08-11 0:34 ` Li, Liang Z
2016-09-29 10:57 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.