All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Mathias Krause <minipli@googlemail.com>
Subject: [kernel-hardening] Re: [PATCH 2/2] arm: apply more __ro_after_init
Date: Thu, 11 Aug 2016 00:02:42 +0100	[thread overview]
Message-ID: <20160810230242.GO1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <2096112.OBiRuggdEi@wuerfel>

On Wed, Aug 10, 2016 at 09:31:05PM +0200, Arnd Bergmann wrote:
> On Wednesday, August 10, 2016 11:12:53 AM CEST Russell King - ARM Linux wrote:
> > There's the TLS emulation too, but that writes via the vectors mapping
> > at 0xffff0ff0.
> 
> Ok, so that should be safe. Can we change the fiq code to also use the
> high mapping and then take the __ro_after_init patch on top?

We can't - if the kernel is configured without the kuser helpers in
the vectors page, it's mapped read-only.  I'm not sure what the
intersection is between platforms that can have FIQs and platforms
that can disable the kuser helpers.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Mathias Krause <minipli@googlemail.com>
Subject: Re: [PATCH 2/2] arm: apply more __ro_after_init
Date: Thu, 11 Aug 2016 00:02:42 +0100	[thread overview]
Message-ID: <20160810230242.GO1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <2096112.OBiRuggdEi@wuerfel>

On Wed, Aug 10, 2016 at 09:31:05PM +0200, Arnd Bergmann wrote:
> On Wednesday, August 10, 2016 11:12:53 AM CEST Russell King - ARM Linux wrote:
> > There's the TLS emulation too, but that writes via the vectors mapping
> > at 0xffff0ff0.
> 
> Ok, so that should be safe. Can we change the fiq code to also use the
> high mapping and then take the __ro_after_init patch on top?

We can't - if the kernel is configured without the kuser helpers in
the vectors page, it's mapped read-only.  I'm not sure what the
intersection is between platforms that can have FIQs and platforms
that can disable the kuser helpers.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: apply more __ro_after_init
Date: Thu, 11 Aug 2016 00:02:42 +0100	[thread overview]
Message-ID: <20160810230242.GO1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <2096112.OBiRuggdEi@wuerfel>

On Wed, Aug 10, 2016 at 09:31:05PM +0200, Arnd Bergmann wrote:
> On Wednesday, August 10, 2016 11:12:53 AM CEST Russell King - ARM Linux wrote:
> > There's the TLS emulation too, but that writes via the vectors mapping
> > at 0xffff0ff0.
> 
> Ok, so that should be safe. Can we change the fiq code to also use the
> high mapping and then take the __ro_after_init patch on top?

We can't - if the kernel is configured without the kuser helpers in
the vectors page, it's mapped read-only.  I'm not sure what the
intersection is between platforms that can have FIQs and platforms
that can disable the kuser helpers.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2016-08-10 23:02 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 18:40 [kernel-hardening] [PATCH 0/2] expand use of __ro_after_init Kees Cook
2016-06-03 18:40 ` Kees Cook
2016-06-03 18:40 ` Kees Cook
2016-06-03 18:40 ` [kernel-hardening] [PATCH 1/2] x86: apply more __ro_after_init and const Kees Cook
2016-06-03 18:40   ` Kees Cook
2016-06-03 18:40   ` Kees Cook
2016-06-03 18:40 ` [kernel-hardening] [PATCH 2/2] arm: apply more __ro_after_init Kees Cook
2016-06-03 18:40   ` Kees Cook
2016-06-03 18:40   ` Kees Cook
2016-06-03 18:51   ` [kernel-hardening] " Greg KH
2016-06-03 18:51     ` Greg KH
2016-06-03 21:26     ` Kees Cook
2016-06-03 21:26       ` Kees Cook
2016-06-03 21:26       ` Kees Cook
2016-06-03 21:54       ` [kernel-hardening] " Greg KH
2016-06-03 21:54         ` Greg KH
2016-06-03 22:01         ` Kees Cook
2016-06-03 22:01           ` Kees Cook
2016-06-03 22:01           ` Kees Cook
2016-08-10  9:43   ` [kernel-hardening] " Russell King - ARM Linux
2016-08-10  9:43     ` Russell King - ARM Linux
2016-08-10  9:43     ` Russell King - ARM Linux
2016-08-10 10:00     ` [kernel-hardening] " Arnd Bergmann
2016-08-10 10:00       ` Arnd Bergmann
2016-08-10 10:00       ` Arnd Bergmann
2016-08-10 10:12       ` [kernel-hardening] " Russell King - ARM Linux
2016-08-10 10:12         ` Russell King - ARM Linux
2016-08-10 10:12         ` Russell King - ARM Linux
2016-08-10 19:31         ` [kernel-hardening] " Arnd Bergmann
2016-08-10 19:31           ` Arnd Bergmann
2016-08-10 19:31           ` Arnd Bergmann
2016-08-10 23:02           ` Russell King - ARM Linux [this message]
2016-08-10 23:02             ` Russell King - ARM Linux
2016-08-10 23:02             ` Russell King - ARM Linux
2016-08-11 16:02             ` [kernel-hardening] " Arnd Bergmann
2016-08-11 16:02               ` Arnd Bergmann
2016-08-11 16:02               ` Arnd Bergmann
2016-08-11 16:02               ` Arnd Bergmann
2016-08-11 16:02               ` Arnd Bergmann
2016-08-12 11:34               ` [kernel-hardening] " Daniel Thompson
2016-08-12 11:34                 ` Daniel Thompson
2016-08-12 11:34                 ` Daniel Thompson
2016-08-12 11:34                 ` Daniel Thompson
2016-08-10 17:06     ` [kernel-hardening] " Daniel Micay
2016-08-10 17:06       ` Daniel Micay
2016-08-10 17:06       ` Daniel Micay
2016-08-10 18:32     ` [kernel-hardening] " Kees Cook
2016-08-10 18:32       ` Kees Cook
2016-08-10 18:32       ` Kees Cook
2016-08-10 19:41       ` [kernel-hardening] " Arnd Bergmann
2016-08-10 19:41         ` Arnd Bergmann
2016-08-10 19:41         ` Arnd Bergmann
2016-08-10 21:40         ` [kernel-hardening] " Kees Cook
2016-08-10 21:40           ` Kees Cook
2016-08-10 21:40           ` Kees Cook
2016-08-10 23:06         ` [kernel-hardening] " Russell King - ARM Linux
2016-08-10 23:06           ` Russell King - ARM Linux
2016-08-10 23:06           ` Russell King - ARM Linux
2016-08-11 15:54           ` [kernel-hardening] " Arnd Bergmann
2016-08-11 15:54             ` Arnd Bergmann
2016-08-11 15:54             ` Arnd Bergmann
2016-08-11 22:16             ` [kernel-hardening] " Kees Cook
2016-08-11 22:16               ` Kees Cook
2016-08-11 22:16               ` Kees Cook
2016-08-12 16:24             ` [kernel-hardening] " Russell King - ARM Linux
2016-08-12 16:24               ` Russell King - ARM Linux
2016-08-12 16:24               ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810230242.GO1041@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minipli@googlemail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.