From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: rjw@rjwysocki.net, daniel.lezcano@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ARM: cpuidle: Fix error return code
Date: Thu, 11 Aug 2016 13:39:02 +0000 [thread overview]
Message-ID: <20160811133902.GC26202@red-moon> (raw)
In-Reply-To: <1470920550-21625-1-git-send-email-christophe.jaillet@wanadoo.fr>
On Thu, Aug 11, 2016 at 03:02:30PM +0200, Christophe JAILLET wrote:
> We know that 'ret = 0' because it has been tested a few lines above.
> So, if 'kzalloc' fails, 0 will be returned instead of an error code.
> Return -ENOMEM instead.
>
> Fixes: a0d46a3dfdc3 ("ARM: cpuidle: Register per cpuidle device")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/cpuidle/cpuidle-arm.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: rjw@rjwysocki.net, daniel.lezcano@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ARM: cpuidle: Fix error return code
Date: Thu, 11 Aug 2016 14:39:02 +0100 [thread overview]
Message-ID: <20160811133902.GC26202@red-moon> (raw)
In-Reply-To: <1470920550-21625-1-git-send-email-christophe.jaillet@wanadoo.fr>
On Thu, Aug 11, 2016 at 03:02:30PM +0200, Christophe JAILLET wrote:
> We know that 'ret = 0' because it has been tested a few lines above.
> So, if 'kzalloc' fails, 0 will be returned instead of an error code.
> Return -ENOMEM instead.
>
> Fixes: a0d46a3dfdc3 ("ARM: cpuidle: Register per cpuidle device")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/cpuidle/cpuidle-arm.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
next prev parent reply other threads:[~2016-08-11 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 13:02 [PATCH] ARM: cpuidle: Fix error return code Christophe JAILLET
2016-08-11 13:02 ` Christophe JAILLET
2016-08-11 13:39 ` Lorenzo Pieralisi [this message]
2016-08-11 13:39 ` Lorenzo Pieralisi
2016-08-17 14:16 ` Daniel Lezcano
2016-08-17 14:16 ` Daniel Lezcano
2016-08-18 1:13 ` Rafael J. Wysocki
2016-08-18 1:13 ` Rafael J. Wysocki
2016-08-18 7:55 ` Daniel Lezcano
2016-08-18 7:55 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811133902.GC26202@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.