From: Peter Zijlstra <peterz@infradead.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-arch@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
Chris Metcalf <cmetcalf@mellanox.com>,
x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Aaron Tomlin <atomlin@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Thu, 11 Aug 2016 17:36:45 +0200 [thread overview]
Message-ID: <20160811153645.GX30192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160811152538.GH13300@pathway.suse.cz>
On Thu, Aug 11, 2016 at 05:25:38PM +0200, Petr Mladek wrote:
> diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
> index b77f5edb03b0..e31d50acd491 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -44,7 +44,7 @@ static inline void native_irq_enable(void)
> asm volatile("sti": : :"memory");
> }
>
> -static inline void native_safe_halt(void)
> +static inline __attribute__((__section__(".cpuidle.text"))) void native_safe_halt(void)
> {
> asm volatile("sti; hlt": : :"memory");
> }
An alternative is to use __always_inline I suppose.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Aaron Tomlin <atomlin@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@osdl.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v7 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Thu, 11 Aug 2016 17:36:45 +0200 [thread overview]
Message-ID: <20160811153645.GX30192@twins.programming.kicks-ass.net> (raw)
Message-ID: <20160811153645.aUuOTbP86ty4W0qwFQhI8FuB2OWJ9n0RAZhfhv-DJ1U@z> (raw)
In-Reply-To: <20160811152538.GH13300@pathway.suse.cz>
On Thu, Aug 11, 2016 at 05:25:38PM +0200, Petr Mladek wrote:
> diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
> index b77f5edb03b0..e31d50acd491 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -44,7 +44,7 @@ static inline void native_irq_enable(void)
> asm volatile("sti": : :"memory");
> }
>
> -static inline void native_safe_halt(void)
> +static inline __attribute__((__section__(".cpuidle.text"))) void native_safe_halt(void)
> {
> asm volatile("sti; hlt": : :"memory");
> }
An alternative is to use __always_inline I suppose.
WARNING: multiple messages have this Message-ID (diff)
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Thu, 11 Aug 2016 17:36:45 +0200 [thread overview]
Message-ID: <20160811153645.GX30192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160811152538.GH13300@pathway.suse.cz>
On Thu, Aug 11, 2016 at 05:25:38PM +0200, Petr Mladek wrote:
> diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
> index b77f5edb03b0..e31d50acd491 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -44,7 +44,7 @@ static inline void native_irq_enable(void)
> asm volatile("sti": : :"memory");
> }
>
> -static inline void native_safe_halt(void)
> +static inline __attribute__((__section__(".cpuidle.text"))) void native_safe_halt(void)
> {
> asm volatile("sti; hlt": : :"memory");
> }
An alternative is to use __always_inline I suppose.
next prev parent reply other threads:[~2016-08-11 15:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:03 [PATCH v7 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-08-08 16:03 ` Chris Metcalf
2016-08-08 16:03 ` Chris Metcalf
2016-08-08 16:03 ` Chris Metcalf
2016-08-08 16:03 ` [PATCH v7 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-08-08 16:03 ` Chris Metcalf
2016-08-09 12:35 ` Petr Mladek
2016-08-09 12:35 ` Petr Mladek
2016-08-08 16:03 ` [PATCH v7 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-08-08 16:03 ` Chris Metcalf
2016-08-09 12:37 ` Petr Mladek
2016-08-09 12:37 ` Petr Mladek
2016-08-08 16:03 ` [PATCH v7 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-08-08 16:03 ` [PATCH v7 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-08-08 16:03 ` Chris Metcalf
2016-08-08 16:48 ` Mark Rutland
2016-08-08 16:48 ` Mark Rutland
2016-08-08 16:48 ` Mark Rutland
2016-08-08 16:48 ` Mark Rutland
2016-08-09 10:37 ` Lorenzo Pieralisi
2016-08-09 10:37 ` Lorenzo Pieralisi
2016-08-09 13:25 ` Chris Metcalf
2016-08-09 13:25 ` Chris Metcalf
2016-08-09 13:25 ` Chris Metcalf
2016-08-09 13:25 ` Chris Metcalf
2016-08-09 12:43 ` Petr Mladek
2016-08-09 12:43 ` Petr Mladek
2016-08-09 16:43 ` Chris Metcalf
2016-08-09 16:43 ` Chris Metcalf
2016-08-09 16:43 ` Chris Metcalf
2016-08-09 16:43 ` Chris Metcalf
2016-08-11 15:25 ` Petr Mladek
2016-08-11 15:25 ` Petr Mladek
2016-08-11 15:36 ` Peter Zijlstra [this message]
2016-08-11 15:36 ` Peter Zijlstra
2016-08-11 15:36 ` Peter Zijlstra
2016-08-15 16:41 ` Chris Metcalf
2016-08-15 16:41 ` Chris Metcalf
2016-08-15 16:41 ` Chris Metcalf
2016-08-15 16:41 ` Chris Metcalf
2016-08-16 8:04 ` Petr Mladek
2016-08-16 8:04 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811153645.GX30192@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@osdl.org \
--cc=atomlin@redhat.com \
--cc=cmetcalf@mellanox.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.