From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
"ohad@wizery.com" <ohad@wizery.com>,
"kernel@stlinux.com" <kernel@stlinux.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"patrice.chotard@st.com" <patrice.chotard@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ludovic.barre@st.com" <ludovic.barre@st.com>,
"ssantosh@kernel.org" <ssantosh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH 1/2] remoteproc: core: Add rproc OF look-up functions
Date: Thu, 11 Aug 2016 11:23:25 -0700 [thread overview]
Message-ID: <20160811182325.GY26240@tuxbot> (raw)
In-Reply-To: <b1a01567-7a5d-20de-a2b5-b673b9ce67ec@ti.com>
On Wed 10 Aug 15:44 PDT 2016, Suman Anna wrote:
> On 08/10/2016 04:19 PM, Bjorn Andersson wrote:
> > On Wed 10 Aug 14:04 PDT 2016, Suman Anna wrote:
> >
[..]
> > As far as cleaning up wkup_m3_ipc, patch 2 does that and cleans out the
> > old implementation and with that wkup_m3_ipc is moved to the new API.
> >
> > So the only issue is that the wkup_m3_ipc DT binding states that the
> > property should be named "ti,rproc" and as such someone has to send a
> > patch to that and make an argument that we don't have to maintain
> > backwards compatibility. But as this is used in am33xx.dtsi and
> > am4372.dtsi that might be too late?
>
> I could fix up the wkup_m3_ipc driver using of_update_property() /
> of_remove_property(), but looks like these are not exported. I am not
> sure if there are any specific reasons as to why these were not
> exported. So, for now, we may have to go with the current code.
>
Sorry I didn't think that far, that would be the preferred solution.
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] remoteproc: core: Add rproc OF look-up functions
Date: Thu, 11 Aug 2016 11:23:25 -0700 [thread overview]
Message-ID: <20160811182325.GY26240@tuxbot> (raw)
In-Reply-To: <b1a01567-7a5d-20de-a2b5-b673b9ce67ec@ti.com>
On Wed 10 Aug 15:44 PDT 2016, Suman Anna wrote:
> On 08/10/2016 04:19 PM, Bjorn Andersson wrote:
> > On Wed 10 Aug 14:04 PDT 2016, Suman Anna wrote:
> >
[..]
> > As far as cleaning up wkup_m3_ipc, patch 2 does that and cleans out the
> > old implementation and with that wkup_m3_ipc is moved to the new API.
> >
> > So the only issue is that the wkup_m3_ipc DT binding states that the
> > property should be named "ti,rproc" and as such someone has to send a
> > patch to that and make an argument that we don't have to maintain
> > backwards compatibility. But as this is used in am33xx.dtsi and
> > am4372.dtsi that might be too late?
>
> I could fix up the wkup_m3_ipc driver using of_update_property() /
> of_remove_property(), but looks like these are not exported. I am not
> sure if there are any specific reasons as to why these were not
> exported. So, for now, we may have to go with the current code.
>
Sorry I didn't think that far, that would be the preferred solution.
Regards,
Bjorn
next prev parent reply other threads:[~2016-08-11 18:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 15:49 [PATCH 1/2] remoteproc: core: Add rproc OF look-up functions Lee Jones
2016-07-19 15:49 ` Lee Jones
2016-07-19 15:49 ` [PATCH 2/2] remoteproc: core: Rework obtaining a rproc from a DT phandle Lee Jones
2016-07-19 15:49 ` Lee Jones
2016-08-10 17:15 ` Bjorn Andersson
2016-08-10 17:15 ` Bjorn Andersson
2016-08-10 18:27 ` Santosh Shilimkar
2016-08-10 18:27 ` Santosh Shilimkar
2016-08-10 20:31 ` Bjorn Andersson
2016-08-10 20:31 ` Bjorn Andersson
2016-08-11 18:40 ` Bjorn Andersson
2016-08-11 18:40 ` Bjorn Andersson
2016-08-10 17:40 ` [PATCH 1/2] remoteproc: core: Add rproc OF look-up functions Bjorn Andersson
2016-08-10 17:40 ` Bjorn Andersson
2016-08-10 19:37 ` Suman Anna
2016-08-10 19:37 ` Suman Anna
2016-08-10 20:40 ` Bjorn Andersson
2016-08-10 20:40 ` Bjorn Andersson
2016-08-10 21:04 ` Suman Anna
2016-08-10 21:04 ` Suman Anna
2016-08-10 21:19 ` Bjorn Andersson
2016-08-10 21:19 ` Bjorn Andersson
2016-08-10 22:44 ` Suman Anna
2016-08-10 22:44 ` Suman Anna
2016-08-11 7:31 ` Lee Jones
2016-08-11 7:31 ` Lee Jones
2016-08-11 16:04 ` Suman Anna
2016-08-11 16:04 ` Suman Anna
2016-08-11 16:23 ` Suman Anna
2016-08-11 16:23 ` Suman Anna
2016-08-12 16:37 ` Suman Anna
2016-08-12 16:37 ` Suman Anna
2016-08-12 18:07 ` Bjorn Andersson
2016-08-12 18:07 ` Bjorn Andersson
2016-08-12 18:45 ` Suman Anna
2016-08-12 18:45 ` Suman Anna
2016-08-15 13:55 ` Lee Jones
2016-08-15 13:55 ` Lee Jones
2016-08-11 18:23 ` Bjorn Andersson [this message]
2016-08-11 18:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811182325.GY26240@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=d-gerlach@ti.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.