From: Stephen Boyd <sboyd@codeaurora.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>,
Michael Turquette <mturquette@baylibre.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-clk@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH] clk: imx7d: do not set the parent of IMX7D_ENET_AXI_ROOT_SRC
Date: Thu, 11 Aug 2016 18:45:19 -0700 [thread overview]
Message-ID: <20160812014519.GO2996@codeaurora.org> (raw)
In-Reply-To: <CAOMZO5AYVbobwxyNippO_AviZhNjCS0hhC2NmLHiPEt8MoP-5Q@mail.gmail.com>
On 08/11, Fabio Estevam wrote:
> Hi Stefan,
>
> On Thu, Aug 11, 2016 at 8:57 PM, Stefan Agner <stefan@agner.ch> wrote:
>
> > I don't think so, at least not that root clock.
> >
> > Otherwise grep -e IMX7D_PLL_ENET_MAIN_250M_CLK arch/arm/boot/dts/imx7*
> > should return something...
>
> Yes, you are right. The enet root clock parent assignment is missing in dts.
>
> Other enet clocks are assigned.
>
> > I guess in practice it is not a problem because the boot loader
> > configures the clock selection already. Still, I think we should also
> > fix our device trees and select the root clock there...
>
> Yes, I didn't see any error on mx7d-sdb when I tested this patch, but
> to be on the safe side I will update all the mx7 fec users to assign
> enet root clk in the dts.
>
Ok it sounds like this isn't urgent for fixes. I'll go ahead and
queue it up for v4.9
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: imx7d: do not set the parent of IMX7D_ENET_AXI_ROOT_SRC
Date: Thu, 11 Aug 2016 18:45:19 -0700 [thread overview]
Message-ID: <20160812014519.GO2996@codeaurora.org> (raw)
In-Reply-To: <CAOMZO5AYVbobwxyNippO_AviZhNjCS0hhC2NmLHiPEt8MoP-5Q@mail.gmail.com>
On 08/11, Fabio Estevam wrote:
> Hi Stefan,
>
> On Thu, Aug 11, 2016 at 8:57 PM, Stefan Agner <stefan@agner.ch> wrote:
>
> > I don't think so, at least not that root clock.
> >
> > Otherwise grep -e IMX7D_PLL_ENET_MAIN_250M_CLK arch/arm/boot/dts/imx7*
> > should return something...
>
> Yes, you are right. The enet root clock parent assignment is missing in dts.
>
> Other enet clocks are assigned.
>
> > I guess in practice it is not a problem because the boot loader
> > configures the clock selection already. Still, I think we should also
> > fix our device trees and select the root clock there...
>
> Yes, I didn't see any error on mx7d-sdb when I tested this patch, but
> to be on the safe side I will update all the mx7 fec users to assign
> enet root clk in the dts.
>
Ok it sounds like this isn't urgent for fixes. I'll go ahead and
queue it up for v4.9
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-12 1:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 13:53 [PATCH] clk: imx7d: do not set the parent of IMX7D_ENET_AXI_ROOT_SRC Fabio Estevam
2016-07-15 13:53 ` Fabio Estevam
2016-08-10 11:37 ` Fabio Estevam
2016-08-10 11:37 ` Fabio Estevam
2016-08-11 22:28 ` Stephen Boyd
2016-08-11 22:28 ` Stephen Boyd
2016-08-11 23:53 ` Fabio Estevam
2016-08-11 23:53 ` Fabio Estevam
2016-08-11 23:57 ` Stefan Agner
2016-08-11 23:57 ` Stefan Agner
2016-08-12 1:35 ` Fabio Estevam
2016-08-12 1:35 ` Fabio Estevam
2016-08-12 1:45 ` Stephen Boyd [this message]
2016-08-12 1:45 ` Stephen Boyd
2016-08-12 1:47 ` Fabio Estevam
2016-08-12 1:47 ` Fabio Estevam
2016-08-13 0:57 ` Stephen Boyd
2016-08-13 0:57 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812014519.GO2996@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.