* [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip
@ 2016-08-12 18:14 Eduardo Habkost
2016-08-12 18:16 ` [Qemu-devel] [PATCH for-2.7] " Eduardo Habkost
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eduardo Habkost @ 2016-08-12 18:14 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: Andrew Jones, Peter Xu, Radim Krčmář
The kvm_pv_unhalt feature doesn't work if kernel_irqchip is
disabled, so we need to report it as unsupported.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/kvm.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 0b2016a..d1a25c5 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -329,6 +329,13 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
*/
cpuid_1_edx = kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX);
ret |= cpuid_1_edx & CPUID_EXT2_AMD_ALIASES;
+ } else if (function == KVM_CPUID_FEATURES && reg == R_EAX) {
+ /* kvm_pv_unhalt is reported by GET_SUPPORTED_CPUID, but it can't
+ * be enabled without the in-kernel irqchip
+ */
+ if (!kvm_irqchip_in_kernel()) {
+ ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
+ }
}
/* fallback for older kernels */
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.7] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip
2016-08-12 18:14 [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip Eduardo Habkost
@ 2016-08-12 18:16 ` Eduardo Habkost
2016-08-12 18:24 ` [Qemu-devel] [PATCH] " Andrew Jones
2016-08-15 7:34 ` Peter Xu
2 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2016-08-12 18:16 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: Andrew Jones, Peter Xu, Radim Krčmář
Sorry, forgot the for-2.7 tag in the Subject. This is a bug fix I
would like to get into QEMU 2.7.
On Fri, Aug 12, 2016 at 03:14:32PM -0300, Eduardo Habkost wrote:
> The kvm_pv_unhalt feature doesn't work if kernel_irqchip is
> disabled, so we need to report it as unsupported.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/kvm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 0b2016a..d1a25c5 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -329,6 +329,13 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
> */
> cpuid_1_edx = kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX);
> ret |= cpuid_1_edx & CPUID_EXT2_AMD_ALIASES;
> + } else if (function == KVM_CPUID_FEATURES && reg == R_EAX) {
> + /* kvm_pv_unhalt is reported by GET_SUPPORTED_CPUID, but it can't
> + * be enabled without the in-kernel irqchip
> + */
> + if (!kvm_irqchip_in_kernel()) {
> + ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
> + }
> }
>
> /* fallback for older kernels */
> --
> 2.7.4
>
--
Eduardo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip
2016-08-12 18:14 [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip Eduardo Habkost
2016-08-12 18:16 ` [Qemu-devel] [PATCH for-2.7] " Eduardo Habkost
@ 2016-08-12 18:24 ` Andrew Jones
2016-08-15 7:34 ` Peter Xu
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Jones @ 2016-08-12 18:24 UTC (permalink / raw)
To: Eduardo Habkost
Cc: qemu-devel, Paolo Bonzini, Peter Xu, Radim Krčmář
On Fri, Aug 12, 2016 at 03:14:32PM -0300, Eduardo Habkost wrote:
> The kvm_pv_unhalt feature doesn't work if kernel_irqchip is
> disabled, so we need to report it as unsupported.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/kvm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Andrew Jones <drjones@redhat.com>
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 0b2016a..d1a25c5 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -329,6 +329,13 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function,
> */
> cpuid_1_edx = kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX);
> ret |= cpuid_1_edx & CPUID_EXT2_AMD_ALIASES;
> + } else if (function == KVM_CPUID_FEATURES && reg == R_EAX) {
> + /* kvm_pv_unhalt is reported by GET_SUPPORTED_CPUID, but it can't
> + * be enabled without the in-kernel irqchip
> + */
> + if (!kvm_irqchip_in_kernel()) {
> + ret &= ~(1U << KVM_FEATURE_PV_UNHALT);
> + }
> }
>
> /* fallback for older kernels */
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip
2016-08-12 18:14 [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip Eduardo Habkost
2016-08-12 18:16 ` [Qemu-devel] [PATCH for-2.7] " Eduardo Habkost
2016-08-12 18:24 ` [Qemu-devel] [PATCH] " Andrew Jones
@ 2016-08-15 7:34 ` Peter Xu
2 siblings, 0 replies; 4+ messages in thread
From: Peter Xu @ 2016-08-15 7:34 UTC (permalink / raw)
To: Eduardo Habkost
Cc: qemu-devel, Paolo Bonzini, Andrew Jones,
Radim Krčmář
On Fri, Aug 12, 2016 at 03:14:32PM -0300, Eduardo Habkost wrote:
> The kvm_pv_unhalt feature doesn't work if kernel_irqchip is
> disabled, so we need to report it as unsupported.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Tested-by: Peter Xu <peterx@redhat.com>
-- peterx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-15 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-12 18:14 [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip Eduardo Habkost
2016-08-12 18:16 ` [Qemu-devel] [PATCH for-2.7] " Eduardo Habkost
2016-08-12 18:24 ` [Qemu-devel] [PATCH] " Andrew Jones
2016-08-15 7:34 ` Peter Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.