All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects
Date: Mon, 15 Aug 2016 10:07:55 +0100	[thread overview]
Message-ID: <20160815090755.GA1426@svinekod> (raw)
In-Reply-To: <20160815145303.71628c8b@xhacker>

Hi,

On Mon, Aug 15, 2016 at 02:53:03PM +0800, Jisheng Zhang wrote:
> On Fri, 12 Aug 2016 13:43:45 +0100 Mark Rutland wrote:
> > On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote:
> > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> > > index 10ad8ab..c1ff7c2 100644
> > > --- a/arch/arm64/kernel/vdso.c
> > > +++ b/arch/arm64/kernel/vdso.c
> > > @@ -19,6 +19,7 @@
> > >   */
> > >  
> > >  #include <linux/kernel.h>
> > > +#include <linux/cache.h>
> > >  #include <linux/clocksource.h>
> > >  #include <linux/elf.h>
> > >  #include <linux/err.h>  
> > 
> > Nit: Could you please sort this list? Everything but <linux/kernel.h> is
> > already in order.

[...]

> Thanks a lot, all comments are addressed in v4.
> 
> the headers in vdso.c is sorted now. However, the headers in mmu.c,
> dma-mapping.c, init.c aren't, for I dunno whether it's acceptable
> to do so. Or we could add one separate patch to make them sorted before
> applying __ro_after_init

Ah. Given that's a little messy, it's probably not worthwhile sorting them.
Further, feel free to not bother sorting the vdso.c includes.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	lorenzo.pieralisi@arm.com, keescook@chromium.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: apply __ro_after_init to some objects
Date: Mon, 15 Aug 2016 10:07:55 +0100	[thread overview]
Message-ID: <20160815090755.GA1426@svinekod> (raw)
In-Reply-To: <20160815145303.71628c8b@xhacker>

Hi,

On Mon, Aug 15, 2016 at 02:53:03PM +0800, Jisheng Zhang wrote:
> On Fri, 12 Aug 2016 13:43:45 +0100 Mark Rutland wrote:
> > On Fri, Aug 12, 2016 at 04:01:11PM +0800, Jisheng Zhang wrote:
> > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> > > index 10ad8ab..c1ff7c2 100644
> > > --- a/arch/arm64/kernel/vdso.c
> > > +++ b/arch/arm64/kernel/vdso.c
> > > @@ -19,6 +19,7 @@
> > >   */
> > >  
> > >  #include <linux/kernel.h>
> > > +#include <linux/cache.h>
> > >  #include <linux/clocksource.h>
> > >  #include <linux/elf.h>
> > >  #include <linux/err.h>  
> > 
> > Nit: Could you please sort this list? Everything but <linux/kernel.h> is
> > already in order.

[...]

> Thanks a lot, all comments are addressed in v4.
> 
> the headers in vdso.c is sorted now. However, the headers in mmu.c,
> dma-mapping.c, init.c aren't, for I dunno whether it's acceptable
> to do so. Or we could add one separate patch to make them sorted before
> applying __ro_after_init

Ah. Given that's a little messy, it's probably not worthwhile sorting them.
Further, feel free to not bother sorting the vdso.c includes.

Thanks,
Mark.

  reply	other threads:[~2016-08-15  9:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  8:01 [PATCH v3 0/4] arm64: put objects into proper sections Jisheng Zhang
2016-08-12  8:01 ` Jisheng Zhang
2016-08-12  8:01 ` [PATCH v3 1/4] arm64: vdso: add __init section marker to alloc_vectors_page Jisheng Zhang
2016-08-12  8:01   ` Jisheng Zhang
2016-08-12  8:01 ` [PATCH v3 2/4] arm64: vdso: constify vm_special_mapping used for aarch32 vectors page Jisheng Zhang
2016-08-12  8:01   ` Jisheng Zhang
2016-08-12  8:01 ` [PATCH v3 3/4] arm64: kaslr: Fix incorrect placement of __initdata and __read_mostly Jisheng Zhang
2016-08-12  8:01   ` Jisheng Zhang
2016-08-12 12:02   ` Ard Biesheuvel
2016-08-12 12:02     ` Ard Biesheuvel
2016-08-15  4:52     ` Jisheng Zhang
2016-08-15  4:52       ` Jisheng Zhang
2016-08-15  5:57       ` Jisheng Zhang
2016-08-15  5:57         ` Jisheng Zhang
2016-08-15  6:30         ` Ard Biesheuvel
2016-08-15  6:30           ` Ard Biesheuvel
2016-08-12  8:01 ` [PATCH v3 4/4] arm64: apply __ro_after_init to some objects Jisheng Zhang
2016-08-12  8:01   ` Jisheng Zhang
2016-08-12 12:43   ` Mark Rutland
2016-08-12 12:43     ` Mark Rutland
2016-08-15  6:53     ` Jisheng Zhang
2016-08-15  6:53       ` Jisheng Zhang
2016-08-15  9:07       ` Mark Rutland [this message]
2016-08-15  9:07         ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160815090755.GA1426@svinekod \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.