From: Stephen Boyd <sboyd@codeaurora.org>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Erin Lo <erin.lo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>, John Crispin <blogic@openwrt.org>,
Arnd Bergmann <arnd@arndb.de>,
Sascha Hauer <kernel@pengutronix.de>,
Daniel Kurtz <djkurtz@chromium.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-clk@vger.kernel.org, srv_heupstream@mediatek.com,
Shunli Wang <shunli.wang@mediatek.com>
Subject: Re: [PATCH v9 06/10] clk: mediatek: Add MT2701 clock support
Date: Mon, 15 Aug 2016 11:16:04 -0700 [thread overview]
Message-ID: <20160815181604.GU361@codeaurora.org> (raw)
In-Reply-To: <1471230034.8551.22.camel@mtksdaap41>
On 08/15, James Liao wrote:
> On Fri, 2016-08-12 at 17:44 -0700, Stephen Boyd wrote:
> > On 06/22, Erin Lo wrote:
> > > +
> > > +static void mtk_bdpsys_init(struct device_node *node)
> > > +{
> > > + struct clk_onecell_data *clk_data;
> > > + int r;
> > > +
> > > + clk_data = mtk_alloc_clk_data(CLK_BDP_NR);
> > > +
> > > + mtk_clk_register_gates(node, bdp_clks, ARRAY_SIZE(bdp_clks),
> > > + clk_data);
> > > +
> > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> >
> > Is it possible to move to of_clk_add_hw_provider()? It can be
> > done later if that would mean changing all
> > mtk_clk_register_gates() users.
>
> I would like to keep current implementation due to test/integration
> effort. I prefer to apply clk_hw related APIs on new clk drivers instead
> of modify existing drivers.
>
Sure, no problem.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 06/10] clk: mediatek: Add MT2701 clock support
Date: Mon, 15 Aug 2016 11:16:04 -0700 [thread overview]
Message-ID: <20160815181604.GU361@codeaurora.org> (raw)
In-Reply-To: <1471230034.8551.22.camel@mtksdaap41>
On 08/15, James Liao wrote:
> On Fri, 2016-08-12 at 17:44 -0700, Stephen Boyd wrote:
> > On 06/22, Erin Lo wrote:
> > > +
> > > +static void mtk_bdpsys_init(struct device_node *node)
> > > +{
> > > + struct clk_onecell_data *clk_data;
> > > + int r;
> > > +
> > > + clk_data = mtk_alloc_clk_data(CLK_BDP_NR);
> > > +
> > > + mtk_clk_register_gates(node, bdp_clks, ARRAY_SIZE(bdp_clks),
> > > + clk_data);
> > > +
> > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> >
> > Is it possible to move to of_clk_add_hw_provider()? It can be
> > done later if that would mean changing all
> > mtk_clk_register_gates() users.
>
> I would like to keep current implementation due to test/integration
> effort. I prefer to apply clk_hw related APIs on new clk drivers instead
> of modify existing drivers.
>
Sure, no problem.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-15 18:16 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 7:40 [PATCH v9 00/10] Add clock support for Mediatek MT2701 Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 01/10] clk: fix initial state of critical clock's parents Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-07-02 1:21 ` Stephen Boyd
2016-07-02 1:21 ` Stephen Boyd
2016-07-04 3:51 ` James Liao
2016-07-04 3:51 ` James Liao
2016-07-04 3:51 ` James Liao
2016-07-08 23:32 ` Michael Turquette
2016-07-08 23:32 ` Michael Turquette
2016-07-08 23:32 ` Michael Turquette
2016-07-09 0:46 ` Stephen Boyd
2016-07-09 0:46 ` Stephen Boyd
2016-07-11 8:24 ` James Liao
2016-07-11 8:24 ` James Liao
2016-07-11 8:24 ` James Liao
2016-08-03 5:46 ` James Liao
2016-08-03 5:46 ` James Liao
2016-08-03 5:46 ` James Liao
2016-08-09 5:39 ` James Liao
2016-08-09 5:39 ` James Liao
2016-08-09 5:39 ` James Liao
2016-08-10 21:09 ` Stephen Boyd
2016-08-10 21:09 ` Stephen Boyd
2016-08-10 21:09 ` Stephen Boyd
2016-08-12 8:17 ` James Liao
2016-08-12 8:17 ` James Liao
2016-08-12 8:17 ` James Liao
2016-08-13 0:39 ` Stephen Boyd
2016-08-13 0:39 ` Stephen Boyd
2016-08-15 2:47 ` James Liao
2016-08-15 2:47 ` James Liao
2016-08-15 2:47 ` James Liao
2016-06-22 7:40 ` [PATCH v9 02/10] clk: mediatek: remove __init from clk registration functions Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 03/10] clk: mediatek: Refine the makefile to support multiple clock drivers Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-08-13 0:41 ` Stephen Boyd
2016-08-13 0:41 ` Stephen Boyd
2016-08-13 0:41 ` Stephen Boyd
2016-06-22 7:40 ` [PATCH v9 04/10] dt-bindings: ARM: Mediatek: Document bindings for MT2701 Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 05/10] clk: mediatek: Add dt-bindings for MT2701 clocks Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 06/10] clk: mediatek: Add MT2701 clock support Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-08-13 0:44 ` Stephen Boyd
2016-08-13 0:44 ` Stephen Boyd
2016-08-15 3:00 ` James Liao
2016-08-15 3:00 ` James Liao
2016-08-15 3:00 ` James Liao
2016-08-15 18:16 ` Stephen Boyd [this message]
2016-08-15 18:16 ` Stephen Boyd
2016-06-22 7:40 ` [PATCH v9 07/10] reset: mediatek: Add MT2701 reset controller dt-binding file Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 08/10] reset: mediatek: Add MT2701 reset driver Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 09/10] arm: dts: mt2701: Add clock controller device nodes Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` [PATCH v9 10/10] arm: dts: mt2701: Use real clock for UARTs Erin Lo
2016-06-22 7:40 ` Erin Lo
2016-06-22 7:40 ` Erin Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815181604.GU361@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=blogic@openwrt.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=erin.lo@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shunli.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.