From: sboyd@codeaurora.org (Stephen Boyd)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver
Date: Tue, 16 Aug 2016 10:29:45 -0700 [thread overview]
Message-ID: <20160816172945.GZ361@codeaurora.org> (raw)
In-Reply-To: <16163435-1310-043d-804f-3bb1fd33cff4@baylibre.com>
On 08/16, Neil Armstrong wrote:
> On 08/13/2016 03:29 AM, Stephen Boyd wrote:
> > On 08/09, Neil Armstrong wrote:
>
> >> +
> >> +static struct clk_hw_onecell_data gxbb_aoclk_onecell_data = {
> >
> > can this be const?
>
> It would be awesome, but it will be discarded by of_clk_add_hw_provider :
Ok, right.
> >> +iounmap:
> >> + iounmap(base);
> >> + return ret;
> >> +}
> >> +
> >> +static const struct of_device_id gxbb_aoclkc_match_table[] = {
> >> + { .compatible = "amlogic,gxbb-aoclkc" },
> >> + { }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
> >> +
> >> +static struct platform_driver gxbb_aoclkc_driver = {
> >> + .probe = gxbb_aoclkc_probe,
> >
> > No remove means leak of iomem mapping.
And OF provider registration.
> >
>
> It will be non-modular, so no need of remove. The MODULE_* macros and module.h include will be removed like other clk drivers (gxbb and oxnas for instance).
Ok make sure to remove sysfs unbinding then.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, mturquette@baylibre.com
Subject: Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver
Date: Tue, 16 Aug 2016 10:29:45 -0700 [thread overview]
Message-ID: <20160816172945.GZ361@codeaurora.org> (raw)
In-Reply-To: <16163435-1310-043d-804f-3bb1fd33cff4@baylibre.com>
On 08/16, Neil Armstrong wrote:
> On 08/13/2016 03:29 AM, Stephen Boyd wrote:
> > On 08/09, Neil Armstrong wrote:
>
> >> +
> >> +static struct clk_hw_onecell_data gxbb_aoclk_onecell_data = {
> >
> > can this be const?
>
> It would be awesome, but it will be discarded by of_clk_add_hw_provider :
Ok, right.
> >> +iounmap:
> >> + iounmap(base);
> >> + return ret;
> >> +}
> >> +
> >> +static const struct of_device_id gxbb_aoclkc_match_table[] = {
> >> + { .compatible = "amlogic,gxbb-aoclkc" },
> >> + { }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
> >> +
> >> +static struct platform_driver gxbb_aoclkc_driver = {
> >> + .probe = gxbb_aoclkc_probe,
> >
> > No remove means leak of iomem mapping.
And OF provider registration.
> >
>
> It will be non-modular, so no need of remove. The MODULE_* macros and module.h include will be removed like other clk drivers (gxbb and oxnas for instance).
Ok make sure to remove sysfs unbinding then.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver
Date: Tue, 16 Aug 2016 10:29:45 -0700 [thread overview]
Message-ID: <20160816172945.GZ361@codeaurora.org> (raw)
In-Reply-To: <16163435-1310-043d-804f-3bb1fd33cff4@baylibre.com>
On 08/16, Neil Armstrong wrote:
> On 08/13/2016 03:29 AM, Stephen Boyd wrote:
> > On 08/09, Neil Armstrong wrote:
>
> >> +
> >> +static struct clk_hw_onecell_data gxbb_aoclk_onecell_data = {
> >
> > can this be const?
>
> It would be awesome, but it will be discarded by of_clk_add_hw_provider :
Ok, right.
> >> +iounmap:
> >> + iounmap(base);
> >> + return ret;
> >> +}
> >> +
> >> +static const struct of_device_id gxbb_aoclkc_match_table[] = {
> >> + { .compatible = "amlogic,gxbb-aoclkc" },
> >> + { }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
> >> +
> >> +static struct platform_driver gxbb_aoclkc_driver = {
> >> + .probe = gxbb_aoclkc_probe,
> >
> > No remove means leak of iomem mapping.
And OF provider registration.
> >
>
> It will be non-modular, so no need of remove. The MODULE_* macros and module.h include will be removed like other clk drivers (gxbb and oxnas for instance).
Ok make sure to remove sysfs unbinding then.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-16 17:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 9:13 [PATCH 0/3] clk: Add Meson GXBB Always-On Reset + Clocks Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-13 1:29 ` Stephen Boyd
2016-08-13 1:29 ` Stephen Boyd
2016-08-13 1:29 ` Stephen Boyd
2016-08-16 13:34 ` Neil Armstrong
2016-08-16 13:34 ` Neil Armstrong
2016-08-16 13:34 ` Neil Armstrong
2016-08-16 17:29 ` Stephen Boyd [this message]
2016-08-16 17:29 ` Stephen Boyd
2016-08-16 17:29 ` Stephen Boyd
2016-08-15 0:08 ` Paul Gortmaker
2016-08-15 0:08 ` Paul Gortmaker
2016-08-15 0:08 ` Paul Gortmaker
2016-08-16 13:35 ` Neil Armstrong
2016-08-16 13:35 ` Neil Armstrong
2016-08-16 13:35 ` Neil Armstrong
2016-08-09 9:13 ` [PATCH 2/3] dt-bindings: clock: reset: Add GXBB AO Clock and Reset Bindings Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-10 21:40 ` Rob Herring
2016-08-10 21:40 ` Rob Herring
2016-08-10 21:40 ` Rob Herring
2016-08-10 21:40 ` Rob Herring
2016-08-09 9:13 ` [PATCH 3/3] ARM64: dts: meson-gxbb: Add GXBB AO Clock and Reset node Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816172945.GZ361@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.