All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbeldan@baylibre.com (Karl Beldan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: davinci_all_defconfig: enable modules for sound on LCDK
Date: Wed, 17 Aug 2016 10:13:31 +0000	[thread overview]
Message-ID: <20160817101331.GA8009@gobelin> (raw)
In-Reply-To: <52f428a2-7818-5f3a-bb66-70e2eaa63e7a@ti.com>

On Wed, Aug 17, 2016 at 02:20:51PM +0530, Sekhar Nori wrote:
> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
> > This is the minimal set of additional modules required to support audio
> > on the LCDK.
> > 
> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> 
> This patch does not apply because Kevin already added some missing audio
> modules through commit "ARM: davinci_all_defconfig: enable DA850 audio
> as modules"
> 
> Can you please rebase on master branch of my tree[1] and resend?
> 

I checked out your tree.
With Kevin's patch the needed modules get selected without needing 2/2.

However I don't know why he used:
 CONFIG_SND_DA850_SOC_EVM=m
instead of: 
 CONFIG_SND_DAVINCI_SOC_MCASP=m
 CONFIG_SND_SOC_TLV320AIC3X=m
The former seems to me to be pre-DT style config. I used the latter in
2/2 and thought that's what we'd start switching to ? Unless it is for
pre-DT compatibility ?

 
Karl

WARNING: multiple messages have this Message-ID (diff)
From: Karl Beldan <kbeldan-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Karl Beldan
	<karl.beldan+oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: davinci_all_defconfig: enable modules for sound on LCDK
Date: Wed, 17 Aug 2016 10:13:31 +0000	[thread overview]
Message-ID: <20160817101331.GA8009@gobelin> (raw)
In-Reply-To: <52f428a2-7818-5f3a-bb66-70e2eaa63e7a-l0cyMroinI0@public.gmane.org>

On Wed, Aug 17, 2016 at 02:20:51PM +0530, Sekhar Nori wrote:
> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
> > This is the minimal set of additional modules required to support audio
> > on the LCDK.
> > 
> > Signed-off-by: Karl Beldan <kbeldan-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> 
> This patch does not apply because Kevin already added some missing audio
> modules through commit "ARM: davinci_all_defconfig: enable DA850 audio
> as modules"
> 
> Can you please rebase on master branch of my tree[1] and resend?
> 

I checked out your tree.
With Kevin's patch the needed modules get selected without needing 2/2.

However I don't know why he used:
 CONFIG_SND_DA850_SOC_EVM=m
instead of: 
 CONFIG_SND_DAVINCI_SOC_MCASP=m
 CONFIG_SND_SOC_TLV320AIC3X=m
The former seems to me to be pre-DT style config. I used the latter in
2/2 and thought that's what we'd start switching to ? Unless it is for
pre-DT compatibility ?

 
Karl
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Karl Beldan <kbeldan@baylibre.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Kevin Hilman <khilman@baylibre.com>,
	Karl Beldan <karl.beldan+oss@gmail.com>
Subject: Re: [PATCH 2/2] ARM: davinci_all_defconfig: enable modules for sound on LCDK
Date: Wed, 17 Aug 2016 10:13:31 +0000	[thread overview]
Message-ID: <20160817101331.GA8009@gobelin> (raw)
In-Reply-To: <52f428a2-7818-5f3a-bb66-70e2eaa63e7a@ti.com>

On Wed, Aug 17, 2016 at 02:20:51PM +0530, Sekhar Nori wrote:
> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
> > This is the minimal set of additional modules required to support audio
> > on the LCDK.
> > 
> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> 
> This patch does not apply because Kevin already added some missing audio
> modules through commit "ARM: davinci_all_defconfig: enable DA850 audio
> as modules"
> 
> Can you please rebase on master branch of my tree[1] and resend?
> 

I checked out your tree.
With Kevin's patch the needed modules get selected without needing 2/2.

However I don't know why he used:
 CONFIG_SND_DA850_SOC_EVM=m
instead of: 
 CONFIG_SND_DAVINCI_SOC_MCASP=m
 CONFIG_SND_SOC_TLV320AIC3X=m
The former seems to me to be pre-DT style config. I used the latter in
2/2 and thought that's what we'd start switching to ? Unless it is for
pre-DT compatibility ?

 
Karl

  reply	other threads:[~2016-08-17 10:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 20:08 [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card Karl Beldan
2016-08-10 20:08 ` Karl Beldan
2016-08-10 20:08 ` Karl Beldan
2016-08-10 20:08 ` [PATCH 2/2] ARM: davinci_all_defconfig: enable modules for sound on LCDK Karl Beldan
2016-08-10 20:08   ` Karl Beldan
2016-08-10 20:08   ` Karl Beldan
2016-08-17  8:50   ` Sekhar Nori
2016-08-17  8:50     ` Sekhar Nori
2016-08-17  8:50     ` Sekhar Nori
2016-08-17 10:13     ` Karl Beldan [this message]
2016-08-17 10:13       ` Karl Beldan
2016-08-17 10:13       ` Karl Beldan
2016-08-17 10:38       ` Sekhar Nori
2016-08-17 10:38         ` Sekhar Nori
2016-08-17 10:38         ` Sekhar Nori
2016-08-17 13:01         ` Karl Beldan
2016-08-17 13:01           ` Karl Beldan
2016-08-17 13:01           ` Karl Beldan
2016-08-17  6:49 ` [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card Sekhar Nori
2016-08-17  6:49   ` Sekhar Nori
2016-08-17  6:49   ` Sekhar Nori
2016-08-17  9:54 ` Sekhar Nori
2016-08-17  9:54   ` Sekhar Nori
2016-08-17  9:54   ` Sekhar Nori
2016-08-17 10:33   ` Karl Beldan
2016-08-17 10:33     ` Karl Beldan
2016-08-17 10:33     ` Karl Beldan
2016-08-17 11:32     ` Sekhar Nori
2016-08-17 11:32       ` Sekhar Nori
2016-08-17 11:32       ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160817101331.GA8009@gobelin \
    --to=kbeldan@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.