From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [stable:PATCH 1/2] arm64: kernel: Save and restore addr_limit on exception entry
Date: Wed, 17 Aug 2016 14:50:03 +0200 [thread overview]
Message-ID: <20160817125003.GA8428@kroah.com> (raw)
In-Reply-To: <57B1F1B7.2090003@arm.com>
On Mon, Aug 15, 2016 at 05:45:43PM +0100, James Morse wrote:
> Hi Greg,
>
> On 14/08/16 16:54, Greg KH wrote:
> > On Fri, Aug 12, 2016 at 07:11:19PM +0100, James Morse wrote:
> >> commit e19a6ee2460bdd0d0055a6029383422773f9999a upstream.
> >>
> >> If we take an exception while at EL1, the exception handler inherits
> >> the original context's addr_limit value. To be consistent always reset
> >> addr_limit and PSTATE.UAO on (re-)entry to EL1. This prevents accidental
> >> re-use of the original context's addr_limit.
> >>
> >> Based on a similar patch for arm from Russell King.
> >>
> >> Acked-by: Will Deacon <will.deacon@arm.com>
> >> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> >> Signed-off-by: James Morse <james.morse@arm.com>
> >> Signed-off-by: Will Deacon <will.deacon@arm.com>
> >> [ backport to stop perf misusing inherited addr_limit.
> >> Removed code interacting with UAO and the irqstack ]
> >> Link: https://bugs.chromium.org/p/project-zero/issues/detail?id=822
> >> Signed-off-by: James Morse <james.morse@arm.com>
> >> Cc: <stable@vger.kernel.org> #4.1
> >
> > Fails to apply to 4.4-stable, can you provide a backport for both of
> > these to that tree if you want them there?
>
> Sorry - that is what I was trying to do!
>
> v4.4:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-August/448685.html
>
> v4.1 (this one):
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-August/448684.html
>
>
> Did I mess something up in the cc/sign-off area?
Ah, that was confusing. You sent 2 patches, as a series, and didn't
make it obvious what they were to be applied to.
Please make it so I can't miss it, otherwise I will :)
now queued up.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: James Morse <james.morse@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
stable@vger.kernel.org
Subject: Re: [stable:PATCH 1/2] arm64: kernel: Save and restore addr_limit on exception entry
Date: Wed, 17 Aug 2016 14:50:03 +0200 [thread overview]
Message-ID: <20160817125003.GA8428@kroah.com> (raw)
In-Reply-To: <57B1F1B7.2090003@arm.com>
On Mon, Aug 15, 2016 at 05:45:43PM +0100, James Morse wrote:
> Hi Greg,
>
> On 14/08/16 16:54, Greg KH wrote:
> > On Fri, Aug 12, 2016 at 07:11:19PM +0100, James Morse wrote:
> >> commit e19a6ee2460bdd0d0055a6029383422773f9999a upstream.
> >>
> >> If we take an exception while at EL1, the exception handler inherits
> >> the original context's addr_limit value. To be consistent always reset
> >> addr_limit and PSTATE.UAO on (re-)entry to EL1. This prevents accidental
> >> re-use of the original context's addr_limit.
> >>
> >> Based on a similar patch for arm from Russell King.
> >>
> >> Acked-by: Will Deacon <will.deacon@arm.com>
> >> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> >> Signed-off-by: James Morse <james.morse@arm.com>
> >> Signed-off-by: Will Deacon <will.deacon@arm.com>
> >> [ backport to stop perf misusing inherited addr_limit.
> >> Removed code interacting with UAO and the irqstack ]
> >> Link: https://bugs.chromium.org/p/project-zero/issues/detail?id=822
> >> Signed-off-by: James Morse <james.morse@arm.com>
> >> Cc: <stable@vger.kernel.org> #4.1
> >
> > Fails to apply to 4.4-stable, can you provide a backport for both of
> > these to that tree if you want them there?
>
> Sorry - that is what I was trying to do!
>
> v4.4:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-August/448685.html
>
> v4.1 (this one):
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-August/448684.html
>
>
> Did I mess something up in the cc/sign-off area?
Ah, that was confusing. You sent 2 patches, as a series, and didn't
make it obvious what they were to be applied to.
Please make it so I can't miss it, otherwise I will :)
now queued up.
greg k-h
next prev parent reply other threads:[~2016-08-17 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 18:11 [stable:PATCH 1/2] arm64: kernel: Save and restore addr_limit on exception entry James Morse
2016-08-12 18:11 ` James Morse
2016-08-12 18:11 ` [stable:PATCH 2/2] " James Morse
2016-08-12 18:11 ` James Morse
2016-08-14 15:27 ` [E] [stable:PATCH 1/2] " Levin, Alexander
2016-08-14 15:54 ` Greg KH
2016-08-14 15:54 ` Greg KH
2016-08-15 16:45 ` James Morse
2016-08-15 16:45 ` James Morse
2016-08-17 12:50 ` Greg KH [this message]
2016-08-17 12:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817125003.GA8428@kroah.com \
--to=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.