From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andreas Dilger
<adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>,
Jan Kara <jack-IBi9RG/b67k@public.gmane.org>,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ext4: allow DAX writeback for hole punch
Date: Wed, 17 Aug 2016 12:07:22 -0600 [thread overview]
Message-ID: <20160817180722.GB16779@linux.intel.com> (raw)
In-Reply-To: <20160817171955.GA30893-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
On Wed, Aug 17, 2016 at 07:19:55PM +0200, Jan Kara wrote:
> On Wed 17-08-16 10:11:02, Ross Zwisler wrote:
> > Currently when doing a DAX hole punch with ext4 we fail to do a writeback.
> > This is because the logic around filemap_write_and_wait_range() in
> > ext4_punch_hole() only looks for dirty page cache pages in the radix tree,
> > not for dirty DAX exceptional entries.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> Thanks. The patch looks correct, you can add:
>
> Reviewed-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
>
> Although why don't we just simplify the test below to
> mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After all the mapping should
> not have the dirty tag set if there are no pages / no entries?
Sure, that works. I'll update to that in V2, and I'll add stable. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: allow DAX writeback for hole punch
Date: Wed, 17 Aug 2016 12:07:22 -0600 [thread overview]
Message-ID: <20160817180722.GB16779@linux.intel.com> (raw)
In-Reply-To: <20160817171955.GA30893@quack2.suse.cz>
On Wed, Aug 17, 2016 at 07:19:55PM +0200, Jan Kara wrote:
> On Wed 17-08-16 10:11:02, Ross Zwisler wrote:
> > Currently when doing a DAX hole punch with ext4 we fail to do a writeback.
> > This is because the logic around filemap_write_and_wait_range() in
> > ext4_punch_hole() only looks for dirty page cache pages in the radix tree,
> > not for dirty DAX exceptional entries.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Thanks. The patch looks correct, you can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Although why don't we just simplify the test below to
> mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After all the mapping should
> not have the dirty tag set if there are no pages / no entries?
Sure, that works. I'll update to that in V2, and I'll add stable. Thanks!
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-nvdimm@ml01.01.org
Subject: Re: [PATCH] ext4: allow DAX writeback for hole punch
Date: Wed, 17 Aug 2016 12:07:22 -0600 [thread overview]
Message-ID: <20160817180722.GB16779@linux.intel.com> (raw)
In-Reply-To: <20160817171955.GA30893@quack2.suse.cz>
On Wed, Aug 17, 2016 at 07:19:55PM +0200, Jan Kara wrote:
> On Wed 17-08-16 10:11:02, Ross Zwisler wrote:
> > Currently when doing a DAX hole punch with ext4 we fail to do a writeback.
> > This is because the logic around filemap_write_and_wait_range() in
> > ext4_punch_hole() only looks for dirty page cache pages in the radix tree,
> > not for dirty DAX exceptional entries.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Thanks. The patch looks correct, you can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Although why don't we just simplify the test below to
> mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After all the mapping should
> not have the dirty tag set if there are no pages / no entries?
Sure, that works. I'll update to that in V2, and I'll add stable. Thanks!
next prev parent reply other threads:[~2016-08-17 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 16:11 [PATCH] ext4: allow DAX writeback for hole punch Ross Zwisler
2016-08-17 16:11 ` Ross Zwisler
2016-08-17 16:11 ` Ross Zwisler
2016-08-17 17:19 ` Jan Kara
2016-08-17 17:19 ` Jan Kara
2016-08-17 17:19 ` Jan Kara
[not found] ` <20160817171955.GA30893-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-08-17 18:07 ` Ross Zwisler [this message]
2016-08-17 18:07 ` Ross Zwisler
2016-08-17 18:07 ` Ross Zwisler
2016-08-17 18:23 ` [PATCH v2] " Ross Zwisler
2016-08-17 18:23 ` Ross Zwisler
2016-08-17 18:23 ` Ross Zwisler
2016-08-17 18:23 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817180722.GB16779@linux.intel.com \
--to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=jack-IBi9RG/b67k@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.