Re: [PATCH 0/2][RFC] PM / sleep: Expose DPM watchdog timeout to sysfs

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > OK, I've modified the patch to the following version, Rafael, Pavel
> > > could you take a glance at it, thanks:
> > 
> > Certainly looks better.
> > 
> > > Index: linux/kernel/power/Kconfig
> > >
> > ================================================================
> > ===
> > > --- linux.orig/kernel/power/Kconfig
> > > +++ linux/kernel/power/Kconfig
> > > @@ -197,7 +197,7 @@ config DPM_WATCHDOG  config
> > DPM_WATCHDOG_TIMEOUT
> > >  	int "Watchdog timeout in seconds"
> > >  	range 1 120
> > > -	default 60
> > > +	default 120
> > >  	depends on DPM_WATCHDOG
> > >
> > 
> > I like this part.
> > 
> > > +++ linux/Documentation/kernel-parameters.txt
> > > @@ -2749,6 +2749,8 @@ bytes respectively. Such letter suffixes
> > >  	nowatchdog	[KNL] Disable both lockup detectors, i.e.
> > >                          soft-lockup and NMI watchdog (hard-lockup).
> > >
> > > +	no_dpm_watchdog	[KNL] Disable the device suspend/resume
> > watchdog.
> > > +
> > >  	nowb		[ARM]
> > >
> > >  	nox2apic	[X86-64,APIC] Do not enable x2APIC mode.
> > 
> > Do we really need the new cmdline option? Can we just tell people to disable
> > DPM_WATCHDOG completely?
> > 
> > Is there reason to keep the DPM_WATCHDOG? Did it find some real bugs lately?
> > 
> We can tell users to disable the DPM_WATCHDOG, maybe some android people would like
> to use this feature to track/confirm hardware/firmware issues.
> I'm ok with only adjusting the timeout from 60 to 120. 

I believe that's the best solution for now. (Android people often
claim commandline is hard for them to use...)

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html