Re: [PATCH 6/6] Add dockerfile

[Theodore Ts'o <tytso@mit.edu>]

On Fri, Aug 19, 2016 at 12:54:11AM +0400, Dmitry Monakhov wrote:
> Dockerfile is good way to create build environments
> Let's keep it as a reference build script.
> 
> XXX: Currently Ted does not have hub.docker account
>      so this docker file points to my hub. Should be updated.

I guess I'm a little confused about how this Dockerfile works.  First
of all, says "From Debian", so I guess the idea is to be based on an
unspecified version of Debian (why not debian:jessie?).  But then it
has apt-get commands?  How does that work?

And if the idea is to fetch a prebuilt docker image, and we're running
it with docker run --privilege, I'm not sure what value using docker
run is really providing.  We're not using the docker container
features.   And typing

docker run -i -t --privileged ... \
	"kvm-xfstests.sh --kernel /tmp/bzImage --update-files --update-xfstests-tar  smoke"

Is just *awkward*.  The whole point is to let kvm-xfstests read the
kernel from your ~/.config/gce-xfstests, so your work flow can be
something like this:

git am -s ~/mbox/patch.mbox
../make-ext4      # shortcut for something like "make O=/build/ext4 -j16"
kvm-xfstests smoke   # ~/.config/gce-xfststs sets GCE_KERNEL=/build/ext4

needing to type a long docker run command doesn't seem to add any
value.

Confused,

					- Ted