All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/6] xfstest-bld: use parallel gzip if possible
Date: Fri, 19 Aug 2016 09:32:25 -0400	[thread overview]
Message-ID: <20160819133225.GD10888@thunk.org> (raw)
In-Reply-To: <1471553651-9547-5-git-send-email-dmonakhov@openvz.org>

On Fri, Aug 19, 2016 at 12:54:09AM +0400, Dmitry Monakhov wrote:
> diff --git a/kvm-xfstests/kvm-xfstests b/kvm-xfstests/kvm-xfstests
> index d608317..10782d0 100755
> --- a/kvm-xfstests/kvm-xfstests
> +++ b/kvm-xfstests/kvm-xfstests
> @@ -9,6 +9,7 @@ fi
>  . "$DIR/util/get-config"
>  
>  QUIET="quiet loglevel=0"
> +which pigz &>/dev/null && GZIP=pigz || GZIP=gzip
>  
>  . $DIR/util/parse_cli
>  
> @@ -71,7 +72,7 @@ then
>      fi
>      (cd "$DIR/test-appliance"; \
>       tar -X kvm-exclude-files -C files -cf - . | \
> -	 gzip -9n > "$TDIR/files.tar.gz")
> +	 $GZIP -9n > "$TDIR/files.tar.gz")
>      tar -r -f $VDH -C "$TDIR" files.tar.gz
>      rm -rf "$TDIR"
>  fi

There's no real point in using pigz for files.tar.gz, since the file
is so small.  In fact, it's slightly slower on my system:

% time gzip -9 < /tmp/files.tar  > /tmp/files.tar.gz

real   0m0.010s
user   0m0.000s
sys    0m0.000s

% time pigz -9 < /tmp/files.tar  > /tmp/files.tar.gz

real   0m0.012s
user   0m0.010s
sys    0m0.010s

For the xfstests.tar.gz file, it does make sense; it cuts down the
compression time form 3 seconds to half a second.  That's fair,
although at least in my workflow I'm not recreating the
xfstests.tar.gz file all that often.

Cheers,

						- Ted

  parent reply	other threads:[~2016-08-19 13:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 20:54 [PATCH 0/6] xfstests-bld: Fixes and improvements v1 Dmitry Monakhov
     [not found] ` <1471553651-9547-7-git-send-email-dmonakhov@openvz.org>
2016-08-19  5:21   ` [PATCH 6/6] Add dockerfile Theodore Ts'o
2016-08-19  9:27     ` Dmitry Monakhov
2016-08-19 23:29       ` Theodore Ts'o
2016-08-20 11:31         ` Dmitry Monakhov
2016-08-20 19:45           ` Theodore Ts'o
2016-08-21  2:55             ` Theodore Ts'o
2016-08-21 12:02             ` Dmitry Monakhov
2016-08-21 14:26               ` Theodore Ts'o
2016-08-21 15:35               ` Theodore Ts'o
2016-08-22  8:07                 ` Dmitry Monakhov
     [not found] ` <1471553651-9547-2-git-send-email-dmonakhov@openvz.org>
2016-08-19 13:35   ` [PATCH 1/6] xfstests-bld: build update xfstests repo Theodore Ts'o
     [not found] ` <1471553651-9547-3-git-send-email-dmonakhov@openvz.org>
2016-08-19 13:35   ` [PATCH 2/6] fix build typos Theodore Ts'o
     [not found] ` <1471553651-9547-4-git-send-email-dmonakhov@openvz.org>
2016-08-19 13:42   ` [PATCH 3/6] kvm-xfstests: update command line help Theodore Ts'o
2016-08-19 13:51     ` Dmitry Monakhov
2016-08-20 22:19       ` Theodore Ts'o
     [not found] ` <1471553651-9547-6-git-send-email-dmonakhov@openvz.org>
2016-08-19 13:44   ` [PATCH 5/6] kvm-xfstests: add initrd support Theodore Ts'o
2016-08-19 13:59     ` Dmitry Monakhov
2016-08-19 23:40       ` Theodore Ts'o
2016-08-20 22:35   ` Theodore Ts'o
     [not found] ` <1471553651-9547-5-git-send-email-dmonakhov@openvz.org>
2016-08-19 13:32   ` Theodore Ts'o [this message]
2016-08-20 22:52   ` [PATCH 4/6] xfstest-bld: use parallel gzip if possible Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819133225.GD10888@thunk.org \
    --to=tytso@mit.edu \
    --cc=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.