All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: "Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com>
Cc: bhe@redhat.com, linux-doc@vger.kernel.org, xlpang@redhat.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	joe@perches.com, akpm@linux-foundation.org, dyoung@redhat.com,
	vgoyal@redhat.com
Subject: Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus
Date: Fri, 19 Aug 2016 09:57:40 -0600	[thread overview]
Message-ID: <20160819095740.1cccc073@lwn.net> (raw)
In-Reply-To: <57B653D1.8060106@cn.fujitsu.com>

On Fri, 19 Aug 2016 08:33:21 +0800
"Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com> wrote:

> I was also confused by maxcpus and nr_cpus before writing this patch.
> I think it is a good choice to describe it in kernel-parameters.txt.
> 
> Then, only two things need to be done I think.
> One is move the above description to maxcpus= in kernel-parameters.txt.
> And the other is replace maxcpus with maxcpus/nr_cpus in kdump.txt.
> 
> How do you think?

That is not quite what I had in mind, sorry.  What I would really like to
see in kernel-parameters.txt is an explanation of how those two parameters
differ - what do they do differently and how should a user choose one over
the other?  What we have now offers no guidance in that matter.

I suspect that may be a bit more than you had signed up to do.  As an
intermediate step, how about this: rather than tacking on those lines in
kdump.txt, rewrite that paragraph to simply say what the reader should
use.  If nr_cpus is good for everybody, just say that, but your previous
patch suggests that the situation isn't quite that simple?

Thanks,

jon

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: "Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com>
Cc: <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
	<dyoung@redhat.com>, <bhe@redhat.com>, <vgoyal@redhat.com>,
	<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<xlpang@redhat.com>, <joe@perches.com>
Subject: Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus
Date: Fri, 19 Aug 2016 09:57:40 -0600	[thread overview]
Message-ID: <20160819095740.1cccc073@lwn.net> (raw)
In-Reply-To: <57B653D1.8060106@cn.fujitsu.com>

On Fri, 19 Aug 2016 08:33:21 +0800
"Zhou, Wenjian/周文剑" <zhouwj-fnst@cn.fujitsu.com> wrote:

> I was also confused by maxcpus and nr_cpus before writing this patch.
> I think it is a good choice to describe it in kernel-parameters.txt.
> 
> Then, only two things need to be done I think.
> One is move the above description to maxcpus= in kernel-parameters.txt.
> And the other is replace maxcpus with maxcpus/nr_cpus in kdump.txt.
> 
> How do you think?

That is not quite what I had in mind, sorry.  What I would really like to
see in kernel-parameters.txt is an explanation of how those two parameters
differ - what do they do differently and how should a user choose one over
the other?  What we have now offers no guidance in that matter.

I suspect that may be a bit more than you had signed up to do.  As an
intermediate step, how about this: rather than tacking on those lines in
kdump.txt, rewrite that paragraph to simply say what the reader should
use.  If nr_cpus is good for everybody, just say that, but your previous
patch suggests that the situation isn't quite that simple?

Thanks,

jon

  reply	other threads:[~2016-08-19 15:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  3:11 [PATCH v9 0/2] update the doc of kdump Zhou Wenjian
2016-08-18  3:11 ` Zhou Wenjian
2016-08-18  3:11 ` [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian
2016-08-18  3:11   ` Zhou Wenjian
2016-08-18 17:18   ` Jonathan Corbet
2016-08-18 17:18     ` Jonathan Corbet
2016-08-19  0:33     ` "Zhou, Wenjian/周文剑"
2016-08-19  0:33       ` "Zhou, Wenjian/周文剑"
2016-08-19 15:57       ` Jonathan Corbet [this message]
2016-08-19 15:57         ` Jonathan Corbet
2016-08-22  1:14         ` "Zhou, Wenjian/周文剑"
2016-08-22  1:14           ` "Zhou, Wenjian/周文剑"
2016-08-24  5:06           ` Baoquan He
2016-08-24  5:06             ` Baoquan He
2016-08-25 19:10             ` Jonathan Corbet
2016-08-25 19:10               ` Jonathan Corbet
2016-08-27  0:35               ` Baoquan He
2016-08-27  0:35                 ` Baoquan He
2016-08-26  0:45             ` "Zhou, Wenjian/周文剑"
2016-08-26  0:45               ` "Zhou, Wenjian/周文剑"
2016-08-27  0:38               ` Baoquan He
2016-08-27  0:38                 ` Baoquan He
2016-08-18  3:11 ` [PATCH v9 2/2] Documentation: kdump: add description of enable multi-cpus support Zhou Wenjian
2016-08-18  3:11   ` Zhou Wenjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819095740.1cccc073@lwn.net \
    --to=corbet@lwn.net \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=joe@perches.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=xlpang@redhat.com \
    --cc=zhouwj-fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.