From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Clark Williams <williams@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jon Masters <jcm@redhat.com>, Daniel Wagner <wagi@monom.org>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer
Date: Fri, 19 Aug 2016 17:05:51 +0200 [thread overview]
Message-ID: <20160819150551.GE10153@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160819102620.763bd7a0@gandalf.local.home>
On Fri, Aug 19, 2016 at 10:26:20AM -0400, Steven Rostedt wrote:
> > In any case, for those you could probably use ktime_get_mono_fast_ns().
>
> Is that safe to call from NMI?
It should be, we were very careful to make it so. Also read the comment
with __ktime_get_fast_ns().
> Looking into the code I see:
>
> now = ktime_to_ns(tkr->base) + timekeeping_get_ns(tkr);
>
> where timekeeping_get_ns() has:
>
> timekeeping_get_delta()
>
> which does:
>
> read_seqcount_begin()
>
> which has (eventually):
That's a bug in CONFIG_DEBUG_TIMEKEEPING, if you look at the
!timekeeping_get_delta() it does no such thing.
John, looks like 4ca22c2648f9 ("timekeeping: Add warnings when overflows
or underflows are observed") buggered things.
next prev parent reply other threads:[~2016-08-19 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 13:53 [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer Steven Rostedt
2016-08-10 13:53 ` [PATCH v2 1/4] tracing: Added hardware latency tracer Steven Rostedt
2016-08-22 17:27 ` Nilay Vaish
2016-08-22 19:16 ` Steven Rostedt
2016-08-10 13:53 ` [PATCH v2 2/4] tracing: Add documentation for hwlat_detector tracer Steven Rostedt
2016-08-10 13:53 ` [PATCH v2 3/4] tracing: Have hwlat trace migrate across tracing_cpumask CPUs Steven Rostedt
2016-08-10 13:54 ` [PATCH v2 4/4] tracing: Add NMI tracing in hwlat detector Steven Rostedt
2016-08-12 18:13 ` [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer Daniel Bristot de Oliveira
2016-08-19 14:09 ` Peter Zijlstra
2016-08-19 14:26 ` Steven Rostedt
2016-08-19 15:05 ` Peter Zijlstra [this message]
2016-08-19 16:36 ` John Stultz
2016-08-23 8:47 ` Peter Zijlstra
2016-08-23 8:48 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819150551.GE10153@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=C.Emde@osadl.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=jcm@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.