All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Clark Williams <williams@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jon Masters <jcm@redhat.com>, Daniel Wagner <wagi@monom.org>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer
Date: Tue, 23 Aug 2016 10:47:35 +0200	[thread overview]
Message-ID: <20160823084735.GO10153@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CALAqxLULtT+13n6eGYBmDVd=UPUNORCnViXiysgAM+V7g3mN4A@mail.gmail.com>

On Fri, Aug 19, 2016 at 09:36:41AM -0700, John Stultz wrote:
> On Fri, Aug 19, 2016 at 8:05 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > John, looks like 4ca22c2648f9 ("timekeeping: Add warnings when overflows
> > or underflows are observed") buggered things.
> 
> Oof. Apologies. I missed that the fast methods called that helper as well.
> 
> 
> Any objection to open-coding it for the fast method, like (sorry for
> the whitespace damage here):
> 
> @@ -401,7 +401,10 @@ static __always_inline u64
> __ktime_get_fast_ns(struct tk_fast *tkf)
>         do {
>                 seq = raw_read_seqcount_latch(&tkf->seq);
>                 tkr = tkf->base + (seq & 0x01);
> -               now = ktime_to_ns(tkr->base) + timekeeping_get_ns(tkr);
> +               now = ktime_to_ns(tkr->base);
> +
> +               now += clocksource_delta(tkr->read(tkr->clock),
> +                                        tkr->cycle_last, tkr->mask);
>         } while (read_seqcount_retry(&tkf->seq, seq));
> 
>         return now;
> 
> If not I'll get such a patch sorted, tested and tagged for -stable.

Works for me, Thomas?

  reply	other threads:[~2016-08-23  9:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 13:53 [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer Steven Rostedt
2016-08-10 13:53 ` [PATCH v2 1/4] tracing: Added hardware latency tracer Steven Rostedt
2016-08-22 17:27   ` Nilay Vaish
2016-08-22 19:16     ` Steven Rostedt
2016-08-10 13:53 ` [PATCH v2 2/4] tracing: Add documentation for hwlat_detector tracer Steven Rostedt
2016-08-10 13:53 ` [PATCH v2 3/4] tracing: Have hwlat trace migrate across tracing_cpumask CPUs Steven Rostedt
2016-08-10 13:54 ` [PATCH v2 4/4] tracing: Add NMI tracing in hwlat detector Steven Rostedt
2016-08-12 18:13 ` [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer Daniel Bristot de Oliveira
2016-08-19 14:09 ` Peter Zijlstra
2016-08-19 14:26   ` Steven Rostedt
2016-08-19 15:05     ` Peter Zijlstra
2016-08-19 16:36       ` John Stultz
2016-08-23  8:47         ` Peter Zijlstra [this message]
2016-08-23  8:48           ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823084735.GO10153@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=C.Emde@osadl.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=jcm@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=wagi@monom.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.