All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	"Hefty, Sean" <sean.hefty@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
Date: Fri, 19 Aug 2016 15:45:37 +0000	[thread overview]
Message-ID: <20160819154537.GF18515@leon.nu> (raw)
In-Reply-To: <32E1700B9017364D9B60AED9960492BC2D0AF84E@fmsmsx120.amr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Fri, Aug 19, 2016 at 03:42:29PM +0000, Marciniszyn, Mike wrote:
> > >
> > > The bail_tmp: label is then not needed.
> > 
> > You still need to free tmp allocation if qib_eeprom_write failed and this is
> > your bail_tmp.
> > 
> 
> Typo.   The bail: label is not needed.

Yeah, it makes sense.

Thanks

> 
> Mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	"Hefty, Sean" <sean.hefty@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation
Date: Fri, 19 Aug 2016 18:45:37 +0300	[thread overview]
Message-ID: <20160819154537.GF18515@leon.nu> (raw)
In-Reply-To: <32E1700B9017364D9B60AED9960492BC2D0AF84E@fmsmsx120.amr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Fri, Aug 19, 2016 at 03:42:29PM +0000, Marciniszyn, Mike wrote:
> > >
> > > The bail_tmp: label is then not needed.
> > 
> > You still need to free tmp allocation if qib_eeprom_write failed and this is
> > your bail_tmp.
> > 
> 
> Typo.   The bail: label is not needed.

Yeah, it makes sense.

Thanks

> 
> Mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-08-19 15:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19  7:06 [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation SF Markus Elfring
2016-08-19  7:06 ` SF Markus Elfring
     [not found] ` <620b3961-6e05-6638-4ca8-18766acc91f4-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2016-08-19 15:27   ` Marciniszyn, Mike
2016-08-19 15:27     ` Marciniszyn, Mike
2016-08-19 15:27     ` Marciniszyn, Mike
     [not found]     ` <32E1700B9017364D9B60AED9960492BC2D0AF815-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-08-19 15:41       ` Leon Romanovsky
2016-08-19 15:41         ` Leon Romanovsky
2016-08-19 15:41         ` Leon Romanovsky
     [not found]         ` <20160819154106.GC18515-2ukJVAZIZ/Y@public.gmane.org>
2016-08-19 15:42           ` Marciniszyn, Mike
2016-08-19 15:42             ` Marciniszyn, Mike
2016-08-19 15:42             ` Marciniszyn, Mike
2016-08-19 15:45             ` Leon Romanovsky [this message]
2016-08-19 15:45               ` Leon Romanovsky
2016-08-23 16:43     ` Doug Ledford
2016-08-23 16:43       ` Doug Ledford
2016-08-19 15:37 ` Leon Romanovsky
2016-08-19 15:37   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819154537.GF18515@leon.nu \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=elfring@users.sourceforge.net \
    --cc=hal.rosenstock@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.