From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: multi_v7_defconfig: Don't attempt to enable schedutil governor as module
Date: Fri, 19 Aug 2016 17:51:40 +0200 [thread overview]
Message-ID: <20160819155140.GA12633@kozik-lap> (raw)
In-Reply-To: <fe0ad949-ecd1-e0fe-3d9b-04a35b9dc172@osg.samsung.com>
On Fri, Aug 19, 2016 at 09:52:47AM -0400, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 08/19/2016 09:46 AM, Javier Martinez Canillas wrote:
> >
> > On 08/19/2016 09:40 AM, Krzysztof Kozlowski wrote:
> >> On 08/19/2016 03:12 PM, Javier Martinez Canillas wrote:
> >>> The schedutil CPUFreq governor could be built as a module but the commit
> >>> 58919e83c85c ("cpufreq / sched: Pass flags to cpufreq_update_util()")
> >>> made it non-modular so attempting to enable as module leads to a warning:
> >>>
> >>> warning: symbol value 'm' invalid for CPU_FREQ_GOV_SCHEDUTIL
> >>>
> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >>>
> >>> ---
> >>>
> >>> arch/arm/configs/multi_v7_defconfig | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Looks good.
> >>
> >> Applied... wait, no, these are not in samsung-soc list so they miss also
> >> from patchwork. For reference:
> >> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>
> >
> > Sigh, get_maintainers.pl suggested me an insanely large cc list so I added
> > it manually... but I forgot linux-samsung-soc. I'll post v2.
> >
>
> Damn... and now I forgot to include your collected tags in v2. I should not
> post patches before having enough coffee, sorry about that.
>
> Please let me know if you don't mind or if you prefer a resend.
No problem, no need to resend.
Applied to separate branch (not tagged yet) in case someone would like
to base on top of it. Then please let me know, I'll add a tag.
Mentioned commit is not yet in mainline and was applied recently, so I
remove the SHA from commit msg. The SHA might change and it's better not
to pollute the history in that case.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org, arm@kernel.org
Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: Don't attempt to enable schedutil governor as module
Date: Fri, 19 Aug 2016 17:51:40 +0200 [thread overview]
Message-ID: <20160819155140.GA12633@kozik-lap> (raw)
In-Reply-To: <fe0ad949-ecd1-e0fe-3d9b-04a35b9dc172@osg.samsung.com>
On Fri, Aug 19, 2016 at 09:52:47AM -0400, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 08/19/2016 09:46 AM, Javier Martinez Canillas wrote:
> >
> > On 08/19/2016 09:40 AM, Krzysztof Kozlowski wrote:
> >> On 08/19/2016 03:12 PM, Javier Martinez Canillas wrote:
> >>> The schedutil CPUFreq governor could be built as a module but the commit
> >>> 58919e83c85c ("cpufreq / sched: Pass flags to cpufreq_update_util()")
> >>> made it non-modular so attempting to enable as module leads to a warning:
> >>>
> >>> warning: symbol value 'm' invalid for CPU_FREQ_GOV_SCHEDUTIL
> >>>
> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >>>
> >>> ---
> >>>
> >>> arch/arm/configs/multi_v7_defconfig | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Looks good.
> >>
> >> Applied... wait, no, these are not in samsung-soc list so they miss also
> >> from patchwork. For reference:
> >> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>
> >
> > Sigh, get_maintainers.pl suggested me an insanely large cc list so I added
> > it manually... but I forgot linux-samsung-soc. I'll post v2.
> >
>
> Damn... and now I forgot to include your collected tags in v2. I should not
> post patches before having enough coffee, sorry about that.
>
> Please let me know if you don't mind or if you prefer a resend.
No problem, no need to resend.
Applied to separate branch (not tagged yet) in case someone would like
to base on top of it. Then please let me know, I'll add a tag.
Mentioned commit is not yet in mainline and was applied recently, so I
remove the SHA from commit msg. The SHA might change and it's better not
to pollute the history in that case.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-08-19 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 13:12 [PATCH 1/2] ARM: exynos_defconfig: Don't attempt to enable schedutil governor as module Javier Martinez Canillas
2016-08-19 13:12 ` Javier Martinez Canillas
2016-08-19 13:12 ` [PATCH 2/2] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-08-19 13:12 ` Javier Martinez Canillas
2016-08-19 13:40 ` Krzysztof Kozlowski
2016-08-19 13:40 ` Krzysztof Kozlowski
2016-08-19 13:46 ` Javier Martinez Canillas
2016-08-19 13:46 ` Javier Martinez Canillas
2016-08-19 13:52 ` Javier Martinez Canillas
2016-08-19 13:52 ` Javier Martinez Canillas
2016-08-19 15:51 ` Krzysztof Kozlowski [this message]
2016-08-19 15:51 ` Krzysztof Kozlowski
2016-08-19 15:55 ` Javier Martinez Canillas
2016-08-19 15:55 ` Javier Martinez Canillas
2016-08-19 13:41 ` [PATCH 1/2] ARM: exynos_defconfig: " Krzysztof Kozlowski
2016-08-19 13:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819155140.GA12633@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.