All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rithvik Patibandla <rithvikp98@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:sm750fb:ddk750_chip.c:Fixed coding style in comments
Date: Sun, 21 Aug 2016 16:06:34 +0000	[thread overview]
Message-ID: <20160821160634.GA10137@kroah.com> (raw)
In-Reply-To: <20160612133041.GA3709@rithvik-IdeaPad>

On Sun, Jun 12, 2016 at 07:00:41PM +0530, Rithvik Patibandla wrote:
> The following patch fixes format of some comments.
> 
> Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 71 +++++++++++++++++++----------------
>  1 file changed, 38 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index f80ee77..8cb5cb9 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -70,11 +70,11 @@ static void setChipClock(unsigned int frequency)
>  		pll.inputFreq = DEFAULT_INPUT_CLOCK; /* Defined in CLOCK.H */
>  		pll.clockType = MXCLK_PLL;
>  
> -		/*
> -		* Call calcPllValue() to fill up the other fields for PLL structure.
> -		* Sometime, the chip cannot set up the exact clock required by User.
> -		* Return value from calcPllValue() gives the actual possible clock.
> -		*/
> +	/*
> +	 * Call calcPllValue() to fill up the other fields for PLL structure.
> +	 * Sometime, the chip cannot set up the exact clock required by User.
> +	 * Return value from calcPllValue() gives the actual possible clock.
> +	 */

Really?  Does that look correct to you?

hint your indentation is totally wrong :(

Please be more careful...

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Rithvik Patibandla <rithvikp98@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:sm750fb:ddk750_chip.c:Fixed coding style in comments
Date: Sun, 21 Aug 2016 18:06:34 +0200	[thread overview]
Message-ID: <20160821160634.GA10137@kroah.com> (raw)
In-Reply-To: <20160612133041.GA3709@rithvik-IdeaPad>

On Sun, Jun 12, 2016 at 07:00:41PM +0530, Rithvik Patibandla wrote:
> The following patch fixes format of some comments.
> 
> Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 71 +++++++++++++++++++----------------
>  1 file changed, 38 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index f80ee77..8cb5cb9 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -70,11 +70,11 @@ static void setChipClock(unsigned int frequency)
>  		pll.inputFreq = DEFAULT_INPUT_CLOCK; /* Defined in CLOCK.H */
>  		pll.clockType = MXCLK_PLL;
>  
> -		/*
> -		* Call calcPllValue() to fill up the other fields for PLL structure.
> -		* Sometime, the chip cannot set up the exact clock required by User.
> -		* Return value from calcPllValue() gives the actual possible clock.
> -		*/
> +	/*
> +	 * Call calcPllValue() to fill up the other fields for PLL structure.
> +	 * Sometime, the chip cannot set up the exact clock required by User.
> +	 * Return value from calcPllValue() gives the actual possible clock.
> +	 */

Really?  Does that look correct to you?

hint your indentation is totally wrong :(

Please be more careful...

greg k-h

  reply	other threads:[~2016-08-21 16:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12 13:30 [PATCH] Staging:sm750fb:ddk750_chip.c:Fixed coding style in comments Rithvik Patibandla
2016-06-12 13:42 ` Rithvik Patibandla
2016-08-21 16:06 ` Greg KH [this message]
2016-08-21 16:06   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160821160634.GA10137@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rithvikp98@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.