From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.xyz>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] ARM: dts: sunxi: Use new sun7i-a20-mmc compatible on sun7i and newer
Date: Mon, 22 Aug 2016 09:54:54 +0200 [thread overview]
Message-ID: <20160822075454.GB7104@lukather> (raw)
In-Reply-To: <9b6ed836-27ff-c8c8-d886-d86c787605fc@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]
On Mon, Aug 01, 2016 at 02:11:09PM +0100, Andre Przywara wrote:
> Hi Hans,
>
> On 30/07/16 15:25, Hans de Goede wrote:
> > Use the new sun7i-a20-mmc compatible for the mmc controllers on sun7i
> > and newer.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > Changes in v2:
> > -New patch in v2 of this patch-set
> > ---
> > arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++----
> > arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++----
> > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 6 +++---
> > arch/arm/boot/dts/sun8i-h3.dtsi | 6 +++---
> > 4 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
> > index 1867af2..0d24f10 100644
> > --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> > @@ -469,7 +469,7 @@
> > };
> >
> > mmc0: mmc@01c0f000 {
> > - compatible = "allwinner,sun5i-a13-mmc";
> > + compatible = "allwinner,sun7i-a20-mmc";
>
> But that breaks systems with newer DTs on older kernels, which do not
> know about sun7i-a20-mmc.
That's not backward compatibility. That's the forward one, and that
has never been something we supported.
See https://www.kernel.org/doc/Documentation/devicetree/bindings/ABI.txt
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] ARM: dts: sunxi: Use new sun7i-a20-mmc compatible on sun7i and newer
Date: Mon, 22 Aug 2016 09:54:54 +0200 [thread overview]
Message-ID: <20160822075454.GB7104@lukather> (raw)
In-Reply-To: <9b6ed836-27ff-c8c8-d886-d86c787605fc@arm.com>
On Mon, Aug 01, 2016 at 02:11:09PM +0100, Andre Przywara wrote:
> Hi Hans,
>
> On 30/07/16 15:25, Hans de Goede wrote:
> > Use the new sun7i-a20-mmc compatible for the mmc controllers on sun7i
> > and newer.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > Changes in v2:
> > -New patch in v2 of this patch-set
> > ---
> > arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++----
> > arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++----
> > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 6 +++---
> > arch/arm/boot/dts/sun8i-h3.dtsi | 6 +++---
> > 4 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
> > index 1867af2..0d24f10 100644
> > --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> > @@ -469,7 +469,7 @@
> > };
> >
> > mmc0: mmc at 01c0f000 {
> > - compatible = "allwinner,sun5i-a13-mmc";
> > + compatible = "allwinner,sun7i-a20-mmc";
>
> But that breaks systems with newer DTs on older kernels, which do not
> know about sun7i-a20-mmc.
That's not backward compatibility. That's the forward one, and that
has never been something we supported.
See https://www.kernel.org/doc/Documentation/devicetree/bindings/ABI.txt
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160822/a799407f/attachment.sig>
next prev parent reply other threads:[~2016-08-22 7:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 14:25 [PATCH v2 0/5] mmc: sunxi: sun4i / sun5i do not have sample clocks Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-30 14:25 ` [PATCH v2 1/5] mmc: sunxi: Disable sample clks on remove Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-30 15:13 ` Maxime Ripard
2016-07-30 15:13 ` Maxime Ripard
2016-07-30 14:25 ` [PATCH v2 2/5] mmc: sunxi: Introduce a sunxi_mmc_cfg struct Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-30 15:14 ` Maxime Ripard
2016-07-30 15:14 ` Maxime Ripard
2016-07-30 14:25 ` [PATCH v2 3/5] mmc: sunxi: Factor out clock phase setting code into a helper function Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-30 15:14 ` Maxime Ripard
2016-07-30 15:14 ` Maxime Ripard
2016-07-30 15:18 ` Icenowy Zheng
2016-07-30 15:18 ` Icenowy Zheng
2016-07-30 14:25 ` [PATCH v2 4/5] mmc: sunxi: sun4i / sun5i do not have sample clocks Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-30 15:15 ` Maxime Ripard
2016-07-30 15:15 ` Maxime Ripard
2016-08-01 16:39 ` Rob Herring
2016-08-01 16:39 ` Rob Herring
2016-07-30 14:25 ` [PATCH v2 5/5] ARM: dts: sunxi: Use new sun7i-a20-mmc compatible on sun7i and newer Hans de Goede
2016-07-30 14:25 ` Hans de Goede
2016-07-30 15:16 ` Maxime Ripard
2016-07-30 15:16 ` Maxime Ripard
2016-07-31 14:17 ` Hans de Goede
2016-07-31 14:17 ` Hans de Goede
2016-08-01 13:11 ` Andre Przywara
2016-08-01 13:11 ` Andre Przywara
2016-08-02 13:58 ` Hans de Goede
2016-08-02 13:58 ` Hans de Goede
2016-08-22 7:54 ` Maxime Ripard [this message]
2016-08-22 7:54 ` Maxime Ripard
2016-08-22 9:02 ` Andre Przywara
2016-08-22 9:02 ` Andre Przywara
2016-08-22 13:38 ` [PATCH v2 0/5] mmc: sunxi: sun4i / sun5i do not have sample clocks Ulf Hansson
2016-08-22 13:38 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822075454.GB7104@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.