* [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
@ 2016-07-28 16:17 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2016-07-28 16:17 UTC (permalink / raw)
To: Thomas Petazzoni, Bjorn Helgaas; +Cc: Wei Yongjun, linux-pci, linux-arm-kernel
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/pci/host/pci-aardvark.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
index ef9893f..05c33b5 100644
--- a/drivers/pci/host/pci-aardvark.c
+++ b/drivers/pci/host/pci-aardvark.c
@@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
pcie->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pcie->base)) {
- dev_err(&pdev->dev, "Failed to map registers\n");
+ if (IS_ERR(pcie->base))
return PTR_ERR(pcie->base);
- }
irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
@ 2016-07-28 16:17 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2016-07-28 16:17 UTC (permalink / raw)
To: linux-arm-kernel
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/pci/host/pci-aardvark.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
index ef9893f..05c33b5 100644
--- a/drivers/pci/host/pci-aardvark.c
+++ b/drivers/pci/host/pci-aardvark.c
@@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
pcie->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pcie->base)) {
- dev_err(&pdev->dev, "Failed to map registers\n");
+ if (IS_ERR(pcie->base))
return PTR_ERR(pcie->base);
- }
irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
2016-07-28 16:17 ` Wei Yongjun
@ 2016-07-28 20:17 ` Thomas Petazzoni
-1 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-07-28 20:17 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Bjorn Helgaas, linux-pci, linux-arm-kernel
Hello,
On Thu, 28 Jul 2016 16:17:14 +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
> drivers/pci/host/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
@ 2016-07-28 20:17 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-07-28 20:17 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Thu, 28 Jul 2016 16:17:14 +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
> drivers/pci/host/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
2016-07-28 16:17 ` Wei Yongjun
@ 2016-08-22 19:38 ` Bjorn Helgaas
-1 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2016-08-22 19:38 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Thomas Petazzoni, Bjorn Helgaas, linux-arm-kernel, linux-pci
On Thu, Jul 28, 2016 at 04:17:14PM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied with Thomas' reviewed-by to pci/host-aardvark for v4.9, thanks!
> ---
> drivers/pci/host/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
> index ef9893f..05c33b5 100644
> --- a/drivers/pci/host/pci-aardvark.c
> +++ b/drivers/pci/host/pci-aardvark.c
> @@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> pcie->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pcie->base)) {
> - dev_err(&pdev->dev, "Failed to map registers\n");
> + if (IS_ERR(pcie->base))
> return PTR_ERR(pcie->base);
> - }
>
> irq = platform_get_irq(pdev, 0);
> ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()
@ 2016-08-22 19:38 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2016-08-22 19:38 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 28, 2016 at 04:17:14PM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied with Thomas' reviewed-by to pci/host-aardvark for v4.9, thanks!
> ---
> drivers/pci/host/pci-aardvark.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
> index ef9893f..05c33b5 100644
> --- a/drivers/pci/host/pci-aardvark.c
> +++ b/drivers/pci/host/pci-aardvark.c
> @@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> pcie->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pcie->base)) {
> - dev_err(&pdev->dev, "Failed to map registers\n");
> + if (IS_ERR(pcie->base))
> return PTR_ERR(pcie->base);
> - }
>
> irq = platform_get_irq(pdev, 0);
> ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-22 19:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-28 16:17 [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe() Wei Yongjun
2016-07-28 16:17 ` Wei Yongjun
2016-07-28 20:17 ` Thomas Petazzoni
2016-07-28 20:17 ` Thomas Petazzoni
2016-08-22 19:38 ` Bjorn Helgaas
2016-08-22 19:38 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.