* [PATCH -next] remoteproc: qcom: wcnss: Fix return value check in wcnss_probe()
@ 2016-08-21 14:39 Wei Yongjun
2016-08-23 4:39 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-21 14:39 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson; +Cc: Wei Yongjun, linux-remoteproc
From: Wei Yongjun <weiyongjun1@huawei.com>
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/remoteproc/qcom_wcnss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c
index 14c4585..1917de7 100644
--- a/drivers/remoteproc/qcom_wcnss.c
+++ b/drivers/remoteproc/qcom_wcnss.c
@@ -528,8 +528,8 @@ static int wcnss_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pmu");
mmio = devm_ioremap_resource(&pdev->dev, res);
- if (!mmio) {
- ret = -ENOMEM;
+ if (IS_ERR(mmio)) {
+ ret = PTR_ERR(mmio);
goto free_rproc;
};
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] remoteproc: qcom: wcnss: Fix return value check in wcnss_probe()
2016-08-21 14:39 [PATCH -next] remoteproc: qcom: wcnss: Fix return value check in wcnss_probe() Wei Yongjun
@ 2016-08-23 4:39 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2016-08-23 4:39 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Ohad Ben-Cohen, Wei Yongjun, linux-remoteproc
On Sun 21 Aug 07:39 PDT 2016, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks Wei, applied to rproc-next.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_wcnss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c
> index 14c4585..1917de7 100644
> --- a/drivers/remoteproc/qcom_wcnss.c
> +++ b/drivers/remoteproc/qcom_wcnss.c
> @@ -528,8 +528,8 @@ static int wcnss_probe(struct platform_device *pdev)
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pmu");
> mmio = devm_ioremap_resource(&pdev->dev, res);
> - if (!mmio) {
> - ret = -ENOMEM;
> + if (IS_ERR(mmio)) {
> + ret = PTR_ERR(mmio);
> goto free_rproc;
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-23 4:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-21 14:39 [PATCH -next] remoteproc: qcom: wcnss: Fix return value check in wcnss_probe() Wei Yongjun
2016-08-23 4:39 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.