All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints
Date: Tue, 23 Aug 2016 11:40:02 +0100	[thread overview]
Message-ID: <20160823104002.GX22076@sirena.org.uk> (raw)
In-Reply-To: <CAGb2v67ZST-E++z5oobLRwCfHMZZR6HTss=MSqJLJArnQz3qMw@mail.gmail.com>

On Tue, Aug 23, 2016 at 12:17:23PM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 23, 2016 at 2:09 AM, Mark Brown <broonie@kernel.org> wrote:

> > Sure, but the constraints also say that you can do 1.32V which the
> > system is not physically capable of delivering.  That's not a good sign
> > for the constraints, it suggests that at least the capabilities of the
> > regulator have not been taken into consideration when setting up the
> > constraints.

> So to be clear, the constraints should be the intersection of the
> recommended operating parameters of the consumer and the regulator's
> output, with the voltage/current steps taken in to consideration.

The constraints are there to say what the *system* can deliver.  That
includes the limitations of the consumers, the regulators and the
physical design of the board.  Just as one shouldn't just throw in the
maximum voltage range that the regulator can deliver one also shouldn't
just use the maximum voltage range a consumer can support for similar
reasons.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160823/346c4861/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Rask Ingemann Lambertsen
	<ccc94453-1EA3ORoCGBhoJ7GROcy7lA@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints
Date: Tue, 23 Aug 2016 11:40:02 +0100	[thread overview]
Message-ID: <20160823104002.GX22076@sirena.org.uk> (raw)
In-Reply-To: <CAGb2v67ZST-E++z5oobLRwCfHMZZR6HTss=MSqJLJArnQz3qMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

On Tue, Aug 23, 2016 at 12:17:23PM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 23, 2016 at 2:09 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

> > Sure, but the constraints also say that you can do 1.32V which the
> > system is not physically capable of delivering.  That's not a good sign
> > for the constraints, it suggests that at least the capabilities of the
> > regulator have not been taken into consideration when setting up the
> > constraints.

> So to be clear, the constraints should be the intersection of the
> recommended operating parameters of the consumer and the regulator's
> output, with the voltage/current steps taken in to consideration.

The constraints are there to say what the *system* can deliver.  That
includes the limitations of the consumers, the regulators and the
physical design of the board.  Just as one shouldn't just throw in the
maximum voltage range that the regulator can deliver one also shouldn't
just use the maximum voltage range a consumer can support for similar
reasons.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints
Date: Tue, 23 Aug 2016 11:40:02 +0100	[thread overview]
Message-ID: <20160823104002.GX22076@sirena.org.uk> (raw)
In-Reply-To: <CAGb2v67ZST-E++z5oobLRwCfHMZZR6HTss=MSqJLJArnQz3qMw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On Tue, Aug 23, 2016 at 12:17:23PM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 23, 2016 at 2:09 AM, Mark Brown <broonie@kernel.org> wrote:

> > Sure, but the constraints also say that you can do 1.32V which the
> > system is not physically capable of delivering.  That's not a good sign
> > for the constraints, it suggests that at least the capabilities of the
> > regulator have not been taken into consideration when setting up the
> > constraints.

> So to be clear, the constraints should be the intersection of the
> recommended operating parameters of the consumer and the regulator's
> output, with the voltage/current steps taken in to consideration.

The constraints are there to say what the *system* can deliver.  That
includes the limitations of the consumers, the regulators and the
physical design of the board.  Just as one shouldn't just throw in the
maximum voltage range that the regulator can deliver one also shouldn't
just use the maximum voltage range a consumer can support for similar
reasons.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-08-23 10:40 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21  2:11 [PATCH 0/9] mfd: axp20x: Add support for AXP809 PMIC Chen-Yu Tsai
2016-08-21  2:11 ` Chen-Yu Tsai
2016-08-21  2:11 ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 1/9] mfd: axp20x: Add bindings for AXP806 PMIC Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-23 17:51   ` Rob Herring
2016-08-23 17:51     ` Rob Herring
2016-08-23 17:51     ` Rob Herring
2016-08-21  2:11 ` [PATCH 2/9] mfd: axp20x: Add support " Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  4:15   ` [linux-sunxi] " Julian Calaby
2016-08-21  4:15     ` Julian Calaby
2016-08-21  4:15     ` Julian Calaby
2016-08-21  2:11 ` [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-22 16:29   ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-22 17:52     ` Rask Ingemann Lambertsen
2016-08-22 17:52       ` Rask Ingemann Lambertsen
2016-08-22 18:09       ` Mark Brown
2016-08-22 18:09         ` Mark Brown
2016-08-22 18:09         ` Mark Brown
2016-08-23  4:17         ` Chen-Yu Tsai
2016-08-23  4:17           ` Chen-Yu Tsai
2016-08-23  4:17           ` Chen-Yu Tsai
2016-08-23 10:40           ` Mark Brown [this message]
2016-08-23 10:40             ` Mark Brown
2016-08-23 10:40             ` Mark Brown
2016-08-22 16:29   ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-21  2:11 ` [PATCH 4/9] regulator: axp20x: support AXP806 variant Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-22 16:52   ` Mark Brown
2016-08-22 16:52     ` Mark Brown
2016-08-22 16:52     ` Mark Brown
2016-08-21  2:11 ` [PATCH 5/9] ARM: dts: sun9i: a80-optimus: Declare AXP809 SW regulator as unused Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 6/9] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 7/9] ARM: dts: sun9i: a80-optimus: Add AXP806 PMIC device node and regulators Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 8/9] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 9/9] ARM: dts: sun9i: a80-optimus: Disable EHCI1 Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  6:51 ` [linux-sunxi] [PATCH 0/9] mfd: axp20x: Add support for AXP809 PMIC Priit Laes
2016-08-21  6:51   ` Priit Laes
2016-08-21  6:51   ` Priit Laes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823104002.GX22076@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.