From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Chris Wilson <chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
Date: Wed, 24 Aug 2016 00:15:50 +0300 [thread overview]
Message-ID: <20160823211550.GQ15065@leon.nu> (raw)
In-Reply-To: <20160823201626.13926-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>
> The include existed since its inception in
>
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Sun Jul 7 17:25:49 2013 +0300
>
> mlx5: Add driver for Mellanox Connect-IB adapters
>
> which looks like a copy across from the Mellanox ethernet driver.
>
> Signed-off-by: Chris Wilson <chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
I assume that it passed 0-day builds.
Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro@mellanox.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Eli Cohen <eli@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
Date: Wed, 24 Aug 2016 00:15:50 +0300 [thread overview]
Message-ID: <20160823211550.GQ15065@leon.nu> (raw)
In-Reply-To: <20160823201626.13926-1-chris@chris-wilson.co.uk>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>
> The include existed since its inception in
>
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@mellanox.com>
> Date: Sun Jul 7 17:25:49 2013 +0300
>
> mlx5: Add driver for Mellanox Connect-IB adapters
>
> which looks like a copy across from the Mellanox ethernet driver.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
I assume that it passed 0-day builds.
Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-23 21:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 20:16 [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h Chris Wilson
2016-08-23 20:16 ` Chris Wilson
[not found] ` <20160823201626.13926-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2016-08-23 21:15 ` Leon Romanovsky [this message]
2016-08-23 21:15 ` Leon Romanovsky
2016-08-23 21:24 ` Chris Wilson
2016-08-24 3:35 ` Laurence Oberman
2016-08-24 3:35 ` Laurence Oberman
2016-08-24 15:32 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823211550.GQ15065@leon.nu \
--to=leonro-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.